* [Patch] cpufreq: tegra194: remove redundant AND with cpu_online_mask
@ 2023-10-09 8:24 Sumit Gupta
2023-10-09 8:41 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Sumit Gupta @ 2023-10-09 8:24 UTC (permalink / raw)
To: rafael, viresh.kumar, linux-pm, linux-tegra, linux-kernel
Cc: treding, jonathanh, bbasu, sumitg
Remove redundant 'AND' with cpu_online_mask as the policy->cpus always
contains only the currently online CPUs.
Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
Link: https://lore.kernel.org/lkml/20231003050019.a6mcchw2o2z2wkrh@vireshk-i7/
Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
---
drivers/cpufreq/tegra194-cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
index 386aed3637b4..607e699b3d84 100644
--- a/drivers/cpufreq/tegra194-cpufreq.c
+++ b/drivers/cpufreq/tegra194-cpufreq.c
@@ -135,7 +135,7 @@ static void tegra234_set_cpu_ndiv(struct cpufreq_policy *policy, u64 ndiv)
u32 cpu, cpuid, clusterid;
u64 mpidr_id;
- for_each_cpu_and(cpu, policy->cpus, cpu_online_mask) {
+ for_each_cpu(cpu, policy->cpus) {
data->soc->ops->get_cpu_cluster_id(cpu, &cpuid, &clusterid);
/* use physical id to get address of per core frequency register */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Patch] cpufreq: tegra194: remove redundant AND with cpu_online_mask
2023-10-09 8:24 [Patch] cpufreq: tegra194: remove redundant AND with cpu_online_mask Sumit Gupta
@ 2023-10-09 8:41 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2023-10-09 8:41 UTC (permalink / raw)
To: Sumit Gupta
Cc: rafael, linux-pm, linux-tegra, linux-kernel, treding, jonathanh,
bbasu
On 09-10-23, 13:54, Sumit Gupta wrote:
> Remove redundant 'AND' with cpu_online_mask as the policy->cpus always
> contains only the currently online CPUs.
>
> Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
> Link: https://lore.kernel.org/lkml/20231003050019.a6mcchw2o2z2wkrh@vireshk-i7/
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> ---
> drivers/cpufreq/tegra194-cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/tegra194-cpufreq.c b/drivers/cpufreq/tegra194-cpufreq.c
> index 386aed3637b4..607e699b3d84 100644
> --- a/drivers/cpufreq/tegra194-cpufreq.c
> +++ b/drivers/cpufreq/tegra194-cpufreq.c
> @@ -135,7 +135,7 @@ static void tegra234_set_cpu_ndiv(struct cpufreq_policy *policy, u64 ndiv)
> u32 cpu, cpuid, clusterid;
> u64 mpidr_id;
>
> - for_each_cpu_and(cpu, policy->cpus, cpu_online_mask) {
> + for_each_cpu(cpu, policy->cpus) {
> data->soc->ops->get_cpu_cluster_id(cpu, &cpuid, &clusterid);
>
> /* use physical id to get address of per core frequency register */
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-10-09 8:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-09 8:24 [Patch] cpufreq: tegra194: remove redundant AND with cpu_online_mask Sumit Gupta
2023-10-09 8:41 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox