* Re: [PATCH] dt-bindings: opp: drop maxItems from inner items
2024-03-04 23:43 [PATCH] dt-bindings: opp: drop maxItems from inner items David Heidelberg
@ 2024-03-05 5:38 ` Dhruva Gole
2024-03-05 14:50 ` Rob Herring
2024-03-06 5:32 ` Viresh Kumar
2 siblings, 0 replies; 4+ messages in thread
From: Dhruva Gole @ 2024-03-05 5:38 UTC (permalink / raw)
To: David Heidelberg, Viresh Kumar, Nishanth Menon, Stephen Boyd,
Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Manivannan Sadhasivam, Bjorn Andersson
Cc: Viresh Kumar, Krzysztof Kozlowski, linux-pm, devicetree,
linux-kernel
Hi,
On 05/03/24 05:13, David Heidelberg wrote:
> With recent changes within matrix dimensions calculation,
> dropping maxItems: 1 provides a warning-free run.
>
> Fixes warning such as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: opp-table: opp-200000000:opp-hz:0: [200000000, 0, 0, 150000000, 0, 0, 0, 0, 300000000] is too long
>
> Fixes: 3cb16ad69bef ("dt-bindings: opp: accept array of frequencies")
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> follow-up of https://lore.kernel.org/lkml/20231229191038.247258-1-david@ixit.cz/T/
>
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> index e2f8f7af3cf4..b1bb87c865ed 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> @@ -57,8 +57,6 @@ patternProperties:
> specific binding.
> minItems: 1
> maxItems: 32
> - items:
> - maxItems: 1
Thanks for the fix,
Reviewed-by: Dhruva Gole <d-gole@ti.com>
--
Thanks and Regards,
Dhruva Gole
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: opp: drop maxItems from inner items
2024-03-04 23:43 [PATCH] dt-bindings: opp: drop maxItems from inner items David Heidelberg
2024-03-05 5:38 ` Dhruva Gole
@ 2024-03-05 14:50 ` Rob Herring
2024-03-06 5:32 ` Viresh Kumar
2 siblings, 0 replies; 4+ messages in thread
From: Rob Herring @ 2024-03-05 14:50 UTC (permalink / raw)
To: David Heidelberg
Cc: Stephen Boyd, Krzysztof Kozlowski, devicetree,
Krzysztof Kozlowski, Bjorn Andersson, linux-kernel, Viresh Kumar,
linux-pm, Conor Dooley, Nishanth Menon, Manivannan Sadhasivam,
Viresh Kumar
On Tue, 05 Mar 2024 00:43:06 +0100, David Heidelberg wrote:
> With recent changes within matrix dimensions calculation,
> dropping maxItems: 1 provides a warning-free run.
>
> Fixes warning such as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: opp-table: opp-200000000:opp-hz:0: [200000000, 0, 0, 150000000, 0, 0, 0, 0, 300000000] is too long
>
> Fixes: 3cb16ad69bef ("dt-bindings: opp: accept array of frequencies")
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> follow-up of https://lore.kernel.org/lkml/20231229191038.247258-1-david@ixit.cz/T/
>
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] dt-bindings: opp: drop maxItems from inner items
2024-03-04 23:43 [PATCH] dt-bindings: opp: drop maxItems from inner items David Heidelberg
2024-03-05 5:38 ` Dhruva Gole
2024-03-05 14:50 ` Rob Herring
@ 2024-03-06 5:32 ` Viresh Kumar
2 siblings, 0 replies; 4+ messages in thread
From: Viresh Kumar @ 2024-03-06 5:32 UTC (permalink / raw)
To: David Heidelberg
Cc: Viresh Kumar, Nishanth Menon, Stephen Boyd, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Manivannan Sadhasivam,
Bjorn Andersson, Krzysztof Kozlowski, linux-pm, devicetree,
linux-kernel
On 05-03-24, 00:43, David Heidelberg wrote:
> With recent changes within matrix dimensions calculation,
> dropping maxItems: 1 provides a warning-free run.
>
> Fixes warning such as:
> arch/arm64/boot/dts/qcom/sdm845-oneplus-enchilada.dtb: opp-table: opp-200000000:opp-hz:0: [200000000, 0, 0, 150000000, 0, 0, 0, 0, 300000000] is too long
>
> Fixes: 3cb16ad69bef ("dt-bindings: opp: accept array of frequencies")
> Suggested-by: Rob Herring <robh@kernel.org>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> follow-up of https://lore.kernel.org/lkml/20231229191038.247258-1-david@ixit.cz/T/
>
> Documentation/devicetree/bindings/opp/opp-v2-base.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> index e2f8f7af3cf4..b1bb87c865ed 100644
> --- a/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> +++ b/Documentation/devicetree/bindings/opp/opp-v2-base.yaml
> @@ -57,8 +57,6 @@ patternProperties:
> specific binding.
> minItems: 1
> maxItems: 32
> - items:
> - maxItems: 1
>
> opp-microvolt:
> description: |
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 4+ messages in thread