* [RFC] set_blocksize() in kernel/power/swap.c (was Re: [PATCH vfs.all 22/26] block: stash a bdev_file to read/write raw blcok_device) [not found] ` <20240416063253.GA2118490@ZenIV> @ 2024-04-17 20:45 ` Al Viro 0 siblings, 0 replies; only message in thread From: Al Viro @ 2024-04-17 20:45 UTC (permalink / raw) To: Rafael J. Wysocki Cc: Jan Kara, Yu Kuai, hch, axboe, linux-fsdevel, linux-block, yi.zhang, yangerkun, yukuai (C), Christian Brauner, linux-pm On Tue, Apr 16, 2024 at 07:32:53AM +0100, Al Viro wrote: > kernel/power/swap.c:371: res = set_blocksize(file_bdev(hib_resume_bdev_file), PAGE_SIZE); > kernel/power/swap.c:1577: set_blocksize(file_bdev(hib_resume_bdev_file), PAGE_SIZE); > Special cases (for obvious reasons); said that, why do we bother > with set_blocksize() on those anyway? AFAICS, we really don't need either - all IO is done via hib_submit_io(), which sets a single-page bio and feeds it to submit_bio{,_wait}() directly. We are *not* using the page cache of the block device in question, let alone any buffer_head instances. Could swsusp folks comment? ^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-17 20:45 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <49f99e7b-3983-8074-bb09-4b093c1269d1@huaweicloud.com>
[not found] ` <20240410105911.hfxz4qh3n5ekrpqg@quack3>
[not found] ` <20240410223443.GG2118490@ZenIV>
[not found] ` <20240411-logik-besorgen-b7d590d6c1e9@brauner>
[not found] ` <20240411140409.GH2118490@ZenIV>
[not found] ` <20240412-egalisieren-fernreise-71b1f21f8e64@brauner>
[not found] ` <20240412112919.GN2118490@ZenIV>
[not found] ` <20240413-hievt-zweig-2e40ac6443aa@brauner>
[not found] ` <20240415204511.GV2118490@ZenIV>
[not found] ` <20240416063253.GA2118490@ZenIV>
2024-04-17 20:45 ` [RFC] set_blocksize() in kernel/power/swap.c (was Re: [PATCH vfs.all 22/26] block: stash a bdev_file to read/write raw blcok_device) Al Viro
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox