* [PATCH v1] PM: sleep: Update stale comment in device_resume()
@ 2024-12-04 13:02 Rafael J. Wysocki
2024-12-04 13:12 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2024-12-04 13:02 UTC (permalink / raw)
To: Linux PM; +Cc: Greg Kroah-Hartman, LKML, Ulf Hansson, Saravana Kannan
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
There is no function called __device_suspend() any more and it is still
mentioned in a comment in device_resume(), so update that comment.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/base/power/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-pm/drivers/base/power/main.c
===================================================================
--- linux-pm.orig/drivers/base/power/main.c
+++ linux-pm/drivers/base/power/main.c
@@ -914,7 +914,7 @@ static void device_resume(struct device
goto Complete;
if (dev->power.direct_complete) {
- /* Match the pm_runtime_disable() in __device_suspend(). */
+ /* Match the pm_runtime_disable() in device_suspend(). */
pm_runtime_enable(dev);
goto Complete;
}
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v1] PM: sleep: Update stale comment in device_resume()
2024-12-04 13:02 [PATCH v1] PM: sleep: Update stale comment in device_resume() Rafael J. Wysocki
@ 2024-12-04 13:12 ` Greg Kroah-Hartman
2024-12-04 14:16 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2024-12-04 13:12 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux PM, LKML, Ulf Hansson, Saravana Kannan
On Wed, Dec 04, 2024 at 02:02:04PM +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> There is no function called __device_suspend() any more and it is still
> mentioned in a comment in device_resume(), so update that comment.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/base/power/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-pm/drivers/base/power/main.c
> ===================================================================
Are you not using git? This looks like the old cvs output :)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] PM: sleep: Update stale comment in device_resume()
2024-12-04 13:12 ` Greg Kroah-Hartman
@ 2024-12-04 14:16 ` Rafael J. Wysocki
2024-12-04 14:20 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Rafael J. Wysocki @ 2024-12-04 14:16 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Rafael J. Wysocki, Linux PM, LKML, Ulf Hansson, Saravana Kannan
On Wed, Dec 4, 2024 at 2:12 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Dec 04, 2024 at 02:02:04PM +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >
> > There is no function called __device_suspend() any more and it is still
> > mentioned in a comment in device_resume(), so update that comment.
> >
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > ---
> > drivers/base/power/main.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux-pm/drivers/base/power/main.c
> > ===================================================================
>
> Are you not using git? This looks like the old cvs output :)
I use git, but for patch generation I prefer quilt which has produced
this patch.
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] PM: sleep: Update stale comment in device_resume()
2024-12-04 14:16 ` Rafael J. Wysocki
@ 2024-12-04 14:20 ` Greg Kroah-Hartman
2024-12-04 14:23 ` Rafael J. Wysocki
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2024-12-04 14:20 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Rafael J. Wysocki, Linux PM, LKML, Ulf Hansson, Saravana Kannan
On Wed, Dec 04, 2024 at 03:16:05PM +0100, Rafael J. Wysocki wrote:
> On Wed, Dec 4, 2024 at 2:12 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Wed, Dec 04, 2024 at 02:02:04PM +0100, Rafael J. Wysocki wrote:
> > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > >
> > > There is no function called __device_suspend() any more and it is still
> > > mentioned in a comment in device_resume(), so update that comment.
> > >
> > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > ---
> > > drivers/base/power/main.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > Index: linux-pm/drivers/base/power/main.c
> > > ===================================================================
> >
> > Are you not using git? This looks like the old cvs output :)
>
> I use git, but for patch generation I prefer quilt which has produced
> this patch.
From my .quiltrc:
QUILT_REFRESH_ARGS="--diffstat --strip-trailing-whitespace --no-timestamps --no-index --sort -p1 -p ab"
makes it almost look like the git output :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] PM: sleep: Update stale comment in device_resume()
2024-12-04 14:20 ` Greg Kroah-Hartman
@ 2024-12-04 14:23 ` Rafael J. Wysocki
0 siblings, 0 replies; 5+ messages in thread
From: Rafael J. Wysocki @ 2024-12-04 14:23 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Rafael J. Wysocki, Rafael J. Wysocki, Linux PM, LKML, Ulf Hansson,
Saravana Kannan
On Wed, Dec 4, 2024 at 3:20 PM Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> On Wed, Dec 04, 2024 at 03:16:05PM +0100, Rafael J. Wysocki wrote:
> > On Wed, Dec 4, 2024 at 2:12 PM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > >
> > > On Wed, Dec 04, 2024 at 02:02:04PM +0100, Rafael J. Wysocki wrote:
> > > > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > >
> > > > There is no function called __device_suspend() any more and it is still
> > > > mentioned in a comment in device_resume(), so update that comment.
> > > >
> > > > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > > > ---
> > > > drivers/base/power/main.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > Index: linux-pm/drivers/base/power/main.c
> > > > ===================================================================
> > >
> > > Are you not using git? This looks like the old cvs output :)
> >
> > I use git, but for patch generation I prefer quilt which has produced
> > this patch.
>
> From my .quiltrc:
> QUILT_REFRESH_ARGS="--diffstat --strip-trailing-whitespace --no-timestamps --no-index --sort -p1 -p ab"
>
> makes it almost look like the git output :)
Good to know, thanks for the hint!
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-12-04 14:23 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-04 13:02 [PATCH v1] PM: sleep: Update stale comment in device_resume() Rafael J. Wysocki
2024-12-04 13:12 ` Greg Kroah-Hartman
2024-12-04 14:16 ` Rafael J. Wysocki
2024-12-04 14:20 ` Greg Kroah-Hartman
2024-12-04 14:23 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox