* Re: [PATCH] pmdomain: thead: fix TH1520_AON_PROTOCOL dependency
2025-03-14 15:48 ` [PATCH] pmdomain: thead: fix TH1520_AON_PROTOCOL dependency Arnd Bergmann
@ 2025-03-14 16:41 ` Michal Wilczynski
2025-03-17 10:50 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Michal Wilczynski @ 2025-03-14 16:41 UTC (permalink / raw)
To: Arnd Bergmann, Drew Fustini, Guo Ren, Fu Wei, Ulf Hansson
Cc: Arnd Bergmann, linux-riscv, linux-pm, linux-kernel
On 3/14/25 16:48, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Kconfig treats the dependency as optional, but the header file only provides
> normal declarations and no empty API stubs:
>
> ld: fs/btrfs/extent_io.o: in function `writepage_delalloc':
> extent_io.c:(.text+0x2b42): undefined reference to `__udivdi3'
> ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_off':
> th1520-pm-domains.c:(.text+0x57): undefined reference to `th1520_aon_power_update'
> ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_on':
> th1520-pm-domains.c:(.text+0x8a): undefined reference to `th1520_aon_power_update'
> ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_probe':
> th1520-pm-domains.c:(.text+0xb8): undefined reference to `th1520_aon_init'
> ld: th1520-pm-domains.c:(.text+0x1c6): undefined reference to `th1520_aon_power_update'
>
> Since the firmware code can easily be enabled for compile testing, there
> is no need to add stubs either, so just make it a hard dependency.
>
> Fixes: dc9a897dbb03 ("pmdomain: thead: Add power-domain driver for TH1520")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pmdomain/thead/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/thead/Kconfig b/drivers/pmdomain/thead/Kconfig
> index c7a1ac0c61dc..7d52f8374b07 100644
> --- a/drivers/pmdomain/thead/Kconfig
> +++ b/drivers/pmdomain/thead/Kconfig
> @@ -2,7 +2,7 @@
>
> config TH1520_PM_DOMAINS
> tristate "Support TH1520 Power Domains"
> - depends on TH1520_AON_PROTOCOL || !TH1520_AON_PROTOCOL
> + depends on TH1520_AON_PROTOCOL
> select REGMAP_MMIO
> help
> This driver enables power domain management for the T-HEAD
Thanks a lot !
Reviewed-by: Michal Wilczynski <m.wilczynski@samsung.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pmdomain: thead: fix TH1520_AON_PROTOCOL dependency
2025-03-14 15:48 ` [PATCH] pmdomain: thead: fix TH1520_AON_PROTOCOL dependency Arnd Bergmann
2025-03-14 16:41 ` Michal Wilczynski
@ 2025-03-17 10:50 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2025-03-17 10:50 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Drew Fustini, Guo Ren, Fu Wei, Michal Wilczynski, Arnd Bergmann,
linux-riscv, linux-pm, linux-kernel
On Fri, 14 Mar 2025 at 16:48, Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Kconfig treats the dependency as optional, but the header file only provides
> normal declarations and no empty API stubs:
>
> ld: fs/btrfs/extent_io.o: in function `writepage_delalloc':
> extent_io.c:(.text+0x2b42): undefined reference to `__udivdi3'
> ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_off':
> th1520-pm-domains.c:(.text+0x57): undefined reference to `th1520_aon_power_update'
> ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_on':
> th1520-pm-domains.c:(.text+0x8a): undefined reference to `th1520_aon_power_update'
> ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_probe':
> th1520-pm-domains.c:(.text+0xb8): undefined reference to `th1520_aon_init'
> ld: th1520-pm-domains.c:(.text+0x1c6): undefined reference to `th1520_aon_power_update'
>
> Since the firmware code can easily be enabled for compile testing, there
> is no need to add stubs either, so just make it a hard dependency.
>
> Fixes: dc9a897dbb03 ("pmdomain: thead: Add power-domain driver for TH1520")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/pmdomain/thead/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/thead/Kconfig b/drivers/pmdomain/thead/Kconfig
> index c7a1ac0c61dc..7d52f8374b07 100644
> --- a/drivers/pmdomain/thead/Kconfig
> +++ b/drivers/pmdomain/thead/Kconfig
> @@ -2,7 +2,7 @@
>
> config TH1520_PM_DOMAINS
> tristate "Support TH1520 Power Domains"
> - depends on TH1520_AON_PROTOCOL || !TH1520_AON_PROTOCOL
> + depends on TH1520_AON_PROTOCOL
> select REGMAP_MMIO
> help
> This driver enables power domain management for the T-HEAD
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread