* [RFC v1] dt-bindings: interconnect: add mt7988-cci compatible
@ 2025-05-28 13:52 Frank Wunderlich
2025-05-30 15:57 ` Conor Dooley
0 siblings, 1 reply; 3+ messages in thread
From: Frank Wunderlich @ 2025-05-28 13:52 UTC (permalink / raw)
To: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Georgi Djakov,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Jia-Wei Chang, Johnson Wang
Cc: Frank Wunderlich, linux-pm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek
From: Frank Wunderlich <frank-w@public-files.de>
Add compatible for Mediatek MT7988 SoC with mediatek,mt8183-cci fallback
which is taken by driver.
Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
---
.../bindings/interconnect/mediatek,cci.yaml | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml b/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
index 58611ba2a0f4..2c6785c588e9 100644
--- a/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
+++ b/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
@@ -17,9 +17,15 @@ description: |
properties:
compatible:
- enum:
- - mediatek,mt8183-cci
- - mediatek,mt8186-cci
+ oneOf:
+ - items:
+ - enum:
+ - mediatek,mt8183-cci
+ - mediatek,mt8186-cci
+ - items:
+ - enum:
+ - mediatek,mt7988-cci
+ - const: mediatek,mt8183-cci
clocks:
items:
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFC v1] dt-bindings: interconnect: add mt7988-cci compatible
2025-05-28 13:52 [RFC v1] dt-bindings: interconnect: add mt7988-cci compatible Frank Wunderlich
@ 2025-05-30 15:57 ` Conor Dooley
2025-05-30 16:11 ` Frank Wunderlich
0 siblings, 1 reply; 3+ messages in thread
From: Conor Dooley @ 2025-05-30 15:57 UTC (permalink / raw)
To: Frank Wunderlich
Cc: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Georgi Djakov,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Jia-Wei Chang, Johnson Wang,
Frank Wunderlich, linux-pm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek
[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]
On Wed, May 28, 2025 at 03:52:49PM +0200, Frank Wunderlich wrote:
> From: Frank Wunderlich <frank-w@public-files.de>
>
> Add compatible for Mediatek MT7988 SoC with mediatek,mt8183-cci fallback
> which is taken by driver.
What's RFC about the patch?
>
> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
> ---
> .../bindings/interconnect/mediatek,cci.yaml | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml b/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
> index 58611ba2a0f4..2c6785c588e9 100644
> --- a/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
> +++ b/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
> @@ -17,9 +17,15 @@ description: |
>
> properties:
> compatible:
> - enum:
> - - mediatek,mt8183-cci
> - - mediatek,mt8186-cci
> + oneOf:
> + - items:
This "- items:" is redundant.
> + - enum:
> + - mediatek,mt8183-cci
> + - mediatek,mt8186-cci
> + - items:
> + - enum:
> + - mediatek,mt7988-cci
> + - const: mediatek,mt8183-cci
>
> clocks:
> items:
> --
> 2.43.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC v1] dt-bindings: interconnect: add mt7988-cci compatible
2025-05-30 15:57 ` Conor Dooley
@ 2025-05-30 16:11 ` Frank Wunderlich
0 siblings, 0 replies; 3+ messages in thread
From: Frank Wunderlich @ 2025-05-30 16:11 UTC (permalink / raw)
To: Conor Dooley
Cc: MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Georgi Djakov,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno, Jia-Wei Chang, Johnson Wang,
Frank Wunderlich, linux-pm, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek
Hi
Thank you for review.
Am 30. Mai 2025 17:57:20 MESZ schrieb Conor Dooley <conor@kernel.org>:
>On Wed, May 28, 2025 at 03:52:49PM +0200, Frank Wunderlich wrote:
>> From: Frank Wunderlich <frank-w@public-files.de>
>>
>> Add compatible for Mediatek MT7988 SoC with mediatek,mt8183-cci fallback
>> which is taken by driver.
>
>What's RFC about the patch?
We have merge window,but maybe this rule is
net(-next) only. And i was unsure if enum for
new compatible is right or if i should use 2
const.
>>
>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>> ---
>> .../bindings/interconnect/mediatek,cci.yaml | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml b/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
>> index 58611ba2a0f4..2c6785c588e9 100644
>> --- a/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
>> +++ b/Documentation/devicetree/bindings/interconnect/mediatek,cci.yaml
>> @@ -17,9 +17,15 @@ description: |
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8183-cci
>> - - mediatek,mt8186-cci
>> + oneOf:
>> + - items:
>
>This "- items:" is redundant.
Ok,i try without it.
>> + - enum:
>> + - mediatek,mt8183-cci
>> + - mediatek,mt8186-cci
>> + - items:
>> + - enum:
>> + - mediatek,mt7988-cci
>> + - const: mediatek,mt8183-cci
>>
>> clocks:
>> items:
>> --
>> 2.43.0
>>
regards Frank
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-05-30 16:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-05-28 13:52 [RFC v1] dt-bindings: interconnect: add mt7988-cci compatible Frank Wunderlich
2025-05-30 15:57 ` Conor Dooley
2025-05-30 16:11 ` Frank Wunderlich
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox