Linux Power Management development
 help / color / mirror / Atom feed
From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: Georgi Djakov <djakov@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Neil Armstrong <neil.armstrong@linaro.org>
Subject: [PATCH v2 00/28] interconnect: qcom: icc-rpmh: use NULL-terminated arrays and drop static IDs
Date: Fri, 04 Jul 2025 19:35:12 +0300	[thread overview]
Message-ID: <20250704-rework-icc-v2-0-875fac996ef5@oss.qualcomm.com> (raw)

Qualcomm interconnect code has been using .num_foo fields together with
the arrays embedded in the structure, which results in hard-to-notice
mistakes if .num_foo gets omitted or incorrect.

Rework RPMh interconnect code to use NULL-terminated arrays for the
dynamic IDs case (as now all the arrays contain only pointers) and,
while we are at it, rework all the drivers to use dynamic IDs and drop
static IDs code.

This series touches only RPMh interconnect drivers. Corresponding series
for RPM drivers will follow up shortly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Changes in v2:
- Rebased on linux-next, dropping applied dependency
- Link to v1: https://lore.kernel.org/r/20250616-rework-icc-v1-0-bc1326294d71@oss.qualcomm.com

---
Dmitry Baryshkov (28):
      interconnect: qcom: sc8280xp: specify num_links for qnm_a1noc_cfg
      interconnect: qcom: sc8180x: specify num_nodes
      interconnect: qcom: rpmh: make nodes a NULL_terminated array
      interconnect: qcom: rpmh: make link_nodes a NULL_terminated array
      interconnect: qcom: sc7280: convert to dynamic IDs
      interconnect: qcom: sc8180x: convert to dynamic IDs
      interconnect: qcom: sc8280xp: convert to dynamic IDs
      interconnect: qcom: sdm845: convert to dynamic IDs
      interconnect: qcom: sm8250: convert to dynamic IDs
      interconnect: qcom: x1e80100: convert to dynamic IDs
      interconnect: qcom: qcs615: convert to dynamic IDs
      interconnect: qcom: qcs8300: convert to dynamic IDs
      interconnect: qcom: qdu1000: convert to dynamic IDs
      interconnect: qcom: sar2130p: convert to dynamic IDs
      interconnect: qcom: sc7180: convert to dynamic IDs
      interconnect: qcom: sdm670: convert to dynamic IDs
      interconnect: qcom: sdx55: convert to dynamic IDs
      interconnect: qcom: sdx65: convert to dynamic IDs
      interconnect: qcom: sdx75: convert to dynamic IDs
      interconnect: qcom: sm6350: convert to dynamic IDs
      interconnect: qcom: sm7150: convert to dynamic IDs
      interconnect: qcom: sm8150: convert to dynamic IDs
      interconnect: qcom: sm8350: convert to dynamic IDs
      interconnect: qcom: sm8450: convert to dynamic IDs
      interconnect: qcom: sm8550: convert to dynamic IDs
      interconnect: qcom: sm8650: convert to dynamic IDs
      interconnect: qcom: sm8750: convert to dynamic IDs
      interconnect: qcom: icc-rpmh: drop support for non-dynamic IDS

 drivers/interconnect/qcom/bcm-voter.c |    4 +-
 drivers/interconnect/qcom/icc-rpmh.c  |   20 +-
 drivers/interconnect/qcom/icc-rpmh.h  |   13 +-
 drivers/interconnect/qcom/qcs615.c    |  713 ++++++++-----------
 drivers/interconnect/qcom/qcs615.h    |  128 ----
 drivers/interconnect/qcom/qcs8300.c   |  911 +++++++++++-------------
 drivers/interconnect/qcom/qcs8300.h   |  177 -----
 drivers/interconnect/qcom/qdu1000.c   |  470 ++++++------
 drivers/interconnect/qcom/qdu1000.h   |   95 ---
 drivers/interconnect/qcom/sa8775p.c   |  493 ++++++-------
 drivers/interconnect/qcom/sar2130p.c  |  795 ++++++++-------------
 drivers/interconnect/qcom/sc7180.c    |  892 +++++++++++------------
 drivers/interconnect/qcom/sc7180.h    |  149 ----
 drivers/interconnect/qcom/sc7280.c    |  840 ++++++++++------------
 drivers/interconnect/qcom/sc7280.h    |  154 ----
 drivers/interconnect/qcom/sc8180x.c   | 1013 +++++++++++++-------------
 drivers/interconnect/qcom/sc8180x.h   |  179 -----
 drivers/interconnect/qcom/sc8280xp.c  | 1257 ++++++++++++++++-----------------
 drivers/interconnect/qcom/sc8280xp.h  |  209 ------
 drivers/interconnect/qcom/sdm670.c    |  712 +++++++++----------
 drivers/interconnect/qcom/sdm670.h    |  128 ----
 drivers/interconnect/qcom/sdm845.c    |  986 ++++++++++++--------------
 drivers/interconnect/qcom/sdm845.h    |  140 ----
 drivers/interconnect/qcom/sdx55.c     |  611 ++++++++--------
 drivers/interconnect/qcom/sdx55.h     |   70 --
 drivers/interconnect/qcom/sdx65.c     |  577 +++++++--------
 drivers/interconnect/qcom/sdx65.h     |   65 --
 drivers/interconnect/qcom/sdx75.c     |  498 ++++++-------
 drivers/interconnect/qcom/sdx75.h     |   97 ---
 drivers/interconnect/qcom/sm6350.c    |  838 +++++++++++-----------
 drivers/interconnect/qcom/sm6350.h    |  139 ----
 drivers/interconnect/qcom/sm7150.c    |  860 +++++++++++-----------
 drivers/interconnect/qcom/sm7150.h    |  140 ----
 drivers/interconnect/qcom/sm8150.c    |  930 ++++++++++++------------
 drivers/interconnect/qcom/sm8150.h    |  152 ----
 drivers/interconnect/qcom/sm8250.c    |  977 ++++++++++++-------------
 drivers/interconnect/qcom/sm8250.h    |  168 -----
 drivers/interconnect/qcom/sm8350.c    |  901 ++++++++++++-----------
 drivers/interconnect/qcom/sm8350.h    |  158 -----
 drivers/interconnect/qcom/sm8450.c    |  823 ++++++++++-----------
 drivers/interconnect/qcom/sm8450.h    |  169 -----
 drivers/interconnect/qcom/sm8550.c    |  683 ++++++++----------
 drivers/interconnect/qcom/sm8550.h    |  138 ----
 drivers/interconnect/qcom/sm8650.c    |  713 ++++++++-----------
 drivers/interconnect/qcom/sm8650.h    |  144 ----
 drivers/interconnect/qcom/sm8750.c    |  779 ++++++++------------
 drivers/interconnect/qcom/x1e80100.c  |  819 ++++++++++-----------
 drivers/interconnect/qcom/x1e80100.h  |  192 -----
 48 files changed, 8655 insertions(+), 13464 deletions(-)
---
base-commit: 26ffb3d6f02cd0935fb9fa3db897767beee1cb2a
change-id: 20250613-rework-icc-0d3b7276a798

Best regards,
-- 
With best wishes
Dmitry


             reply	other threads:[~2025-07-04 16:35 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-04 16:35 Dmitry Baryshkov [this message]
2025-07-04 16:35 ` [PATCH v2 01/28] interconnect: qcom: sc8280xp: specify num_links for qnm_a1noc_cfg Dmitry Baryshkov
2025-07-08 12:59   ` Konrad Dybcio
2025-07-04 16:35 ` [PATCH v2 02/28] interconnect: qcom: sc8180x: specify num_nodes Dmitry Baryshkov
2025-07-08 13:00   ` Konrad Dybcio
2025-07-04 16:35 ` [PATCH v2 03/28] interconnect: qcom: rpmh: make nodes a NULL_terminated array Dmitry Baryshkov
2025-07-08 16:41   ` Konrad Dybcio
2025-07-18 13:38   ` Georgi Djakov
2025-07-18 17:26     ` Dmitry Baryshkov
2025-07-18 22:17       ` Konrad Dybcio
2025-07-18 22:44         ` Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 04/28] interconnect: qcom: rpmh: make link_nodes " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 05/28] interconnect: qcom: sc7280: convert to dynamic IDs Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 06/28] interconnect: qcom: sc8180x: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 07/28] interconnect: qcom: sc8280xp: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 08/28] interconnect: qcom: sdm845: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 09/28] interconnect: qcom: sm8250: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 10/28] interconnect: qcom: x1e80100: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 11/28] interconnect: qcom: qcs615: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 12/28] interconnect: qcom: qcs8300: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 13/28] interconnect: qcom: qdu1000: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 14/28] interconnect: qcom: sar2130p: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 15/28] interconnect: qcom: sc7180: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 16/28] interconnect: qcom: sdm670: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 17/28] interconnect: qcom: sdx55: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 18/28] interconnect: qcom: sdx65: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 19/28] interconnect: qcom: sdx75: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 20/28] interconnect: qcom: sm6350: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 21/28] interconnect: qcom: sm7150: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 22/28] interconnect: qcom: sm8150: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 23/28] interconnect: qcom: sm8350: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 24/28] interconnect: qcom: sm8450: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 25/28] interconnect: qcom: sm8550: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 26/28] interconnect: qcom: sm8650: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 27/28] interconnect: qcom: sm8750: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 28/28] interconnect: qcom: icc-rpmh: drop support for non-dynamic IDS Dmitry Baryshkov
2025-07-08 16:44   ` Konrad Dybcio
2025-07-16 15:22 ` [PATCH v2 00/28] interconnect: qcom: icc-rpmh: use NULL-terminated arrays and drop static IDs Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250704-rework-icc-v2-0-875fac996ef5@oss.qualcomm.com \
    --to=dmitry.baryshkov@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=djakov@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=neil.armstrong@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox