From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Georgi Djakov <djakov@kernel.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 28/28] interconnect: qcom: icc-rpmh: drop support for non-dynamic IDS
Date: Tue, 8 Jul 2025 18:44:06 +0200 [thread overview]
Message-ID: <cef8c989-4a0a-44dd-b0b6-15454f98193e@oss.qualcomm.com> (raw)
In-Reply-To: <20250704-rework-icc-v2-28-875fac996ef5@oss.qualcomm.com>
On 7/4/25 6:35 PM, Dmitry Baryshkov wrote:
> Now as all RPMh interconnect drivers were converted to using the dynamic
> IDs, drop support for non-dynamic ID allocation.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
[...]
> diff --git a/drivers/interconnect/qcom/icc-rpmh.c b/drivers/interconnect/qcom/icc-rpmh.c
> index 941692cbaf208c66a27dda2e6902b2f26f605840..796fba9fb316cf58ae2eb77af1607d6d00c38438 100644
> --- a/drivers/interconnect/qcom/icc-rpmh.c
> +++ b/drivers/interconnect/qcom/icc-rpmh.c
> @@ -280,14 +280,10 @@ int qcom_icc_rpmh_probe(struct platform_device *pdev)
> if (!qn)
> continue;
>
> - if (desc->alloc_dyn_id) {
> - if (!qn->node)
> - qn->node = icc_node_create_dyn();
> - node = qn->node;
> - } else {
> - node = icc_node_create(qn->id);
> - }
> + if (!qn->node)
> + qn->node = icc_node_create_dyn();
>
> + node = qn->node;
we can drop the 'node' binding now, I think
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2025-07-08 16:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-04 16:35 [PATCH v2 00/28] interconnect: qcom: icc-rpmh: use NULL-terminated arrays and drop static IDs Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 01/28] interconnect: qcom: sc8280xp: specify num_links for qnm_a1noc_cfg Dmitry Baryshkov
2025-07-08 12:59 ` Konrad Dybcio
2025-07-04 16:35 ` [PATCH v2 02/28] interconnect: qcom: sc8180x: specify num_nodes Dmitry Baryshkov
2025-07-08 13:00 ` Konrad Dybcio
2025-07-04 16:35 ` [PATCH v2 03/28] interconnect: qcom: rpmh: make nodes a NULL_terminated array Dmitry Baryshkov
2025-07-08 16:41 ` Konrad Dybcio
2025-07-18 13:38 ` Georgi Djakov
2025-07-18 17:26 ` Dmitry Baryshkov
2025-07-18 22:17 ` Konrad Dybcio
2025-07-18 22:44 ` Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 04/28] interconnect: qcom: rpmh: make link_nodes " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 05/28] interconnect: qcom: sc7280: convert to dynamic IDs Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 06/28] interconnect: qcom: sc8180x: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 07/28] interconnect: qcom: sc8280xp: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 08/28] interconnect: qcom: sdm845: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 09/28] interconnect: qcom: sm8250: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 10/28] interconnect: qcom: x1e80100: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 11/28] interconnect: qcom: qcs615: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 12/28] interconnect: qcom: qcs8300: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 13/28] interconnect: qcom: qdu1000: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 14/28] interconnect: qcom: sar2130p: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 15/28] interconnect: qcom: sc7180: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 16/28] interconnect: qcom: sdm670: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 17/28] interconnect: qcom: sdx55: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 18/28] interconnect: qcom: sdx65: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 19/28] interconnect: qcom: sdx75: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 20/28] interconnect: qcom: sm6350: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 21/28] interconnect: qcom: sm7150: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 22/28] interconnect: qcom: sm8150: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 23/28] interconnect: qcom: sm8350: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 24/28] interconnect: qcom: sm8450: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 25/28] interconnect: qcom: sm8550: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 26/28] interconnect: qcom: sm8650: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 27/28] interconnect: qcom: sm8750: " Dmitry Baryshkov
2025-07-04 16:35 ` [PATCH v2 28/28] interconnect: qcom: icc-rpmh: drop support for non-dynamic IDS Dmitry Baryshkov
2025-07-08 16:44 ` Konrad Dybcio [this message]
2025-07-16 15:22 ` [PATCH v2 00/28] interconnect: qcom: icc-rpmh: use NULL-terminated arrays and drop static IDs Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cef8c989-4a0a-44dd-b0b6-15454f98193e@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox