[PATCH v2] PM / devfreq: Fix memory leak in devfreq_event_add_edev()

[PATCH v2] PM / devfreq: Fix memory leak in devfreq_event_add_edev()

[Kaushlendra Kumar]

Add missing kfree() call to prevent memory leak when device_register()
fails in devfreq_event_add_edev(). The allocated edev structure was not
being freed in the error path, causing a memory leak.

When device_register() fails, the edev structure allocated earlier in
the function needs to be freed before calling put_device() to avoid
leaking memory.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
---
Changes in v2:
- moved kfree after put_device based on review feedback
---
 drivers/devfreq/devfreq-event.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c
index 70219099c604..34406c52b845 100644
--- a/drivers/devfreq/devfreq-event.c
+++ b/drivers/devfreq/devfreq-event.c
@@ -328,6 +328,7 @@ struct devfreq_event_dev *devfreq_event_add_edev(struct device *dev,
 	ret = device_register(&edev->dev);
 	if (ret < 0) {
 		put_device(&edev->dev);
+		kfree(edev);
 		return ERR_PTR(ret);
 	}
 	dev_set_drvdata(&edev->dev, edev);
-- 
2.34.1

Re: [PATCH v2] PM / devfreq: Fix memory leak in devfreq_event_add_edev()

[Chanwoo Choi]

Hi,

Applied it. Thanks.

On Sun, Sep 7, 2025 at 8:34 PM Kaushlendra Kumar
<kaushlendra.kumar@intel.com> wrote:
>
> Add missing kfree() call to prevent memory leak when device_register()
> fails in devfreq_event_add_edev(). The allocated edev structure was not
> being freed in the error path, causing a memory leak.
>
> When device_register() fails, the edev structure allocated earlier in
> the function needs to be freed before calling put_device() to avoid
> leaking memory.
>
> Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
> ---
> Changes in v2:
> - moved kfree after put_device based on review feedback
> ---
>  drivers/devfreq/devfreq-event.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/devfreq-event.c b/drivers/devfreq/devfreq-event.c
> index 70219099c604..34406c52b845 100644
> --- a/drivers/devfreq/devfreq-event.c
> +++ b/drivers/devfreq/devfreq-event.c
> @@ -328,6 +328,7 @@ struct devfreq_event_dev *devfreq_event_add_edev(struct device *dev,
>         ret = device_register(&edev->dev);
>         if (ret < 0) {
>                 put_device(&edev->dev);
> +               kfree(edev);
>                 return ERR_PTR(ret);
>         }
>         dev_set_drvdata(&edev->dev, edev);
> --
> 2.34.1
>
>


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics