From: Dhruva Gole <d-gole@ti.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
<linux-pm@vger.kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Peter Zijlstra <peterz@infradead.org>,
Kevin Hilman <khilman@baylibre.com>,
Pavel Machek <pavel@kernel.org>, Len Brown <len.brown@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Maulik Shah <quic_mkshah@quicinc.com>,
"Prasad Sodagudi" <psodagud@quicinc.com>,
Deepti Jaggi <quic_djaggi@quicinc.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 5/6] cpuidle: Respect the CPU system wakeup QoS limit for cpuidle
Date: Tue, 25 Nov 2025 11:11:15 +0530 [thread overview]
Message-ID: <20251125054115.7y26ize7h5kqhe5l@lcpd911> (raw)
In-Reply-To: <20251121100315.316300-6-ulf.hansson@linaro.org>
On Nov 21, 2025 at 11:03:11 +0100, Ulf Hansson wrote:
> The CPU system wakeup QoS limit must be respected for the regular cpuidle
> state selection. Therefore, let's extend the common governor helper
> cpuidle_governor_latency_req(), to take the constraint into account.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
Reviewed-by: Dhruva Gole <d-gole@ti.com>
>
> Changes in v3:
> - New patch.
>
> ---
> drivers/cpuidle/governor.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/cpuidle/governor.c b/drivers/cpuidle/governor.c
> index 0d0f9751ff8f..5d0e7f78c6c5 100644
> --- a/drivers/cpuidle/governor.c
> +++ b/drivers/cpuidle/governor.c
> @@ -111,6 +111,10 @@ s64 cpuidle_governor_latency_req(unsigned int cpu)
> struct device *device = get_cpu_device(cpu);
> int device_req = dev_pm_qos_raw_resume_latency(device);
> int global_req = cpu_latency_qos_limit();
> + int global_wake_req = cpu_wakeup_latency_qos_limit();
> +
> + if (global_req > global_wake_req)
> + global_req = global_wake_req;
>
> if (device_req > global_req)
> device_req = global_req;
> --
> 2.43.0
>
--
Best regards,
Dhruva Gole
Texas Instruments Incorporated
next prev parent reply other threads:[~2025-11-25 5:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-21 10:03 [PATCH v3 0/6] PM: QoS: Introduce a CPU system wakeup QoS limit for s2idle Ulf Hansson
2025-11-21 10:03 ` [PATCH v3 1/6] PM: QoS: Introduce a CPU system wakeup QoS limit Ulf Hansson
2025-11-25 4:56 ` Dhruva Gole
2025-11-21 10:03 ` [PATCH v3 2/6] pmdomain: Respect the CPU system wakeup QoS limit for s2idle Ulf Hansson
2025-11-25 5:27 ` Dhruva Gole
2025-11-21 10:03 ` [PATCH v3 3/6] pmdomain: Respect the CPU system wakeup QoS limit for cpuidle Ulf Hansson
2025-11-25 5:28 ` Dhruva Gole
2025-11-21 10:03 ` [PATCH v3 4/6] sched: idle: Respect the CPU system wakeup QoS limit for s2idle Ulf Hansson
2025-11-25 5:39 ` Dhruva Gole
2025-11-21 10:03 ` [PATCH v3 5/6] cpuidle: Respect the CPU system wakeup QoS limit for cpuidle Ulf Hansson
2025-11-25 5:41 ` Dhruva Gole [this message]
2025-11-21 10:03 ` [PATCH v3 6/6] Documentation: power/cpuidle: Document the CPU system wakeup latency QoS Ulf Hansson
2025-11-24 18:36 ` Dhruva Gole
2025-11-24 18:27 ` [PATCH v3 0/6] PM: QoS: Introduce a CPU system wakeup QoS limit for s2idle Rafael J. Wysocki
2025-11-25 11:31 ` Ulf Hansson
2025-11-24 23:43 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251125054115.7y26ize7h5kqhe5l@lcpd911 \
--to=d-gole@ti.com \
--cc=daniel.lezcano@linaro.org \
--cc=khilman@baylibre.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@kernel.org \
--cc=peterz@infradead.org \
--cc=psodagud@quicinc.com \
--cc=quic_djaggi@quicinc.com \
--cc=quic_mkshah@quicinc.com \
--cc=rafael@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox