[PATCH] tools: lib: thermal: Correct CFLAGS and LDFLAGS in pkg-config template

[PATCH] tools: lib: thermal: Correct CFLAGS and LDFLAGS in pkg-config template

[Romain Gantois]

There are two issues with the current pkg-config template. Firstly, the
-lthermal linker flag is missing. Secondly, the libnl3 include directory
compiler flag references "include" instead of "includedir", which leads to
an unexpanded variable when pkg-config is called.

Add the missing -lthermal flag and correct the libnl3 include directory.

Signed-off-by: Romain Gantois <romain.gantois@bootlin.com>
---
 tools/lib/thermal/libthermal.pc.template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/lib/thermal/libthermal.pc.template b/tools/lib/thermal/libthermal.pc.template
index ac24d0ab17f5..3b8a24d0a8b8 100644
--- a/tools/lib/thermal/libthermal.pc.template
+++ b/tools/lib/thermal/libthermal.pc.template
@@ -8,5 +8,5 @@ Name: libthermal
 Description: thermal library
 Requires: libnl-3.0 libnl-genl-3.0
 Version: @VERSION@
-Libs: -L${libdir} -lnl-genl-3 -lnl-3
-Cflags: -I${includedir} -I${include}/libnl3
+Libs: -L${libdir} -lnl-genl-3 -lnl-3 -lthermal
+Cflags: -I${includedir} -I${includedir}/libnl3

---
base-commit: d113735421da322ea144c9778c433de6ff6bc57b
change-id: 20251226-libthermal-pkgconfig-23259b10478a

Best regards,
-- 
Romain Gantois <romain.gantois@bootlin.com>

Re: [PATCH] tools: lib: thermal: Correct CFLAGS and LDFLAGS in pkg-config template

[Thomas Petazzoni]

Hello Romain,

On Fri, 26 Dec 2025 08:54:32 +0100
Romain Gantois <romain.gantois@bootlin.com> wrote:

> diff --git a/tools/lib/thermal/libthermal.pc.template b/tools/lib/thermal/libthermal.pc.template
> index ac24d0ab17f5..3b8a24d0a8b8 100644
> --- a/tools/lib/thermal/libthermal.pc.template
> +++ b/tools/lib/thermal/libthermal.pc.template
> @@ -8,5 +8,5 @@ Name: libthermal
>  Description: thermal library
>  Requires: libnl-3.0 libnl-genl-3.0
>  Version: @VERSION@
> -Libs: -L${libdir} -lnl-genl-3 -lnl-3
> -Cflags: -I${includedir} -I${include}/libnl3
> +Libs: -L${libdir} -lnl-genl-3 -lnl-3 -lthermal
> +Cflags: -I${includedir} -I${includedir}/libnl3

Actually -lnl-genl-3 -lnl-3 in Libs and -I${includedir}/libnl3 in
Cflags can be removed as well, because the Requires: field contains
libnl-3.0 and libnl-genl-3.0, which will cause pkg-config to
recursively query the libs/cflags for libnl-3.0 and libnl-genl-3.0.

From https://people.freedesktop.org/~dbn/pkg-config-guide.html:

=====================================================================

Cflags: The compiler flags specific to this package and any required
libraries that don't support pkg-config. If the required libraries
support pkg-config, they should be added to Requires or
Requires.private.

Libs: The link flags specific to this package and any required
libraries that don't support pkg-config. The same rule as Cflags
applies here.

=====================================================================

Since libnl-3.0 and libnl-genl-3.0 support pkg-config (otherwise they
wouldn't be listed in Requires:), then those flags should be dropped
from Libs: and Cflags:.

Also, since this is a fix, probably this commit requires a Fixes: tag.

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com

Re: [PATCH] tools: lib: thermal: Correct CFLAGS and LDFLAGS in pkg-config template

[Daniel Lezcano]

On 12/26/25 08:54, Romain Gantois wrote:
> There are two issues with the current pkg-config template. Firstly, the
> -lthermal linker flag is missing. Secondly, the libnl3 include directory
> compiler flag references "include" instead of "includedir", which leads to
> an unexpanded variable when pkg-config is called.
> 
> Add the missing -lthermal flag and correct the libnl3 include directory.
> 
> Signed-off-by: Romain Gantois <romain.gantois@bootlin.com>
> ---

Applied, thanks



-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog