* [PATCH v2] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
@ 2026-01-20 23:57 Val Packett
2026-01-21 0:35 ` Dmitry Baryshkov
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Val Packett @ 2026-01-20 23:57 UTC (permalink / raw)
To: Sebastian Reichel, Abel Vesa, Dmitry Baryshkov
Cc: Val Packett, Sebastian Reichel, linux-arm-msm, linux-pm,
linux-kernel
On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i'
for the battery chemistry type, but only all-uppercase "LIP" was being
recognized. Add the CamelCase variant to the check to fix the "Unknown
battery technology" warning.
Fixes: 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry")
Signed-off-by: Val Packett <val@packett.cool>
---
v2: removed extra parentheses
v1: https://lore.kernel.org/all/20260117210941.6219-1-val@packett.cool/
drivers/power/supply/qcom_battmgr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c
index c8028606bba0..80572ee945b4 100644
--- a/drivers/power/supply/qcom_battmgr.c
+++ b/drivers/power/supply/qcom_battmgr.c
@@ -1240,7 +1240,8 @@ static unsigned int qcom_battmgr_sc8280xp_parse_technology(const char *chemistry
if ((!strncmp(chemistry, "LIO", BATTMGR_CHEMISTRY_LEN)) ||
(!strncmp(chemistry, "OOI", BATTMGR_CHEMISTRY_LEN)))
return POWER_SUPPLY_TECHNOLOGY_LION;
- if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN))
+ if (!strncmp(chemistry, "LIP", BATTMGR_CHEMISTRY_LEN) ||
+ !strncmp(chemistry, "LiP", BATTMGR_CHEMISTRY_LEN))
return POWER_SUPPLY_TECHNOLOGY_LIPO;
pr_err("Unknown battery technology '%s'\n", chemistry);
--
2.51.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
2026-01-20 23:57 [PATCH v2] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer Val Packett
@ 2026-01-21 0:35 ` Dmitry Baryshkov
2026-01-21 10:37 ` Konrad Dybcio
2026-01-30 22:24 ` Sebastian Reichel
2 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2026-01-21 0:35 UTC (permalink / raw)
To: Val Packett
Cc: Sebastian Reichel, Abel Vesa, Sebastian Reichel, linux-arm-msm,
linux-pm, linux-kernel
On Tue, Jan 20, 2026 at 08:57:58PM -0300, Val Packett wrote:
> On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i'
> for the battery chemistry type, but only all-uppercase "LIP" was being
> recognized. Add the CamelCase variant to the check to fix the "Unknown
> battery technology" warning.
>
> Fixes: 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry")
> Signed-off-by: Val Packett <val@packett.cool>
> ---
> v2: removed extra parentheses
> v1: https://lore.kernel.org/all/20260117210941.6219-1-val@packett.cool/
>
> drivers/power/supply/qcom_battmgr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Thanks!
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
2026-01-20 23:57 [PATCH v2] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer Val Packett
2026-01-21 0:35 ` Dmitry Baryshkov
@ 2026-01-21 10:37 ` Konrad Dybcio
2026-01-30 22:24 ` Sebastian Reichel
2 siblings, 0 replies; 4+ messages in thread
From: Konrad Dybcio @ 2026-01-21 10:37 UTC (permalink / raw)
To: Val Packett, Sebastian Reichel, Abel Vesa, Dmitry Baryshkov
Cc: Sebastian Reichel, linux-arm-msm, linux-pm, linux-kernel
On 1/21/26 12:57 AM, Val Packett wrote:
> On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i'
> for the battery chemistry type, but only all-uppercase "LIP" was being
> recognized. Add the CamelCase variant to the check to fix the "Unknown
> battery technology" warning.
>
> Fixes: 202ac22b8e2e ("power: supply: qcom_battmgr: Add lithium-polymer entry")
> Signed-off-by: Val Packett <val@packett.cool>
> ---
FYI I *think* this data comes from vendors so this list may end
up growing and growing..
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
2026-01-20 23:57 [PATCH v2] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer Val Packett
2026-01-21 0:35 ` Dmitry Baryshkov
2026-01-21 10:37 ` Konrad Dybcio
@ 2026-01-30 22:24 ` Sebastian Reichel
2 siblings, 0 replies; 4+ messages in thread
From: Sebastian Reichel @ 2026-01-30 22:24 UTC (permalink / raw)
To: Sebastian Reichel, Abel Vesa, Dmitry Baryshkov, Val Packett
Cc: linux-arm-msm, linux-pm, linux-kernel
On Tue, 20 Jan 2026 20:57:58 -0300, Val Packett wrote:
> On the Dell Latitude 7455, the firmware uses "LiP" with a lowercase 'i'
> for the battery chemistry type, but only all-uppercase "LIP" was being
> recognized. Add the CamelCase variant to the check to fix the "Unknown
> battery technology" warning.
>
>
Applied, thanks!
[1/1] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer
commit: c655f45480637aee326b5bd96488d35ab90db2b0
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-01-30 22:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-01-20 23:57 [PATCH v2] power: supply: qcom_battmgr: Recognize "LiP" as lithium-polymer Val Packett
2026-01-21 0:35 ` Dmitry Baryshkov
2026-01-21 10:37 ` Konrad Dybcio
2026-01-30 22:24 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox