* [rafael-pm:bleeding-edge 15/24] drivers/platform/x86/xo15-ebook.c:104:17: error: label 'err_free_input' used but not defined
@ 2026-05-07 19:56 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2026-05-07 19:56 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: oe-kbuild-all, linux-acpi, linux-pm
tree: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git bleeding-edge
head: 232e74ed0633787ae1258c7d33ef7599210396ce
commit: f3f83acc4b2615dc2f4a25bc5bcca4af83cf0cae [15/24] platform/x86: xo15-ebook: Register ACPI notify handler directly
config: i386-buildonly-randconfig-004-20260507 (https://download.01.org/0day-ci/archive/20260508/202605080333.a4CP1ejZ-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260508/202605080333.a4CP1ejZ-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605080333.a4CP1ejZ-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/platform/x86/xo15-ebook.c: In function 'ebook_switch_add':
>> drivers/platform/x86/xo15-ebook.c:104:17: error: label 'err_free_input' used but not defined
104 | goto err_free_input;
| ^~~~
vim +/err_free_input +104 drivers/platform/x86/xo15-ebook.c
44cb98c48e19f5 Rafael J. Wysocki 2012-06-27 80
89ca11771a4b50 Paul Fox 2011-02-03 81 static int ebook_switch_add(struct acpi_device *device)
89ca11771a4b50 Paul Fox 2011-02-03 82 {
39789590cff404 Andy Shevchenko 2023-10-10 83 const struct acpi_device_id *id;
89ca11771a4b50 Paul Fox 2011-02-03 84 struct ebook_switch *button;
89ca11771a4b50 Paul Fox 2011-02-03 85 struct input_dev *input;
89ca11771a4b50 Paul Fox 2011-02-03 86 int error;
89ca11771a4b50 Paul Fox 2011-02-03 87
bf4afc53b77aea Linus Torvalds 2026-02-21 88 button = kzalloc_obj(struct ebook_switch);
89ca11771a4b50 Paul Fox 2011-02-03 89 if (!button)
89ca11771a4b50 Paul Fox 2011-02-03 90 return -ENOMEM;
89ca11771a4b50 Paul Fox 2011-02-03 91
89ca11771a4b50 Paul Fox 2011-02-03 92 device->driver_data = button;
89ca11771a4b50 Paul Fox 2011-02-03 93
89ca11771a4b50 Paul Fox 2011-02-03 94 button->input = input = input_allocate_device();
89ca11771a4b50 Paul Fox 2011-02-03 95 if (!input) {
89ca11771a4b50 Paul Fox 2011-02-03 96 error = -ENOMEM;
89ca11771a4b50 Paul Fox 2011-02-03 97 goto err_free_button;
89ca11771a4b50 Paul Fox 2011-02-03 98 }
89ca11771a4b50 Paul Fox 2011-02-03 99
39789590cff404 Andy Shevchenko 2023-10-10 100 id = acpi_match_acpi_device(ebook_device_ids, device);
39789590cff404 Andy Shevchenko 2023-10-10 101 if (!id) {
39789590cff404 Andy Shevchenko 2023-10-10 102 dev_err(&device->dev, "Unsupported hid\n");
89ca11771a4b50 Paul Fox 2011-02-03 103 error = -ENODEV;
89ca11771a4b50 Paul Fox 2011-02-03 @104 goto err_free_input;
89ca11771a4b50 Paul Fox 2011-02-03 105 }
89ca11771a4b50 Paul Fox 2011-02-03 106
8625c4c06a79dd Ilpo Järvinen 2025-04-07 107 strscpy(acpi_device_name(device), XO15_EBOOK_DEVICE_NAME);
8625c4c06a79dd Ilpo Järvinen 2025-04-07 108 strscpy(acpi_device_class(device), XO15_EBOOK_CLASS "/" XO15_EBOOK_SUBCLASS);
89ca11771a4b50 Paul Fox 2011-02-03 109
39789590cff404 Andy Shevchenko 2023-10-10 110 snprintf(button->phys, sizeof(button->phys), "%s/button/input0", id->id);
89ca11771a4b50 Paul Fox 2011-02-03 111
8625c4c06a79dd Ilpo Järvinen 2025-04-07 112 input->name = acpi_device_name(device);
89ca11771a4b50 Paul Fox 2011-02-03 113 input->phys = button->phys;
89ca11771a4b50 Paul Fox 2011-02-03 114 input->id.bustype = BUS_HOST;
89ca11771a4b50 Paul Fox 2011-02-03 115 input->dev.parent = &device->dev;
89ca11771a4b50 Paul Fox 2011-02-03 116
89ca11771a4b50 Paul Fox 2011-02-03 117 input->evbit[0] = BIT_MASK(EV_SW);
89ca11771a4b50 Paul Fox 2011-02-03 118 set_bit(SW_TABLET_MODE, input->swbit);
89ca11771a4b50 Paul Fox 2011-02-03 119
89ca11771a4b50 Paul Fox 2011-02-03 120 error = input_register_device(input);
f3f83acc4b2615 Rafael J. Wysocki 2026-02-09 121 if (error) {
f3f83acc4b2615 Rafael J. Wysocki 2026-02-09 122 input_free_device(input);
f3f83acc4b2615 Rafael J. Wysocki 2026-02-09 123 goto err_free_button;
f3f83acc4b2615 Rafael J. Wysocki 2026-02-09 124 }
f3f83acc4b2615 Rafael J. Wysocki 2026-02-09 125
f3f83acc4b2615 Rafael J. Wysocki 2026-02-09 126 error = acpi_dev_install_notify_handler(device, ACPI_DEVICE_NOTIFY,
f3f83acc4b2615 Rafael J. Wysocki 2026-02-09 127 ebook_switch_notify, device);
89ca11771a4b50 Paul Fox 2011-02-03 128 if (error)
f3f83acc4b2615 Rafael J. Wysocki 2026-02-09 129 goto err_unregister_input;
89ca11771a4b50 Paul Fox 2011-02-03 130
89ca11771a4b50 Paul Fox 2011-02-03 131 ebook_send_state(device);
89ca11771a4b50 Paul Fox 2011-02-03 132
89ca11771a4b50 Paul Fox 2011-02-03 133 if (device->wakeup.flags.valid) {
89ca11771a4b50 Paul Fox 2011-02-03 134 /* Button's GPE is run-wake GPE */
89ca11771a4b50 Paul Fox 2011-02-03 135 acpi_enable_gpe(device->wakeup.gpe_device,
89ca11771a4b50 Paul Fox 2011-02-03 136 device->wakeup.gpe_number);
89ca11771a4b50 Paul Fox 2011-02-03 137 device_set_wakeup_enable(&device->dev, true);
89ca11771a4b50 Paul Fox 2011-02-03 138 }
89ca11771a4b50 Paul Fox 2011-02-03 139
89ca11771a4b50 Paul Fox 2011-02-03 140 return 0;
89ca11771a4b50 Paul Fox 2011-02-03 141
f3f83acc4b2615 Rafael J. Wysocki 2026-02-09 142 err_unregister_input:
f3f83acc4b2615 Rafael J. Wysocki 2026-02-09 143 input_unregister_device(input);
89ca11771a4b50 Paul Fox 2011-02-03 144 err_free_button:
89ca11771a4b50 Paul Fox 2011-02-03 145 kfree(button);
89ca11771a4b50 Paul Fox 2011-02-03 146 return error;
89ca11771a4b50 Paul Fox 2011-02-03 147 }
89ca11771a4b50 Paul Fox 2011-02-03 148
:::::: The code at line 104 was first introduced by commit
:::::: 89ca11771a4b50ed616ab6c37e0ef333d02f1d47 OLPC XO-1.5 ebook switch driver
:::::: TO: Paul Fox <pgf@laptop.org>
:::::: CC: Matthew Garrett <mjg@redhat.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2026-05-07 19:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-07 19:56 [rafael-pm:bleeding-edge 15/24] drivers/platform/x86/xo15-ebook.c:104:17: error: label 'err_free_input' used but not defined kernel test robot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox