Linux Power Management development
 help / color / mirror / Atom feed
From: Henry Tseng <henrytseng@qnap.com>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Len Brown <lenb@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org, SW Chen <swchen@qnap.com>,
	Kevin Ko <kevinko@qnap.com>, Henry Tseng <henrytseng@qnap.com>
Subject: Re: [PATCH] cpufreq: intel_pstate: Use CPPC to get scaling factor for Bartlett Lake
Date: Fri,  8 May 2026 14:37:02 +0800	[thread overview]
Message-ID: <20260508063702.3249414-1-henrytseng@qnap.com> (raw)
In-Reply-To: <5ff02dfbafea7f5a9129853ae147e6de1cefb281.camel@linux.intel.com>

On Thu, 07 May 2026 07:47:05 -0700, srinivas pandruvada wrote:
> So I suggest to send two patches. The first one can have 
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -2273,6 +2273,9 @@ static int knl_get_turbo_pstate(int cpu)
>  static int hwp_get_cpu_scaling(int cpu)
>  {
>         if (hybrid_scaling_factor) {
> +               if (!cpu_feature_enabled(X86_FEATURE_HYBRID_CPU))
> +                       return hybrid_scaling_factor;
> +
> You can add Fixes tag for commit
> 9b18d536b124357fee56d82b1462c02f78d219e5.
> 
> The second patch with hybrid scaling factor for Bartlett Lake, which is
> like RPL. 
> 
> Thanks,
> Srinivas

Thanks for the review. I've sent v2 with the two patches as suggested.
Henry

      reply	other threads:[~2026-05-08  6:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06  9:51 [PATCH] cpufreq: intel_pstate: Use CPPC to get scaling factor for Bartlett Lake Henry Tseng
2026-05-06 12:15 ` srinivas pandruvada
2026-05-07  9:25   ` Henry Tseng
2026-05-07 14:47     ` srinivas pandruvada
2026-05-08  6:37       ` Henry Tseng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508063702.3249414-1-henrytseng@qnap.com \
    --to=henrytseng@qnap.com \
    --cc=kevinko@qnap.com \
    --cc=lenb@kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=swchen@qnap.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox