[PATCH] Fixed a bug related to thermal framework boundary conditions: trip points do not need to be updated when polling is active, whereas they must be update to re-enable the irq when polling is inactive

[PATCH] Fixed a bug related to thermal framework boundary conditions: trip points do not need to be updated when polling is active, whereas they must be update to re-enable the irq when polling is inactive

[jipinghuang]

Signed-off-by: jipinghuang <jipihuan@qti.qualcomm.com>
---
 drivers/thermal/thermal_trip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/thermal_trip.c b/drivers/thermal/thermal_trip.c
index 4b8238468b53..b6f868f7a310 100644
--- a/drivers/thermal/thermal_trip.c
+++ b/drivers/thermal/thermal_trip.c
@@ -61,7 +61,7 @@ void thermal_zone_set_trips(struct thermal_zone_device *tz, int low, int high)
 		return;
 
 	/* No need to change trip points */
-	if (tz->prev_low_trip == low && tz->prev_high_trip == high)
+	if (tz->prev_low_trip == low && tz->prev_high_trip == high && tz->temperature >= trip_temp)
 		return;
 
 	tz->prev_low_trip = low;
-- 
2.34.1

Re: [PATCH] Fixed a bug related to thermal framework boundary conditions: trip points do not need to be updated when polling is active, whereas they must be update to re-enable the irq when polling is inactive

[kernel test robot]

Hi jipinghuang,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/thermal]
[also build test ERROR on linus/master v7.2-rc5 next-20260726]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/jipinghuang/Fixed-a-bug-related-to-thermal-framework-boundary-conditions-trip-points-do-not-need-to-be-updated-when-polling-is-activ/20260727-115235
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link:    https://lore.kernel.org/r/20260727035037.554303-1-jipihuan%40qti.qualcomm.com
patch subject: [PATCH] Fixed a bug related to thermal framework boundary conditions: trip points do not need to be updated when polling is active, whereas they must be update to re-enable the irq when polling is inactive
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20260727/202607271050.J6ZhMOwT-lkp@intel.com/config)
compiler: clang version 22.1.8 (https://github.com/llvm/llvm-project ca7933e47d3a3451d81e72ac174dcb5aa28b59d1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260727/202607271050.J6ZhMOwT-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202607271050.J6ZhMOwT-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/thermal/thermal_trip.c:64:83: error: use of undeclared identifier 'trip_temp'
      64 |         if (tz->prev_low_trip == low && tz->prev_high_trip == high && tz->temperature >= trip_temp)
         |                                                                                          ^~~~~~~~~
   1 error generated.


vim +/trip_temp +64 drivers/thermal/thermal_trip.c

    53	
    54	void thermal_zone_set_trips(struct thermal_zone_device *tz, int low, int high)
    55	{
    56		int ret;
    57	
    58		lockdep_assert_held(&tz->lock);
    59	
    60		if (!tz->ops.set_trips)
    61			return;
    62	
    63		/* No need to change trip points */
  > 64		if (tz->prev_low_trip == low && tz->prev_high_trip == high && tz->temperature >= trip_temp)
    65			return;
    66	
    67		tz->prev_low_trip = low;
    68		tz->prev_high_trip = high;
    69	
    70		dev_dbg(&tz->device,
    71			"new temperature boundaries: %d < x < %d\n", low, high);
    72	
    73		/*
    74		 * Set a temperature window. When this window is left the driver
    75		 * must inform the thermal core via thermal_zone_device_update.
    76		 */
    77		ret = tz->ops.set_trips(tz, low, high);
    78		if (ret)
    79			dev_err(&tz->device, "Failed to set trips: %d\n", ret);
    80	}
    81	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Re: [PATCH] Fixed a bug related to thermal framework boundary conditions: trip points do not need to be updated when polling is active, whereas they must be update to re-enable the irq when polling is inactive

[kernel test robot]

Hi jipinghuang,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/thermal]
[also build test ERROR on linus/master v7.2-rc5 next-20260726]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/jipinghuang/Fixed-a-bug-related-to-thermal-framework-boundary-conditions-trip-points-do-not-need-to-be-updated-when-polling-is-activ/20260727-115235
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git thermal
patch link:    https://lore.kernel.org/r/20260727035037.554303-1-jipihuan%40qti.qualcomm.com
patch subject: [PATCH] Fixed a bug related to thermal framework boundary conditions: trip points do not need to be updated when polling is active, whereas they must be update to re-enable the irq when polling is inactive
config: x86_64-rhel-9.4-bpf (https://download.01.org/0day-ci/archive/20260727/202607271036.K1hH4r4a-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260727/202607271036.K1hH4r4a-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202607271036.K1hH4r4a-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/thermal/thermal_trip.c: In function 'thermal_zone_set_trips':
>> drivers/thermal/thermal_trip.c:64:90: error: 'trip_temp' undeclared (first use in this function)
      64 |         if (tz->prev_low_trip == low && tz->prev_high_trip == high && tz->temperature >= trip_temp)
         |                                                                                          ^~~~~~~~~
   drivers/thermal/thermal_trip.c:64:90: note: each undeclared identifier is reported only once for each function it appears in


vim +/trip_temp +64 drivers/thermal/thermal_trip.c

    53	
    54	void thermal_zone_set_trips(struct thermal_zone_device *tz, int low, int high)
    55	{
    56		int ret;
    57	
    58		lockdep_assert_held(&tz->lock);
    59	
    60		if (!tz->ops.set_trips)
    61			return;
    62	
    63		/* No need to change trip points */
  > 64		if (tz->prev_low_trip == low && tz->prev_high_trip == high && tz->temperature >= trip_temp)
    65			return;
    66	
    67		tz->prev_low_trip = low;
    68		tz->prev_high_trip = high;
    69	
    70		dev_dbg(&tz->device,
    71			"new temperature boundaries: %d < x < %d\n", low, high);
    72	
    73		/*
    74		 * Set a temperature window. When this window is left the driver
    75		 * must inform the thermal core via thermal_zone_device_update.
    76		 */
    77		ret = tz->ops.set_trips(tz, low, high);
    78		if (ret)
    79			dev_err(&tz->device, "Failed to set trips: %d\n", ret);
    80	}
    81	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

[PATCH] Fixed a bug related to thermal framework boundary conditions: trip points do not need to be updated when polling is active, whereas they must be update to re-enable the irq when polling is inactive

[jipinghuang]

Signed-off-by: jipinghuang <jipihuan@qti.qualcomm.com>
---
 drivers/thermal/thermal_trip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/thermal/thermal_trip.c b/drivers/thermal/thermal_trip.c
index 4b8238468b53..b6f868f7a310 100644
--- a/drivers/thermal/thermal_trip.c
+++ b/drivers/thermal/thermal_trip.c
@@ -61,7 +61,7 @@ void thermal_zone_set_trips(struct thermal_zone_device *tz, int low, int high)
 		return;
 
 	/* No need to change trip points */
-	if (tz->prev_low_trip == low && tz->prev_high_trip == high)
+	if (tz->prev_low_trip == low && tz->prev_high_trip == high && tz->temperature >= trip_temp)
 		return;
 
 	tz->prev_low_trip = low;
-- 
2.34.1