linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Revert "pmdomain: qcom: rpmhpd: Add missing MXC and MMCX power domains for Eliza"
@ 2026-08-19  5:55 Abel Vesa
  2026-08-21 12:51 ` Ulf Hansson
  0 siblings, 1 reply; 3+ messages in thread
From: Abel Vesa @ 2026-08-19  5:55 UTC (permalink / raw)
  To: Ulf Hansson; +Cc: stable, linux-arm-msm, linux-pm, linux-kernel, Abel Vesa

This reverts commit b48a0a0a76ccecec60f0568e2af4d89994b08bec, which
wrongfully added the MXC and MMCX power domains on Eliza.

Even though they are indeed available in cmd-db, which has been the source
of information for adding these two, at hardware level they are not
actually wired up. Therefore they need to be dropped.

Fixes: b48a0a0a76cc ("pmdomain: qcom: rpmhpd: Add missing MXC and MMCX power domains for Eliza")
Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
---
 drivers/pmdomain/qcom/rpmhpd.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
index 96e4bd2f5a14..90743275942d 100644
--- a/drivers/pmdomain/qcom/rpmhpd.c
+++ b/drivers/pmdomain/qcom/rpmhpd.c
@@ -241,13 +241,9 @@ static struct rpmhpd *eliza_rpmhpds[] = {
 	[RPMHPD_GFX] = &gfx,
 	[RPMHPD_LCX] = &lcx,
 	[RPMHPD_LMX] = &lmx,
-	[RPMHPD_MMCX] = &mmcx,
-	[RPMHPD_MMCX_AO] = &mmcx_ao,
 	[RPMHPD_MSS] = &mss,
 	[RPMHPD_MX] = &mx,
 	[RPMHPD_MX_AO] = &mx_ao,
-	[RPMHPD_MXC] = &mxc,
-	[RPMHPD_MXC_AO] = &mxc_ao,
 	[RPMHPD_NSP] = &nsp,
 };
 

---
base-commit: 5453bc3279e9f8578ac3e534d476240e40c879e1
change-id: 20260819-pmdomain-revert-adding-mxc-mmcx-on-eliza-647d25519f0c

Best regards,
--  
Abel Vesa <abel.vesa@oss.qualcomm.com>


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] Revert "pmdomain: qcom: rpmhpd: Add missing MXC and MMCX power domains for Eliza"
  2026-08-19  5:55 [PATCH] Revert "pmdomain: qcom: rpmhpd: Add missing MXC and MMCX power domains for Eliza" Abel Vesa
@ 2026-08-21 12:51 ` Ulf Hansson
  2026-08-25 11:49   ` Sasha Levin
  0 siblings, 1 reply; 3+ messages in thread
From: Ulf Hansson @ 2026-08-21 12:51 UTC (permalink / raw)
  To: Abel Vesa; +Cc: Ulf Hansson, stable, linux-arm-msm, linux-pm, linux-kernel

On Wed, Aug 19, 2026 at 7:55 AM Abel Vesa <abel.vesa@oss.qualcomm.com> wrote:
>
> This reverts commit b48a0a0a76ccecec60f0568e2af4d89994b08bec, which
> wrongfully added the MXC and MMCX power domains on Eliza.
>
> Even though they are indeed available in cmd-db, which has been the source
> of information for adding these two, at hardware level they are not
> actually wired up. Therefore they need to be dropped.
>
> Fixes: b48a0a0a76cc ("pmdomain: qcom: rpmhpd: Add missing MXC and MMCX power domains for Eliza")
> Signed-off-by: Abel Vesa <abel.vesa@oss.qualcomm.com>

Applied for fixes and by adding a stable tag, thanks!

Kind regards
Uffe


> ---
>  drivers/pmdomain/qcom/rpmhpd.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/pmdomain/qcom/rpmhpd.c b/drivers/pmdomain/qcom/rpmhpd.c
> index 96e4bd2f5a14..90743275942d 100644
> --- a/drivers/pmdomain/qcom/rpmhpd.c
> +++ b/drivers/pmdomain/qcom/rpmhpd.c
> @@ -241,13 +241,9 @@ static struct rpmhpd *eliza_rpmhpds[] = {
>         [RPMHPD_GFX] = &gfx,
>         [RPMHPD_LCX] = &lcx,
>         [RPMHPD_LMX] = &lmx,
> -       [RPMHPD_MMCX] = &mmcx,
> -       [RPMHPD_MMCX_AO] = &mmcx_ao,
>         [RPMHPD_MSS] = &mss,
>         [RPMHPD_MX] = &mx,
>         [RPMHPD_MX_AO] = &mx_ao,
> -       [RPMHPD_MXC] = &mxc,
> -       [RPMHPD_MXC_AO] = &mxc_ao,
>         [RPMHPD_NSP] = &nsp,
>  };
>
>
> ---
> base-commit: 5453bc3279e9f8578ac3e534d476240e40c879e1
> change-id: 20260819-pmdomain-revert-adding-mxc-mmcx-on-eliza-647d25519f0c
>
> Best regards,
> --
> Abel Vesa <abel.vesa@oss.qualcomm.com>
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Revert "pmdomain: qcom: rpmhpd: Add missing MXC and MMCX power domains for Eliza"
  2026-08-21 12:51 ` Ulf Hansson
@ 2026-08-25 11:49   ` Sasha Levin
  0 siblings, 0 replies; 3+ messages in thread
From: Sasha Levin @ 2026-08-25 11:49 UTC (permalink / raw)
  To: Abel Vesa
  Cc: Sasha Levin, Ulf Hansson, stable, linux-arm-msm, linux-pm,
	linux-kernel, Ulf Hansson

On Fri, Aug 21, 2026 at 02:51:24PM +0200, Ulf Hansson wrote:
> Applied for fixes and by adding a stable tag, thanks!

Thanks - then there is nothing for us to do ahead of time.

b48a0a0a76cc ("pmdomain: qcom: rpmhpd: Add missing MXC and MMCX power
domains for Eliza") only reached 7.1.y (6.18 and older have no
eliza_rpmhpds table at all), and the revert will flow into 7.1.y
automatically once it lands in Linus' tree with the stable tag. No
stable-only revert needed.

-- 
Thanks,
Sasha

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2026-08-25 11:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-19  5:55 [PATCH] Revert "pmdomain: qcom: rpmhpd: Add missing MXC and MMCX power domains for Eliza" Abel Vesa
2026-08-21 12:51 ` Ulf Hansson
2026-08-25 11:49   ` Sasha Levin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).