From: Zihuan Zhang <zhangzihuan@kylinos.cn>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Linux PM <linux-pm@vger.kernel.org>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Jonathan Cameron <jonathan.cameron@huawei.com>
Subject: Re: [PATCH v1 2/3] cpufreq: intel_pstate: Rearrange freq QoS updates using __free()
Date: Tue, 9 Sep 2025 08:47:05 +0800 [thread overview]
Message-ID: <2571f264-62ea-4e2c-96f0-a61b6f7dcde7@kylinos.cn> (raw)
In-Reply-To: <CAJZ5v0i+GBpv_mGnYMbNjr2d1pvXJ_NqYCp8+pgOTNpCTuue8A@mail.gmail.com>
在 2025/9/9 02:10, Rafael J. Wysocki 写道:
>> I also noticed that in this driver some places use one naming style and
>> others use another, so it might be worth unifying the style here.
> Well, I'm not sure about this.
>
> I guess it may be confusing sometimes, but then I'm not sure if that
> justifies the code churn that would result from changing it.
Agreed — there are quite a lot of places that would need to be changed,
and perhaps it’s better to keep the current style as is.
next prev parent reply other threads:[~2025-09-09 0:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-05 13:51 [PATCH v1 0/3] cpufreq: intel_pstate: A fix, a __free()-based simplification, and a follow-up adjustment Rafael J. Wysocki
2025-09-05 13:52 ` [PATCH v1 1/3] cpufreq: intel_pstate: Fix object lifecycle issue in update_qos_request() Rafael J. Wysocki
2025-09-08 0:41 ` Zihuan Zhang
2025-09-05 13:52 ` [PATCH v1 2/3] cpufreq: intel_pstate: Rearrange freq QoS updates using __free() Rafael J. Wysocki
2025-09-08 0:53 ` Zihuan Zhang
2025-09-08 18:10 ` Rafael J. Wysocki
2025-09-09 0:47 ` Zihuan Zhang [this message]
2025-09-05 13:53 ` [PATCH v1 3/3] cpufreq: intel_pstate: Adjust frequency percentage computations Rafael J. Wysocki
2025-09-08 1:12 ` [PATCH v1 3/3] cpufreq: intel_pstate: Adjust frequency percentage Zihuan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2571f264-62ea-4e2c-96f0-a61b6f7dcde7@kylinos.cn \
--to=zhangzihuan@kylinos.cn \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox