From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: "yu-chang.lee" <yu-chang.lee@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
mandyjh.liu@mediatek.com, fan.chen@mediatek.com,
xiufeng.li@mediatek.com
Subject: Re: [PATCH 0/2] soc: mediatek: pm-domains: solve power domain glitch issue
Date: Mon, 25 Mar 2024 14:06:31 +0100 [thread overview]
Message-ID: <2625bf93-1501-4e5d-b492-de9bcffa93ec@collabora.com> (raw)
In-Reply-To: <20240325121908.3958-1-yu-chang.lee@mediatek.com>
Il 25/03/24 13:19, yu-chang.lee ha scritto:
> Hi,
>
> This series aims to solve power-off failures and occasional SMI hang issues that
> occur during camera stress tests. The issue arises because, when MTCMOS powers on
> or off, signal glitches are sometimes produced. This is fairly normal, but the
> software must address it to avoid mistaking the glitch for a transaction signal.
>
> The solutions in these patches can be summarized as follows:
>
> 1. Disable the sub-common port after turning off the Larb CG and before turning
> off the Larb MTCMOS.
> 2. Use CLAMP to disable/enable the SMI common port.
> 3. Implement an AXI reset.
> For previous discussion on the direction of the code modifications, please refer
> to: https://lore.kernel.org/linux-arm-kernel/c476cc48-17ec-4e14-98d8-35bdffb5d296@collabora.com/
>
>
> yu-chang.lee (2):
> soc: mediatek: pm-domains: add smi_larb_reset function when power on
> soc: mediatek: pm-domains: support smi clamp protection
Can you please change both commit titles to use "pmdomain: mediatek:" instead of
"soc: mediatek:"?
Thanks
Angelo
>
> drivers/pmdomain/mediatek/mt8188-pm-domains.h | 69 +++++-
> drivers/pmdomain/mediatek/mtk-pm-domains.c | 206 +++++++++++++++---
> drivers/pmdomain/mediatek/mtk-pm-domains.h | 13 ++
> 3 files changed, 255 insertions(+), 33 deletions(-)
>
prev parent reply other threads:[~2024-03-25 13:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 12:19 [PATCH 0/2] soc: mediatek: pm-domains: solve power domain glitch issue yu-chang.lee
2024-03-25 12:19 ` [PATCH 1/2] soc: mediatek: pm-domains: add smi_larb_reset function when power on yu-chang.lee
2024-03-25 12:58 ` AngeloGioacchino Del Regno
2024-03-25 12:19 ` [PATCH 2/2] soc: mediatek: pm-domains: support smi clamp protection yu-chang.lee
2024-03-25 13:05 ` AngeloGioacchino Del Regno
2024-03-26 2:00 ` Yu-chang Lee (李禹璋)
2024-03-26 13:57 ` AngeloGioacchino Del Regno
2024-03-25 13:06 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2625bf93-1501-4e5d-b492-de9bcffa93ec@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=fan.chen@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mandyjh.liu@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=xiufeng.li@mediatek.com \
--cc=yu-chang.lee@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox