[PATCH v1 0/2] cpuidle: intel_idle: Kerneldoc update and cleanup

[PATCH v1 0/2] cpuidle: intel_idle: Kerneldoc update and cleanup

[Rafael J. Wysocki]

Hi All,

The following patches fix a kerneldoc comment and clean up whitespace in
intel_idle.

Please refer to the patch changelogs for details.

Thanks!

[PATCH v1 1/2] cpuidle: intel_idle: Update intel_idle() kerneldoc comment

[Rafael J. Wysocki]

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Commit bf9282dc26e7 ("cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic")
moved the leave_mm() call away from intel_idle(), but it didn't update
its kerneldoc comment accordingly, so do that now.

Fixes: bf9282dc26e7 ("cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/idle/intel_idle.c |    3 ---
 1 file changed, 3 deletions(-)

Index: linux-pm/drivers/idle/intel_idle.c
===================================================================
--- linux-pm.orig/drivers/idle/intel_idle.c
+++ linux-pm/drivers/idle/intel_idle.c
@@ -122,9 +122,6 @@ static unsigned int mwait_substates __in
  * If the local APIC timer is not known to be reliable in the target idle state,
  * enable one-shot tick broadcasting for the target CPU before executing MWAIT.
  *
- * Optionally call leave_mm() for the target CPU upfront to avoid wakeups due to
- * flushing user TLBs.
- *
  * Must be called under local_irq_disable().
  */
 static __cpuidle int intel_idle(struct cpuidle_device *dev,

Re: [PATCH v1 1/2] cpuidle: intel_idle: Update intel_idle() kerneldoc comment

[Rafael J. Wysocki]

On Tue, Mar 15, 2022 at 8:37 PM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Commit bf9282dc26e7 ("cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic")
> moved the leave_mm() call away from intel_idle(), but it didn't update
> its kerneldoc comment accordingly, so do that now.
>
> Fixes: bf9282dc26e7 ("cpuidle: Make CPUIDLE_FLAG_TLB_FLUSHED generic")
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/idle/intel_idle.c |    3 ---
>  1 file changed, 3 deletions(-)
>
> Index: linux-pm/drivers/idle/intel_idle.c
> ===================================================================
> --- linux-pm.orig/drivers/idle/intel_idle.c
> +++ linux-pm/drivers/idle/intel_idle.c
> @@ -122,9 +122,6 @@ static unsigned int mwait_substates __in
>   * If the local APIC timer is not known to be reliable in the target idle state,
>   * enable one-shot tick broadcasting for the target CPU before executing MWAIT.
>   *
> - * Optionally call leave_mm() for the target CPU upfront to avoid wakeups due to
> - * flushing user TLBs.
> - *
>   * Must be called under local_irq_disable().
>   */
>  static __cpuidle int intel_idle(struct cpuidle_device *dev,
>

Assuming no objections, so applied.

[PATCH v1 2/2] cpuidle: intel_idle: Drop redundant backslash at line end

[Rafael J. Wysocki]

From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Drop a redundant backslash character at the end of a line in the
spr_cstates[] definition.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/idle/intel_idle.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-pm/drivers/idle/intel_idle.c
===================================================================
--- linux-pm.orig/drivers/idle/intel_idle.c
+++ linux-pm/drivers/idle/intel_idle.c
@@ -781,7 +781,7 @@ static struct cpuidle_state spr_cstates[
 	{
 		.name = "C1E",
 		.desc = "MWAIT 0x01",
-		.flags = MWAIT2flg(0x01) | CPUIDLE_FLAG_ALWAYS_ENABLE | \
+		.flags = MWAIT2flg(0x01) | CPUIDLE_FLAG_ALWAYS_ENABLE |
 					   CPUIDLE_FLAG_UNUSABLE,
 		.exit_latency = 2,
 		.target_residency = 4,

Re: [PATCH v1 2/2] cpuidle: intel_idle: Drop redundant backslash at line end

[Rafael J. Wysocki]

On Wednesday, March 16, 2022 9:56:42 AM CET Artem Bityutskiy wrote:
> On Tue, 2022-03-15 at 20:36 +0100, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > 
> > Drop a redundant backslash character at the end of a line in the
> > spr_cstates[] definition.
> > 
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Rafael, thanks for cleaning this up. Sorry for this.

No big deal.  I'm taking this as an ACK. :-)