* [PATCH] cpufreq, intel_pstate, minor cleanup for FRAC_BITS
@ 2015-12-08 18:44 Prarit Bhargava
2015-12-09 1:53 ` Viresh Kumar
2015-12-12 2:27 ` Rafael J. Wysocki
0 siblings, 2 replies; 3+ messages in thread
From: Prarit Bhargava @ 2015-12-08 18:44 UTC (permalink / raw)
To: linux-pm
Cc: Prarit Bhargava, Srinivas Pandruvada, Len Brown,
Rafael J. Wysocki, Viresh Kumar
785ee27 ("cpufreq: intel_pstate: Fix limits->max_perf rounding error")
hardcodes the value of FRAC_BITS. This patch fixes that minor issue.
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Len Brown <lenb@kernel.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Prarit Bhargava <prarit@redhat.com>
---
drivers/cpufreq/intel_pstate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
index 4d07cbd..98fb882 100644
--- a/drivers/cpufreq/intel_pstate.c
+++ b/drivers/cpufreq/intel_pstate.c
@@ -1123,7 +1123,7 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy)
limits->max_sysfs_pct);
limits->max_perf_pct = max(limits->min_policy_pct,
limits->max_perf_pct);
- limits->max_perf = round_up(limits->max_perf, 8);
+ limits->max_perf = round_up(limits->max_perf, FRAC_BITS);
/* Make sure min_perf_pct <= max_perf_pct */
limits->min_perf_pct = min(limits->max_perf_pct, limits->min_perf_pct);
--
1.7.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cpufreq, intel_pstate, minor cleanup for FRAC_BITS
2015-12-08 18:44 [PATCH] cpufreq, intel_pstate, minor cleanup for FRAC_BITS Prarit Bhargava
@ 2015-12-09 1:53 ` Viresh Kumar
2015-12-12 2:27 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2015-12-09 1:53 UTC (permalink / raw)
To: Prarit Bhargava
Cc: linux-pm, Srinivas Pandruvada, Len Brown, Rafael J. Wysocki
On 08-12-15, 13:44, Prarit Bhargava wrote:
> 785ee27 ("cpufreq: intel_pstate: Fix limits->max_perf rounding error")
> hardcodes the value of FRAC_BITS. This patch fixes that minor issue.
>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> ---
> drivers/cpufreq/intel_pstate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c
> index 4d07cbd..98fb882 100644
> --- a/drivers/cpufreq/intel_pstate.c
> +++ b/drivers/cpufreq/intel_pstate.c
> @@ -1123,7 +1123,7 @@ static int intel_pstate_set_policy(struct cpufreq_policy *policy)
> limits->max_sysfs_pct);
> limits->max_perf_pct = max(limits->min_policy_pct,
> limits->max_perf_pct);
> - limits->max_perf = round_up(limits->max_perf, 8);
> + limits->max_perf = round_up(limits->max_perf, FRAC_BITS);
>
> /* Make sure min_perf_pct <= max_perf_pct */
> limits->min_perf_pct = min(limits->max_perf_pct, limits->min_perf_pct);
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cpufreq, intel_pstate, minor cleanup for FRAC_BITS
2015-12-08 18:44 [PATCH] cpufreq, intel_pstate, minor cleanup for FRAC_BITS Prarit Bhargava
2015-12-09 1:53 ` Viresh Kumar
@ 2015-12-12 2:27 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2015-12-12 2:27 UTC (permalink / raw)
To: Prarit Bhargava; +Cc: linux-pm, Srinivas Pandruvada, Len Brown, Viresh Kumar
On Tuesday, December 08, 2015 01:44:59 PM Prarit Bhargava wrote:
> 785ee27 ("cpufreq: intel_pstate: Fix limits->max_perf rounding error")
> hardcodes the value of FRAC_BITS. This patch fixes that minor issue.
>
> Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> Cc: Len Brown <lenb@kernel.org>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Applied, thanks!
Rafael
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-12-12 1:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-08 18:44 [PATCH] cpufreq, intel_pstate, minor cleanup for FRAC_BITS Prarit Bhargava
2015-12-09 1:53 ` Viresh Kumar
2015-12-12 2:27 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox