From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Pavel Machek <pavel@ucw.cz>, Len Brown <len.brown@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / clk: Remove error message on out-of-memory condition
Date: Fri, 31 May 2019 11:29:16 +0200 [thread overview]
Message-ID: <4033832.t2mNCoI3x2@kreacher> (raw)
In-Reply-To: <20190527122751.6430-1-geert+renesas@glider.be>
On Monday, May 27, 2019 2:27:51 PM CEST Geert Uytterhoeven wrote:
> There is no need to print an error message if kstrdup() fails, as the
> memory allocation core already takes care of that.
>
> Note that commit 59d84ca8c46a93ad ("PM / OPP / clk: Remove unnecessary
> OOM message") already removed similar error messages, but this one was
> forgotten.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/base/power/clock_ops.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c
> index 59d19dd649289287..1cf86fcaeff8faac 100644
> --- a/drivers/base/power/clock_ops.c
> +++ b/drivers/base/power/clock_ops.c
> @@ -92,8 +92,6 @@ static int __pm_clk_add(struct device *dev, const char *con_id,
> if (con_id) {
> ce->con_id = kstrdup(con_id, GFP_KERNEL);
> if (!ce->con_id) {
> - dev_err(dev,
> - "Not enough memory for clock connection ID.\n");
> kfree(ce);
> return -ENOMEM;
> }
>
Applied, thanks!
prev parent reply other threads:[~2019-05-31 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 12:27 [PATCH] PM / clk: Remove error message on out-of-memory condition Geert Uytterhoeven
2019-05-31 9:29 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4033832.t2mNCoI3x2@kreacher \
--to=rjw@rjwysocki.net \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox