Linux Power Management development
 help / color / mirror / Atom feed
From: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: rafael@kernel.org, viresh.kumar@linaro.org, mingo@redhat.com,
	peterz@infradead.org, linux-arm-msm@vger.kernel.org,
	juri.lelli@redhat.com, vincent.guittot@linaro.org,
	dietmar.eggemann@arm.com, linux-kernel@vger.kernel.org,
	rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
	vschneid@redhat.com, kprateek.nayak@amd.com,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH 1/2] cpufreq: allow cpuinfo max to decrease when boost is disabled
Date: Thu, 6 Aug 2026 15:41:45 +0530	[thread overview]
Message-ID: <42d9370b-aa10-4382-b6a2-bc441fd2335a@oss.qualcomm.com> (raw)
In-Reply-To: <35it74zycctxhpnbsuvp6a6aazrjavarhq43fqgruafjv7xkt2@recuceutrqrn>


On 8/6/2026 2:58 PM, Dmitry Baryshkov wrote:
> On Thu, Aug 06, 2026 at 10:12:29AM +0530, Sibi Sankar wrote:
>> From: Ananthu C V <ananthu.cv@oss.qualcomm.com>
>>
>> Commit 538b0188da46 ("cpufreq: ACPI: Set cpuinfo.max_freq directly
>> if max boost is known") guarded cpuinfo max updates to only allow
>> increases, preserving values set directly by drivers above the freq
>> table maximum. This prevents cpuinfo max from decreasing on boost
>> disable, leaving policy max pinned at the boost ceiling.
> Why is this bad?

Copy pasting logs shared from the cover letter:

# cd /sys/devices/system/cpu/cpufreq/
# ls
boost  policy0  policy12  policy6
# cat boost
0
# cat policy6/scaling_max_freq
4454400
# echo 1 > boost
# cat policy6/scaling_max_freq
4723200
# echo 0 > boost
# cat policy6/scaling_max_freq
4723200

Currently disabling boost after enabling it is a NOP,
scaling_max freq in this case would be pinned to turbo.
It will be reachable through various govenors. Also policy
specific boost flag is meaningless unless we have means to
reduce the scaling_max_freq.

>
>> Remove the guard so cpuinfo max is always derived from the frequency
>> table scan. Drivers that correctly flag boost entries are unaffected
>> since the scan already excludes them when boost is off.
>>
>> Fixes: 538b0188da46 ("cpufreq: ACPI: Set cpuinfo.max_freq directly if max boost is known")
>> Signed-off-by: Ananthu C V <ananthu.cv@oss.qualcomm.com>
>> Signed-off-by: Sibi Sankar <sibi.sankar@oss.qualcomm.com>
>> ---
>>   drivers/cpufreq/freq_table.c | 7 +------
>>   1 file changed, 1 insertion(+), 6 deletions(-)
>>

  reply	other threads:[~2026-08-06 10:11 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06  4:42 [PATCH 0/2] sched/cpufreq: Fix schedutil's boost frequency handling Sibi Sankar
2026-08-06  4:42 ` [PATCH 1/2] cpufreq: allow cpuinfo max to decrease when boost is disabled Sibi Sankar
2026-08-06  9:28   ` Dmitry Baryshkov
2026-08-06 10:11     ` Sibi Sankar [this message]
2026-08-06 12:12       ` Dmitry Baryshkov
2026-08-07 12:12         ` Sibi Sankar
2026-08-06 11:22   ` Zhongqiu Han
2026-08-07 14:23     ` Sibi Sankar
2026-08-06  4:42 ` [PATCH 2/2] sched/cpufreq: Update schedutil's DVFS request to reach the boost frequencies Sibi Sankar
2026-08-06  9:02   ` Christian Loehle
2026-08-06 15:13     ` Vincent Guittot
2026-08-07 14:41       ` Sibi Sankar
2026-08-06 15:09   ` Vincent Guittot
2026-08-07 14:32     ` Sibi Sankar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=42d9370b-aa10-4382-b6a2-bc441fd2335a@oss.qualcomm.com \
    --to=sibi.sankar@oss.qualcomm.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=dmitry.baryshkov@oss.qualcomm.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rafael@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox