* [PATCH] cpufreq: maple: Remove redundant code from maple_cpufreq_init()
@ 2019-04-08 10:17 Viresh Kumar
2019-04-08 10:17 ` Viresh Kumar
2019-04-08 10:41 ` Rafael J. Wysocki
0 siblings, 2 replies; 6+ messages in thread
From: Viresh Kumar @ 2019-04-08 10:17 UTC (permalink / raw)
To: Rafael Wysocki; +Cc: Viresh Kumar, linux-pm, Vincent Guittot, linux-kernel
The success path and error path both look the same, don't duplicate the
code.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/maple-cpufreq.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/cpufreq/maple-cpufreq.c b/drivers/cpufreq/maple-cpufreq.c
index a05f1342ec02..a94355723ef8 100644
--- a/drivers/cpufreq/maple-cpufreq.c
+++ b/drivers/cpufreq/maple-cpufreq.c
@@ -231,10 +231,6 @@ static int __init maple_cpufreq_init(void)
rc = cpufreq_register_driver(&maple_cpufreq_driver);
- of_node_put(cpunode);
-
- return rc;
-
bail_noprops:
of_node_put(cpunode);
--
2.21.0.rc0.269.g1a574e7a288b
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] cpufreq: maple: Remove redundant code from maple_cpufreq_init()
2019-04-08 10:17 [PATCH] cpufreq: maple: Remove redundant code from maple_cpufreq_init() Viresh Kumar
@ 2019-04-08 10:17 ` Viresh Kumar
2019-04-08 10:41 ` Rafael J. Wysocki
1 sibling, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2019-04-08 10:17 UTC (permalink / raw)
To: Rafael Wysocki; +Cc: Viresh Kumar, linux-pm, Vincent Guittot, linux-kernel
The success path and error path both look the same, don't duplicate the
code.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/cpufreq/maple-cpufreq.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/cpufreq/maple-cpufreq.c b/drivers/cpufreq/maple-cpufreq.c
index a05f1342ec02..a94355723ef8 100644
--- a/drivers/cpufreq/maple-cpufreq.c
+++ b/drivers/cpufreq/maple-cpufreq.c
@@ -231,10 +231,6 @@ static int __init maple_cpufreq_init(void)
rc = cpufreq_register_driver(&maple_cpufreq_driver);
- of_node_put(cpunode);
-
- return rc;
-
bail_noprops:
of_node_put(cpunode);
--
2.21.0.rc0.269.g1a574e7a288b
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] cpufreq: maple: Remove redundant code from maple_cpufreq_init()
2019-04-08 10:17 [PATCH] cpufreq: maple: Remove redundant code from maple_cpufreq_init() Viresh Kumar
2019-04-08 10:17 ` Viresh Kumar
@ 2019-04-08 10:41 ` Rafael J. Wysocki
2019-04-08 10:41 ` Rafael J. Wysocki
2019-04-08 10:45 ` Viresh Kumar
1 sibling, 2 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2019-04-08 10:41 UTC (permalink / raw)
To: Viresh Kumar; +Cc: linux-pm, Vincent Guittot, linux-kernel
On Monday, April 8, 2019 12:17:06 PM CEST Viresh Kumar wrote:
> The success path and error path both look the same, don't duplicate the
> code.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/maple-cpufreq.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/maple-cpufreq.c
> b/drivers/cpufreq/maple-cpufreq.c index a05f1342ec02..a94355723ef8 100644
> --- a/drivers/cpufreq/maple-cpufreq.c
> +++ b/drivers/cpufreq/maple-cpufreq.c
> @@ -231,10 +231,6 @@ static int __init maple_cpufreq_init(void)
>
> rc = cpufreq_register_driver(&maple_cpufreq_driver);
>
> - of_node_put(cpunode);
> -
> - return rc;
> -
> bail_noprops:
> of_node_put(cpunode);
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
I'm assuming this to land in your tree.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpufreq: maple: Remove redundant code from maple_cpufreq_init()
2019-04-08 10:41 ` Rafael J. Wysocki
@ 2019-04-08 10:41 ` Rafael J. Wysocki
2019-04-08 10:45 ` Viresh Kumar
1 sibling, 0 replies; 6+ messages in thread
From: Rafael J. Wysocki @ 2019-04-08 10:41 UTC (permalink / raw)
To: Viresh Kumar; +Cc: linux-pm, Vincent Guittot, linux-kernel
On Monday, April 8, 2019 12:17:06 PM CEST Viresh Kumar wrote:
> The success path and error path both look the same, don't duplicate the
> code.
>
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> ---
> drivers/cpufreq/maple-cpufreq.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/cpufreq/maple-cpufreq.c
> b/drivers/cpufreq/maple-cpufreq.c index a05f1342ec02..a94355723ef8 100644
> --- a/drivers/cpufreq/maple-cpufreq.c
> +++ b/drivers/cpufreq/maple-cpufreq.c
> @@ -231,10 +231,6 @@ static int __init maple_cpufreq_init(void)
>
> rc = cpufreq_register_driver(&maple_cpufreq_driver);
>
> - of_node_put(cpunode);
> -
> - return rc;
> -
> bail_noprops:
> of_node_put(cpunode);
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
I'm assuming this to land in your tree.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpufreq: maple: Remove redundant code from maple_cpufreq_init()
2019-04-08 10:41 ` Rafael J. Wysocki
2019-04-08 10:41 ` Rafael J. Wysocki
@ 2019-04-08 10:45 ` Viresh Kumar
2019-04-08 10:45 ` Viresh Kumar
1 sibling, 1 reply; 6+ messages in thread
From: Viresh Kumar @ 2019-04-08 10:45 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-pm, Vincent Guittot, linux-kernel
On 08-04-19, 12:41, Rafael J. Wysocki wrote:
> On Monday, April 8, 2019 12:17:06 PM CEST Viresh Kumar wrote:
> > The success path and error path both look the same, don't duplicate the
> > code.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > drivers/cpufreq/maple-cpufreq.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/cpufreq/maple-cpufreq.c
> > b/drivers/cpufreq/maple-cpufreq.c index a05f1342ec02..a94355723ef8 100644
> > --- a/drivers/cpufreq/maple-cpufreq.c
> > +++ b/drivers/cpufreq/maple-cpufreq.c
> > @@ -231,10 +231,6 @@ static int __init maple_cpufreq_init(void)
> >
> > rc = cpufreq_register_driver(&maple_cpufreq_driver);
> >
> > - of_node_put(cpunode);
> > -
> > - return rc;
> > -
> > bail_noprops:
> > of_node_put(cpunode);
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> I'm assuming this to land in your tree.
Yes, applied now. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] cpufreq: maple: Remove redundant code from maple_cpufreq_init()
2019-04-08 10:45 ` Viresh Kumar
@ 2019-04-08 10:45 ` Viresh Kumar
0 siblings, 0 replies; 6+ messages in thread
From: Viresh Kumar @ 2019-04-08 10:45 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: linux-pm, Vincent Guittot, linux-kernel
On 08-04-19, 12:41, Rafael J. Wysocki wrote:
> On Monday, April 8, 2019 12:17:06 PM CEST Viresh Kumar wrote:
> > The success path and error path both look the same, don't duplicate the
> > code.
> >
> > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
> > ---
> > drivers/cpufreq/maple-cpufreq.c | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/cpufreq/maple-cpufreq.c
> > b/drivers/cpufreq/maple-cpufreq.c index a05f1342ec02..a94355723ef8 100644
> > --- a/drivers/cpufreq/maple-cpufreq.c
> > +++ b/drivers/cpufreq/maple-cpufreq.c
> > @@ -231,10 +231,6 @@ static int __init maple_cpufreq_init(void)
> >
> > rc = cpufreq_register_driver(&maple_cpufreq_driver);
> >
> > - of_node_put(cpunode);
> > -
> > - return rc;
> > -
> > bail_noprops:
> > of_node_put(cpunode);
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> I'm assuming this to land in your tree.
Yes, applied now. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-08 10:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-08 10:17 [PATCH] cpufreq: maple: Remove redundant code from maple_cpufreq_init() Viresh Kumar
2019-04-08 10:17 ` Viresh Kumar
2019-04-08 10:41 ` Rafael J. Wysocki
2019-04-08 10:41 ` Rafael J. Wysocki
2019-04-08 10:45 ` Viresh Kumar
2019-04-08 10:45 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox