From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "Sebastian Reichel" <sre@kernel.org>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Benson Leung" <bleung@chromium.org>,
"Tzung-Bi Shih" <tzungbi@kernel.org>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
"Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Zhang Rui" <rui.zhang@intel.com>,
"Lukasz Luba" <lukasz.luba@arm.com>,
linux-pm@vger.kernel.org, "Søren Andersen" <san@skov.dk>,
"Guenter Roeck" <groeck@chromium.org>,
"Ahmad Fatoum" <a.fatoum@pengutronix.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
chrome-platform@lists.linux.dev
Subject: Re: [PATCH v7 7/7] Documentation: Add sysfs documentation for PSCRR reboot reason tracking
Date: Tue, 18 Mar 2025 13:27:50 +0200 [thread overview]
Message-ID: <50205854-b8fc-4022-8a07-ec36d8203f87@gmail.com> (raw)
In-Reply-To: <Z9lYA9yUx62wNISq@pengutronix.de>
On 18/03/2025 13:24, Oleksij Rempel wrote:
> On Tue, Mar 18, 2025 at 01:17:38PM +0200, Matti Vaittinen wrote:
>> On 18/03/2025 11:47, Oleksij Rempel wrote:
>> A side note which you can consider if you feel like:
>> This, as far as I understand, will also make the ABI out of this. So,
>> perhaps there should be comments in enum psc_reason and the defines in
>> Defined in 'include/linux/reboot.h' that they are part of an ABI, and must
>> not be changed? I suppose user-space tools may get unhappy if these values
>> change between the kernel versions.
>
> Yes, there is already: "Importantly, the order of these values **must
> remain stable**, as bootloaders, user-space tools, or post-mortem
> investigation utilities may rely on their numerical representation for
> consistent behavior." :)
Just noticed this. My bad, I did reviewing in wrong order :)
>>
>> Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>
>>
>> Yours,
>> -- Matti
>>
>>
>
prev parent reply other threads:[~2025-03-18 11:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-18 9:47 [PATCH v7 0/7] Introduction of PSCR Framework and Related Components Oleksij Rempel
2025-03-18 9:47 ` [PATCH v7 1/7] power: Extend power_on_reason.h for upcoming PSCRR framework Oleksij Rempel
2025-03-18 9:47 ` [PATCH v7 2/7] reboot: hw_protection_trigger: use standardized numeric shutdown/reboot reasons instead of strings Oleksij Rempel
2025-03-18 11:26 ` Matti Vaittinen
2025-03-18 12:20 ` Mark Brown
2025-03-18 9:47 ` [PATCH v7 3/7] power: reset: Introduce PSCR Recording Framework for Non-Volatile Storage Oleksij Rempel
2025-03-18 11:01 ` Matti Vaittinen
2025-03-18 13:19 ` Oleksij Rempel
2025-03-18 13:37 ` Matti Vaittinen
2025-03-18 9:47 ` [PATCH v7 4/7] nvmem: provide consumer access to cell size metrics Oleksij Rempel
2025-03-18 9:47 ` [PATCH v7 5/7] nvmem: add support for device and sysfs-based cell lookups Oleksij Rempel
2025-03-18 9:47 ` [PATCH v7 6/7] power: reset: add PSCR NVMEM Driver for Recording Power State Change Reasons Oleksij Rempel
2025-03-18 9:47 ` [PATCH v7 7/7] Documentation: Add sysfs documentation for PSCRR reboot reason tracking Oleksij Rempel
2025-03-18 11:17 ` Matti Vaittinen
2025-03-18 11:24 ` Oleksij Rempel
2025-03-18 11:27 ` Matti Vaittinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50205854-b8fc-4022-8a07-ec36d8203f87@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=a.fatoum@pengutronix.de \
--cc=akpm@linux-foundation.org \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=daniel.lezcano@linaro.org \
--cc=groeck@chromium.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=o.rempel@pengutronix.de \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=san@skov.dk \
--cc=sre@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox