Re: [PATCH 1/1] cpuidle: big_little: Fix build error

[Daniel Lezcano <daniel.lezcano@linaro.org>]

On 07/28/2014 06:58 AM, Sachin Kamat wrote:
> big_little CPU idle driver references functions defined in MCPM driver.
> Thus make it depend on MCPM to avoid the following errors:
>
> drivers/built-in.o: In function `bl_enter_powerdown':
> drivers/cpuidle/cpuidle-big_little.c:134: undefined reference to `mcpm_cpu_powered_up'
> drivers/built-in.o: In function `bl_powerdown_finisher':
> drivers/cpuidle/cpuidle-big_little.c:104: undefined reference to `mcpm_set_entry_vector'
> drivers/cpuidle/cpuidle-big_little.c:111: undefined reference to `mcpm_cpu_suspend'
> make: *** [vmlinux] Error 1
>
> Reported-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
>   drivers/cpuidle/Kconfig.arm | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
> index 33fc0ff..38cff69 100644
> --- a/drivers/cpuidle/Kconfig.arm
> +++ b/drivers/cpuidle/Kconfig.arm
> @@ -4,6 +4,7 @@
>   config ARM_BIG_LITTLE_CPUIDLE
>   	bool "Support for ARM big.LITTLE processors"
>   	depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS
> +	depends on MCPM
>   	select ARM_CPU_SUSPEND
>   	select CPU_IDLE_MULTIPLE_DRIVERS
>   	help

Hi Sachin,

thanks for the fix. Arnd sent the same fix a couple of weeks ago.

http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/272142.html

Thanks
   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog