* [PATCH 1/1] cpuidle: big_little: Fix build error
@ 2014-07-28 4:58 Sachin Kamat
2014-07-28 6:18 ` Daniel Lezcano
0 siblings, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2014-07-28 4:58 UTC (permalink / raw)
To: linux-pm; +Cc: daniel.lezcano, rjw, afaerber, spk.linux
big_little CPU idle driver references functions defined in MCPM driver.
Thus make it depend on MCPM to avoid the following errors:
drivers/built-in.o: In function `bl_enter_powerdown':
drivers/cpuidle/cpuidle-big_little.c:134: undefined reference to `mcpm_cpu_powered_up'
drivers/built-in.o: In function `bl_powerdown_finisher':
drivers/cpuidle/cpuidle-big_little.c:104: undefined reference to `mcpm_set_entry_vector'
drivers/cpuidle/cpuidle-big_little.c:111: undefined reference to `mcpm_cpu_suspend'
make: *** [vmlinux] Error 1
Reported-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
---
drivers/cpuidle/Kconfig.arm | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
index 33fc0ff..38cff69 100644
--- a/drivers/cpuidle/Kconfig.arm
+++ b/drivers/cpuidle/Kconfig.arm
@@ -4,6 +4,7 @@
config ARM_BIG_LITTLE_CPUIDLE
bool "Support for ARM big.LITTLE processors"
depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS
+ depends on MCPM
select ARM_CPU_SUSPEND
select CPU_IDLE_MULTIPLE_DRIVERS
help
--
1.8.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] cpuidle: big_little: Fix build error
2014-07-28 4:58 [PATCH 1/1] cpuidle: big_little: Fix build error Sachin Kamat
@ 2014-07-28 6:18 ` Daniel Lezcano
2014-07-28 6:21 ` Sachin Kamat
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Lezcano @ 2014-07-28 6:18 UTC (permalink / raw)
To: Sachin Kamat, linux-pm; +Cc: rjw, afaerber, spk.linux
On 07/28/2014 06:58 AM, Sachin Kamat wrote:
> big_little CPU idle driver references functions defined in MCPM driver.
> Thus make it depend on MCPM to avoid the following errors:
>
> drivers/built-in.o: In function `bl_enter_powerdown':
> drivers/cpuidle/cpuidle-big_little.c:134: undefined reference to `mcpm_cpu_powered_up'
> drivers/built-in.o: In function `bl_powerdown_finisher':
> drivers/cpuidle/cpuidle-big_little.c:104: undefined reference to `mcpm_set_entry_vector'
> drivers/cpuidle/cpuidle-big_little.c:111: undefined reference to `mcpm_cpu_suspend'
> make: *** [vmlinux] Error 1
>
> Reported-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> ---
> drivers/cpuidle/Kconfig.arm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
> index 33fc0ff..38cff69 100644
> --- a/drivers/cpuidle/Kconfig.arm
> +++ b/drivers/cpuidle/Kconfig.arm
> @@ -4,6 +4,7 @@
> config ARM_BIG_LITTLE_CPUIDLE
> bool "Support for ARM big.LITTLE processors"
> depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS
> + depends on MCPM
> select ARM_CPU_SUSPEND
> select CPU_IDLE_MULTIPLE_DRIVERS
> help
Hi Sachin,
thanks for the fix. Arnd sent the same fix a couple of weeks ago.
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-July/272142.html
Thanks
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] cpuidle: big_little: Fix build error
2014-07-28 6:18 ` Daniel Lezcano
@ 2014-07-28 6:21 ` Sachin Kamat
2014-07-28 22:00 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Sachin Kamat @ 2014-07-28 6:21 UTC (permalink / raw)
To: Daniel Lezcano; +Cc: Linux PM list, Rafael J. Wysocki, Andreas Färber
Hi Daniel,
On Mon, Jul 28, 2014 at 11:48 AM, Daniel Lezcano
<daniel.lezcano@linaro.org> wrote:
> On 07/28/2014 06:58 AM, Sachin Kamat wrote:
>>
>> big_little CPU idle driver references functions defined in MCPM driver.
>> Thus make it depend on MCPM to avoid the following errors:
>>
>> drivers/built-in.o: In function `bl_enter_powerdown':
>> drivers/cpuidle/cpuidle-big_little.c:134: undefined reference to
>> `mcpm_cpu_powered_up'
>> drivers/built-in.o: In function `bl_powerdown_finisher':
>> drivers/cpuidle/cpuidle-big_little.c:104: undefined reference to
>> `mcpm_set_entry_vector'
>> drivers/cpuidle/cpuidle-big_little.c:111: undefined reference to
>> `mcpm_cpu_suspend'
>> make: *** [vmlinux] Error 1
>>
>> Reported-by: Andreas Färber <afaerber@suse.de>
>> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>> ---
>> drivers/cpuidle/Kconfig.arm | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
>> index 33fc0ff..38cff69 100644
>> --- a/drivers/cpuidle/Kconfig.arm
>> +++ b/drivers/cpuidle/Kconfig.arm
>> @@ -4,6 +4,7 @@
>> config ARM_BIG_LITTLE_CPUIDLE
>> bool "Support for ARM big.LITTLE processors"
>> depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS
>> + depends on MCPM
>> select ARM_CPU_SUSPEND
>> select CPU_IDLE_MULTIPLE_DRIVERS
>> help
>
>
> Hi Sachin,
>
> thanks for the fix. Arnd sent the same fix a couple of weeks ago.
Oh great. Perhaps it hasn't hit the linux-next tree yet.
--
Regards,
Sachin.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] cpuidle: big_little: Fix build error
2014-07-28 6:21 ` Sachin Kamat
@ 2014-07-28 22:00 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2014-07-28 22:00 UTC (permalink / raw)
To: Sachin Kamat; +Cc: Daniel Lezcano, Linux PM list, Andreas Färber
On Monday, July 28, 2014 11:51:09 AM Sachin Kamat wrote:
> Hi Daniel,
>
> On Mon, Jul 28, 2014 at 11:48 AM, Daniel Lezcano
> <daniel.lezcano@linaro.org> wrote:
> > On 07/28/2014 06:58 AM, Sachin Kamat wrote:
> >>
> >> big_little CPU idle driver references functions defined in MCPM driver.
> >> Thus make it depend on MCPM to avoid the following errors:
> >>
> >> drivers/built-in.o: In function `bl_enter_powerdown':
> >> drivers/cpuidle/cpuidle-big_little.c:134: undefined reference to
> >> `mcpm_cpu_powered_up'
> >> drivers/built-in.o: In function `bl_powerdown_finisher':
> >> drivers/cpuidle/cpuidle-big_little.c:104: undefined reference to
> >> `mcpm_set_entry_vector'
> >> drivers/cpuidle/cpuidle-big_little.c:111: undefined reference to
> >> `mcpm_cpu_suspend'
> >> make: *** [vmlinux] Error 1
> >>
> >> Reported-by: Andreas Färber <afaerber@suse.de>
> >> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
> >> ---
> >> drivers/cpuidle/Kconfig.arm | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/drivers/cpuidle/Kconfig.arm b/drivers/cpuidle/Kconfig.arm
> >> index 33fc0ff..38cff69 100644
> >> --- a/drivers/cpuidle/Kconfig.arm
> >> +++ b/drivers/cpuidle/Kconfig.arm
> >> @@ -4,6 +4,7 @@
> >> config ARM_BIG_LITTLE_CPUIDLE
> >> bool "Support for ARM big.LITTLE processors"
> >> depends on ARCH_VEXPRESS_TC2_PM || ARCH_EXYNOS
> >> + depends on MCPM
> >> select ARM_CPU_SUSPEND
> >> select CPU_IDLE_MULTIPLE_DRIVERS
> >> help
> >
> >
> > Hi Sachin,
> >
> > thanks for the fix. Arnd sent the same fix a couple of weeks ago.
>
> Oh great. Perhaps it hasn't hit the linux-next tree yet.
No, it hasn't and I can't find it in the linux-pm archives.
I'll queue up your patch, thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-28 21:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-28 4:58 [PATCH 1/1] cpuidle: big_little: Fix build error Sachin Kamat
2014-07-28 6:18 ` Daniel Lezcano
2014-07-28 6:21 ` Sachin Kamat
2014-07-28 22:00 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox