* [PATCH 05/22] PM / AVS: SmartReflex: %pF is only for function pointers
[not found] <1426130037-17956-1-git-send-email-scottwood@freescale.com>
@ 2015-03-12 3:13 ` Scott Wood
2015-03-12 18:09 ` Kevin Hilman
0 siblings, 1 reply; 4+ messages in thread
From: Scott Wood @ 2015-03-12 3:13 UTC (permalink / raw)
To: trivial, linux-kernel; +Cc: Scott Wood, linux-pm, Kevin Hilman, Nishanth Menon
Use %pS for actual addresses, otherwise you'll get bad output
on arches like ppc64 where %pF expects a function descriptor.
Signed-off-by: Scott Wood <scottwood@freescale.com>
Cc: linux-pm@vger.kernel.org
Cc: Kevin Hilman <khilman@kernel.org>
Cc: Nishanth Menon <nm@ti.com>
---
drivers/power/avs/smartreflex.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/power/avs/smartreflex.c b/drivers/power/avs/smartreflex.c
index db9973b..76d6a12 100644
--- a/drivers/power/avs/smartreflex.c
+++ b/drivers/power/avs/smartreflex.c
@@ -356,7 +356,7 @@ int sr_configure_errgen(struct omap_sr *sr)
u8 senp_shift, senn_shift;
if (!sr) {
- pr_warn("%s: NULL omap_sr from %pF\n", __func__,
+ pr_warn("%s: NULL omap_sr from %pS\n", __func__,
(void *)_RET_IP_);
return -EINVAL;
}
@@ -423,7 +423,7 @@ int sr_disable_errgen(struct omap_sr *sr)
u32 vpboundint_en, vpboundint_st;
if (!sr) {
- pr_warn("%s: NULL omap_sr from %pF\n", __func__,
+ pr_warn("%s: NULL omap_sr from %pS\n", __func__,
(void *)_RET_IP_);
return -EINVAL;
}
@@ -478,7 +478,7 @@ int sr_configure_minmax(struct omap_sr *sr)
u8 senp_shift, senn_shift;
if (!sr) {
- pr_warn("%s: NULL omap_sr from %pF\n", __func__,
+ pr_warn("%s: NULL omap_sr from %pS\n", __func__,
(void *)_RET_IP_);
return -EINVAL;
}
@@ -563,7 +563,7 @@ int sr_enable(struct omap_sr *sr, unsigned long volt)
int ret;
if (!sr) {
- pr_warn("%s: NULL omap_sr from %pF\n", __func__,
+ pr_warn("%s: NULL omap_sr from %pS\n", __func__,
(void *)_RET_IP_);
return -EINVAL;
}
@@ -615,7 +615,7 @@ int sr_enable(struct omap_sr *sr, unsigned long volt)
void sr_disable(struct omap_sr *sr)
{
if (!sr) {
- pr_warn("%s: NULL omap_sr from %pF\n", __func__,
+ pr_warn("%s: NULL omap_sr from %pS\n", __func__,
(void *)_RET_IP_);
return;
}
--
2.1.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 05/22] PM / AVS: SmartReflex: %pF is only for function pointers
2015-03-12 3:13 ` [PATCH 05/22] PM / AVS: SmartReflex: %pF is only for function pointers Scott Wood
@ 2015-03-12 18:09 ` Kevin Hilman
2015-03-12 18:14 ` Nishanth Menon
0 siblings, 1 reply; 4+ messages in thread
From: Kevin Hilman @ 2015-03-12 18:09 UTC (permalink / raw)
To: Scott Wood; +Cc: trivial, linux-kernel, linux-pm, Nishanth Menon
Scott Wood <scottwood@freescale.com> writes:
> Use %pS for actual addresses, otherwise you'll get bad output
> on arches like ppc64 where %pF expects a function descriptor.
>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Cc: linux-pm@vger.kernel.org
> Cc: Kevin Hilman <khilman@kernel.org>
> Cc: Nishanth Menon <nm@ti.com>
Acked-by: Kevin Hilman <khilman@linaro.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 05/22] PM / AVS: SmartReflex: %pF is only for function pointers
2015-03-12 18:09 ` Kevin Hilman
@ 2015-03-12 18:14 ` Nishanth Menon
2015-03-12 18:16 ` Jiri Kosina
0 siblings, 1 reply; 4+ messages in thread
From: Nishanth Menon @ 2015-03-12 18:14 UTC (permalink / raw)
To: Kevin Hilman, Scott Wood; +Cc: trivial, linux-kernel, linux-pm
On 03/12/2015 01:09 PM, Kevin Hilman wrote:
> Scott Wood <scottwood@freescale.com> writes:
>
>> Use %pS for actual addresses, otherwise you'll get bad output
>> on arches like ppc64 where %pF expects a function descriptor.
>>
>> Signed-off-by: Scott Wood <scottwood@freescale.com>
>> Cc: linux-pm@vger.kernel.org
>> Cc: Kevin Hilman <khilman@kernel.org>
>> Cc: Nishanth Menon <nm@ti.com>
>
> Acked-by: Kevin Hilman <khilman@linaro.org>
>
Acked-by: Nishanth Menon <nm@ti.com>
I suppose this goes via Jiri Kosina's trivial tree?
--
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 05/22] PM / AVS: SmartReflex: %pF is only for function pointers
2015-03-12 18:14 ` Nishanth Menon
@ 2015-03-12 18:16 ` Jiri Kosina
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2015-03-12 18:16 UTC (permalink / raw)
To: Nishanth Menon; +Cc: Kevin Hilman, Scott Wood, linux-kernel, linux-pm
On Thu, 12 Mar 2015, Nishanth Menon wrote:
> > Scott Wood <scottwood@freescale.com> writes:
> >
> >> Use %pS for actual addresses, otherwise you'll get bad output
> >> on arches like ppc64 where %pF expects a function descriptor.
> >>
> >> Signed-off-by: Scott Wood <scottwood@freescale.com>
> >> Cc: linux-pm@vger.kernel.org
> >> Cc: Kevin Hilman <khilman@kernel.org>
> >> Cc: Nishanth Menon <nm@ti.com>
> >
> > Acked-by: Kevin Hilman <khilman@linaro.org>
> >
> Acked-by: Nishanth Menon <nm@ti.com>
>
> I suppose this goes via Jiri Kosina's trivial tree?
Thanks. I am putting this on hold for a couple days to see who applied to
which tree, gather acks, and merge what's outstanding through trivial
tree.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-03-12 18:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1426130037-17956-1-git-send-email-scottwood@freescale.com>
2015-03-12 3:13 ` [PATCH 05/22] PM / AVS: SmartReflex: %pF is only for function pointers Scott Wood
2015-03-12 18:09 ` Kevin Hilman
2015-03-12 18:14 ` Nishanth Menon
2015-03-12 18:16 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox