Re: regression, 5.19.0-rc1 not powering off when hibernated

Re: regression, 5.19.0-rc1 not powering off when hibernated

[Thorsten Leemhuis]

Hi, this is your Linux kernel regression tracker.

CCing the regression mailing list, as it should be in the loop for all
regressions, as explained here:
https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html
Also CCing the hibernation maintainers and Linux-pm.

On 09.06.22 01:55, Ken Moffat wrote:
> Up to 5.18.0 hibernation has worked ok on my ryzen 5 3400G : screen
> blanks, disk activity for the write to swap, screen briefly has a
> trashed display, machine powers off.  When powering up from
> hibernation, after the saved files are loaded X starts with a
> briefly trashed display before my desktop reappears.
> 
> But with 5.19.0-rc1 the screen is blank throughtout the hibernation,
> and briefly when restoring (no complaint about that), but when
> hibernating it no longer powers off and I have to hold the on/off
> switch to power off.
> 
> Is this a known problem ?

Thanks for the report. Maybe the hibernation maintainers might know, but
often issues like this are caused by other things like drivers. If they
don#t have a idea, you likely need to do a bisection to get down to the
change that introduced this regressions.

Anyway: To be sure below issue doesn't fall through the cracks
unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking
bot:

#regzbot ^introduced v5.18..v5.19-rc1
#regzbot title hibernate: Not powering off when hibernated
#regzbot ignore-activity

This isn't a regression? This issue or a fix for it are already
discussed somewhere else? It was fixed already? You want to clarify when
the regression started to happen? Or point out I got the title or
something else totally wrong? Then just reply -- ideally with also
telling regzbot about it, as explained here:
https://linux-regtracking.leemhuis.info/tracked-regression/

Reminder for developers: When fixing the issue, add 'Link:' tags
pointing to the report (the mail this one replied to), as the kernel's
documentation call for; above page explains why this is important for
tracked regressions.

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

Re: regression, 5.19.0-rc1 not powering off when hibernated

[Ken Moffat]

On Sat, Jun 11, 2022 at 03:53:44PM +0200, Thorsten Leemhuis wrote:
> Hi, this is your Linux kernel regression tracker.
> 
> CCing the regression mailing list, as it should be in the loop for all
> regressions, as explained here:
> https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html
> Also CCing the hibernation maintainers and Linux-pm.
> 
> On 09.06.22 01:55, Ken Moffat wrote:
> > Up to 5.18.0 hibernation has worked ok on my ryzen 5 3400G : screen
> > blanks, disk activity for the write to swap, screen briefly has a
> > trashed display, machine powers off.  When powering up from
> > hibernation, after the saved files are loaded X starts with a
> > briefly trashed display before my desktop reappears.
> > 
> > But with 5.19.0-rc1 the screen is blank throughtout the hibernation,
> > and briefly when restoring (no complaint about that), but when
> > hibernating it no longer powers off and I have to hold the on/off
> > switch to power off.
> > 
> > Is this a known problem ?
> 
> Thanks for the report. Maybe the hibernation maintainers might know, but
> often issues like this are caused by other things like drivers. If they
> don#t have a idea, you likely need to do a bisection to get down to the
> change that introduced this regressions.
> 
> Anyway: To be sure below issue doesn't fall through the cracks
> unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking
> bot:
> 
> #regzbot ^introduced v5.18..v5.19-rc1
> #regzbot title hibernate: Not powering off when hibernated
> #regzbot ignore-activity
> 
> This isn't a regression? This issue or a fix for it are already
> discussed somewhere else? It was fixed already? You want to clarify when
> the regression started to happen? Or point out I got the title or
> something else totally wrong? Then just reply -- ideally with also
> telling regzbot about it, as explained here:
> https://linux-regtracking.leemhuis.info/tracked-regression/
> 
> Reminder for developers: When fixing the issue, add 'Link:' tags
> pointing to the report (the mail this one replied to), as the kernel's
> documentation call for; above page explains why this is important for
> tracked regressions.
> 
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> 
> P.S.: As the Linux kernel's regression tracker I deal with a lot of
> reports and sometimes miss something important when writing mails like
> this. If that's the case here, don't hesitate to tell me in a public
> reply, it's in everyone's interest to set the public record straight.

Thanks.  I've started to bisect, but I've got a lot else on and it
might be a few days before I get a result.  All I know so far is
that whatever got rid of the garbled screens was fine, and the
problem seems to have arisen in the last 800+ commits for 5.19-rc1.

ĸen
-- 
      Remembering The People's Republic of Treacle Mine Road.
        Truth!  Justice!  Freedom!  Reasonably priced Love!
                 And a Hard-boiled Egg!

Re: regression, 5.19.0-rc1 not powering off when hibernated

[Ken Moffat]

On Sat, Jun 11, 2022 at 06:23:32PM +0100, Ken Moffat wrote:
> On Sat, Jun 11, 2022 at 03:53:44PM +0200, Thorsten Leemhuis wrote:
> > Hi, this is your Linux kernel regression tracker.
> > 
> > CCing the regression mailing list, as it should be in the loop for all
> > regressions, as explained here:
> > https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html
> > Also CCing the hibernation maintainers and Linux-pm.
> > 
> > On 09.06.22 01:55, Ken Moffat wrote:
> > > Up to 5.18.0 hibernation has worked ok on my ryzen 5 3400G : screen
> > > blanks, disk activity for the write to swap, screen briefly has a
> > > trashed display, machine powers off.  When powering up from
> > > hibernation, after the saved files are loaded X starts with a
> > > briefly trashed display before my desktop reappears.
> > > 
> > > But with 5.19.0-rc1 the screen is blank throughtout the hibernation,
> > > and briefly when restoring (no complaint about that), but when
> > > hibernating it no longer powers off and I have to hold the on/off
> > > switch to power off.
> > > 
> > > Is this a known problem ?
> > 
> > Thanks for the report. Maybe the hibernation maintainers might know, but
> > often issues like this are caused by other things like drivers. If they
> > don#t have a idea, you likely need to do a bisection to get down to the
> > change that introduced this regressions.
> > 
> > Anyway: To be sure below issue doesn't fall through the cracks
> > unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking
> > bot:
> > 
> > #regzbot ^introduced v5.18..v5.19-rc1
> > #regzbot title hibernate: Not powering off when hibernated
> > #regzbot ignore-activity
> > 
> > This isn't a regression? This issue or a fix for it are already
> > discussed somewhere else? It was fixed already? You want to clarify when
> > the regression started to happen? Or point out I got the title or
> > something else totally wrong? Then just reply -- ideally with also
> > telling regzbot about it, as explained here:
> > https://linux-regtracking.leemhuis.info/tracked-regression/
> > 
> > Reminder for developers: When fixing the issue, add 'Link:' tags
> > pointing to the report (the mail this one replied to), as the kernel's
> > documentation call for; above page explains why this is important for
> > tracked regressions.
> > 
> > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > 
> > P.S.: As the Linux kernel's regression tracker I deal with a lot of
> > reports and sometimes miss something important when writing mails like
> > this. If that's the case here, don't hesitate to tell me in a public
> > reply, it's in everyone's interest to set the public record straight.
> 
> Thanks.  I've started to bisect, but I've got a lot else on and it
> might be a few days before I get a result.  All I know so far is
> that whatever got rid of the garbled screens was fine, and the
> problem seems to have arisen in the last 800+ commits for 5.19-rc1.
> 
I think I must have gone wrong somewhere in that bisection, it took
me through a load of habanalabs commits which were all good, and
blamed the merge which for this which *was* definitely bad, but seems
to have nothing related to the box not powering off on hibernation::

[6f9b5ed8caddfbc94af8307c557ed57a8ec5c65c] Merge tag 'char-misc-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc

Not Cc'ing Greg at this point, I really don't believe that result.

Starting over.

ĸen
 ----

Details from this run, with resulting kernel versions -

git bisect start
git bisect good v5.18
git bisect bad  v5.19-rc1

Bisecting: 7030 revisions left to test after this (roughly 13 steps)
[2518f226c60d8e04d18ba4295500a5b0b8ac7659] Merge tag 'drm-next-2022-05-25' of git://anongit.freedesktop.org/drm/drm

 5.18.0-06942-g2518f226c60d

git bisct good

Bisecting: 3527 revisions left to test after this (roughly 12 steps)
[aef1ff15927421a55312b4b9b2881a89a344bd80] Merge tag 'jfs-5.19' of https://github.com/kleikamp/linux-shaggy

 5.18.0-10445-gaef1ff159274

git bisect good

Bisecting: 834 revisions left to test after this (roughly 10 steps)
[54c2cc79194c961a213c1d375fe3aa4165664cc4] Merge tag 'usb-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb

 5.18.0-13138-g54c2cc79194c

git bisect good

Bisecting: 428 revisions left to test after this (roughly 9 steps)
[7036440eab3e2d47a775d4616909f8235488d714] ARM: omap1: enable multiplatform

 5.18.0-13544-g7036440eab3e

git bisect bad

Bisecting: 203 revisions left to test after this (roughly 8 steps)
[46ee6bcac9838b7f74ff91f9cf38511c901ea9c5] Merge tag 'mhi-for-v5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/mani/mhi into char-work-next

 5.18.0-rc5-00202-g46ee6bcac983

git bisect good

Bisecting: 99 revisions left to test after this (roughly 7 steps)
[dc6a7effb48e7267c9f1314e3aa8cfe539bd6096] Merge tag 'lkdtm-next' of https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux into char-misc-next

 5.18.0-rc5-00306-gdc6a7effb48e

git bisect good

Bisecting: 49 revisions left to test after this (roughly 6 steps)
[b19768d81a6bd1591872952075ff9d960bd4e8d8] habanalabs/gaudi: increase submission resources

 5.18.0-rc5-00356-gb19768d81a6b

git bisect good

Bisecting: 24 revisions left to test after this (roughly 5 steps)
[ab4ea5872842766b0155b2517db61a4ae99d98e0] habanalabs: use for_each_sgtable_dma_sg for dma sgt

 5.18.0-rc5-00381-gab4ea5872842

git bisect good

Bisecting: 12 revisions left to test after this (roughly 4 steps)
[c37803388c95833c4728b089e6c94996dc457d95] habanalabs: handle race in driver fini

 5.18.0-rc5-00393-gc37803388c95

git bisect good

Bisecting: 6 revisions left to test after this (roughly 3 steps)
[83617f5a87f4ad8403bf1177708fedc98b0a1059] habanalabs: order memory manager messages

 5.18.0-rc5-00399-g83617f5a87f4

git bisect good

Bisecting: 3 revisions left to test after this (roughly 2 steps)
[f873a27fd50d161111d0e52087af0f5b2111c5c4] habanalabs: fix missing handle shift during mmap

 5.18.0-rc5-00402-gf873a27fd50d

git bisect good

Bisecting: 1 revision left to test after this (roughly 1 step)
[6f9b5ed8caddfbc94af8307c557ed57a8ec5c65c] Merge tag 'char-misc-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc

  5.18.0-13542-g6f9b5ed8cadd
  bad

git bisect bad

Bisecting: 0 revisions left to test after this (roughly 0 steps)
[90de6805267f8c79cd2b1a36805071e257c39b5c] habanalabs: use separate structure info for each error collect data

 5.18.0-rc5-00403-g90de6805267f

git bisect good

 ----
-- 
      Remembering The People's Republic of Treacle Mine Road.
        Truth!  Justice!  Freedom!  Reasonably priced Love!
                 And a Hard-boiled Egg!

Re: regression, 5.19.0-rc1 not powering off when hibernated

[Ken Moffat]

On Mon, Jun 13, 2022 at 08:46:22PM +0100, Ken Moffat wrote:

Adding Dmitry because of git blame (details at end)

> On Sat, Jun 11, 2022 at 06:23:32PM +0100, Ken Moffat wrote:
> > On Sat, Jun 11, 2022 at 03:53:44PM +0200, Thorsten Leemhuis wrote:
> > > Hi, this is your Linux kernel regression tracker.
> > > 
> > > CCing the regression mailing list, as it should be in the loop for all
> > > regressions, as explained here:
> > > https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html
> > > Also CCing the hibernation maintainers and Linux-pm.
> > > 
> > > On 09.06.22 01:55, Ken Moffat wrote:
> > > > Up to 5.18.0 hibernation has worked ok on my ryzen 5 3400G : screen
> > > > blanks, disk activity for the write to swap, screen briefly has a
> > > > trashed display, machine powers off.  When powering up from
> > > > hibernation, after the saved files are loaded X starts with a
> > > > briefly trashed display before my desktop reappears.
> > > > 
> > > > But with 5.19.0-rc1 the screen is blank throughtout the hibernation,
> > > > and briefly when restoring (no complaint about that), but when
> > > > hibernating it no longer powers off and I have to hold the on/off
> > > > switch to power off.
> > > > 
> > > > Is this a known problem ?
> > > 
> > > Thanks for the report. Maybe the hibernation maintainers might know, but
> > > often issues like this are caused by other things like drivers. If they
> > > don#t have a idea, you likely need to do a bisection to get down to the
> > > change that introduced this regressions.
> > > 
> > > Anyway: To be sure below issue doesn't fall through the cracks
> > > unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking
> > > bot:
> > > 
> > > #regzbot ^introduced v5.18..v5.19-rc1
> > > #regzbot title hibernate: Not powering off when hibernated
> > > #regzbot ignore-activity
> > > 
> > > This isn't a regression? This issue or a fix for it are already
> > > discussed somewhere else? It was fixed already? You want to clarify when
> > > the regression started to happen? Or point out I got the title or
> > > something else totally wrong? Then just reply -- ideally with also
> > > telling regzbot about it, as explained here:
> > > https://linux-regtracking.leemhuis.info/tracked-regression/
> > > 
> > > Reminder for developers: When fixing the issue, add 'Link:' tags
> > > pointing to the report (the mail this one replied to), as the kernel's
> > > documentation call for; above page explains why this is important for
> > > tracked regressions.
> > > 
> > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
> > > 
> > > P.S.: As the Linux kernel's regression tracker I deal with a lot of
> > > reports and sometimes miss something important when writing mails like
> > > this. If that's the case here, don't hesitate to tell me in a public
> > > reply, it's in everyone's interest to set the public record straight.
> > 
> > Thanks.  I've started to bisect, but I've got a lot else on and it
> > might be a few days before I get a result.  All I know so far is
> > that whatever got rid of the garbled screens was fine, and the
> > problem seems to have arisen in the last 800+ commits for 5.19-rc1.
> > 
> I think I must have gone wrong somewhere in that bisection, it took
> me through a load of habanalabs commits which were all good, and
> blamed the merge which for this which *was* definitely bad, but seems
> to have nothing related to the box not powering off on hibernation::
> 
Indeed, on the second attempt I've got a much more likely commit to
blame:

98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71 is the first bad commit
commit 98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71
Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
Date:   Tue May 10 02:32:30 2022 +0300

    ACPI: power: Switch to sys-off handler API
    
    Switch to sys-off API that replaces legacy pm_power_off callbacks,
    allowing us to remove global pm_* variables and support chaining of
    all restart and power-off modes consistently.
    
    Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Unsurprisingly, with this reverted 5.19-rc2 fails to build.

ĸen

Bisect log follows:

git bisect start
# good: [4b0986a3613c92f4ec1bdc7f60ec66fea135991f] Linux 5.18
git bisect good 4b0986a3613c92f4ec1bdc7f60ec66fea135991f
# bad: [f2906aa863381afb0015a9eb7fefad885d4e5a56] Linux 5.19-rc1
git bisect bad f2906aa863381afb0015a9eb7fefad885d4e5a56
# skip: [2518f226c60d8e04d18ba4295500a5b0b8ac7659] Merge tag 'drm-next-2022-05-25' of git://anongit.freedesktop.org/drm/drm
git bisect skip 2518f226c60d8e04d18ba4295500a5b0b8ac7659
# good: [8a87419481f2d51a7bd03617d363faf5f2b0e1b3] arm64: dts: mediatek: mt8195-demo: Remove input-name property
git bisect good 8a87419481f2d51a7bd03617d363faf5f2b0e1b3
# good: [0813aeee0d02d80912c86b2b3a1ebdb4ee4476ba] Merge branch 'tcp-pass-back-data-left-in-socket-after-receive' of git://git.kernel.org/pub/scm/linux/kernel/git/kuba/linux
git bisect good 0813aeee0d02d80912c86b2b3a1ebdb4ee4476ba
# good: [d7227785e384d4422b3ca189aa5bf19f462337cc] Merge tag 'sound-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
git bisect good d7227785e384d4422b3ca189aa5bf19f462337cc
# good: [907bb57aa7b471872aab2f2e83e9713a145673f9] Merge tag 'pinctrl-v5.19-1' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl
git bisect good 907bb57aa7b471872aab2f2e83e9713a145673f9
# bad: [5ac8bdb9ad47334a9590e29daf7e4149b0a34729] Merge tag 'io_uring-5.19-2022-06-02' of git://git.kernel.dk/linux-block
git bisect bad 5ac8bdb9ad47334a9590e29daf7e4149b0a34729
# bad: [35b51afd23c98e2f055ac563aca36173a12588b9] Merge tag 'riscv-for-linus-5.19-mw0' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux
git bisect bad 35b51afd23c98e2f055ac563aca36173a12588b9
# good: [c3a9a3c5f5590e85da15d6201e415ff636fe5670] Merge tag 'trace-tools-v5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace
git bisect good c3a9a3c5f5590e85da15d6201e415ff636fe5670
# bad: [1ff7bc3ba71d398d349c49103a3da34bb4ea02d1] Merge tag 'pm-5.19-rc1-2' of git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm
git bisect bad 1ff7bc3ba71d398d349c49103a3da34bb4ea02d1
# good: [73d15ba6ba390caed47aa8885811d1cd7b4477f3] Merge tag 'mips_5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux
git bisect good 73d15ba6ba390caed47aa8885811d1cd7b4477f3
# bad: [9f9c1f6844bdacb4a011cc69e19b929997038f4f] Merge branch 'pm-sysoff'
git bisect bad 9f9c1f6844bdacb4a011cc69e19b929997038f4f
# good: [22ffff6d21ebfcd6e722af5f6954ab97c726c3c8] Merge branch 'pm-opp'
git bisect good 22ffff6d21ebfcd6e722af5f6954ab97c726c3c8
# good: [9b0d0af145195cfd79210b805448a4bcc69f0e04] sh: Use do_kernel_power_off()
git bisect good 9b0d0af145195cfd79210b805448a4bcc69f0e04
# bad: [eae813b755c46c74d65f52fa6b0b1a5476e13551] soc/tegra: pmc: Use sys-off handler API to power off Nexus 7 properly
git bisect bad eae813b755c46c74d65f52fa6b0b1a5476e13551
# good: [bf8d73b934df8aa485dc4650d6d5dfe5a640af4b] memory: emif: Use kernel_can_power_off()
git bisect good bf8d73b934df8aa485dc4650d6d5dfe5a640af4b
# bad: [02a1124defc2571b81c054ae4c5481f1ac7ccf20] regulator: pfuze100: Use devm_register_sys_off_handler()
git bisect bad 02a1124defc2571b81c054ae4c5481f1ac7ccf20
# bad: [98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71] ACPI: power: Switch to sys-off handler API
git bisect bad 98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71
# first bad commit: [98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71] ACPI: power: Switch to sys-off handler API

-- 
      Remembering The People's Republic of Treacle Mine Road.
        Truth!  Justice!  Freedom!  Reasonably priced Love!
                 And a Hard-boiled Egg!

Re: regression, 5.19.0-rc1 not powering off when hibernated

[Ken Moffat]

[-- Attachment #1: Type: text/plain, Size: 1584 bytes --]

On Wed, Jun 15, 2022 at 05:40:46PM +0100, Ken Moffat wrote:
> On Mon, Jun 13, 2022 at 08:46:22PM +0100, Ken Moffat wrote:
> 
> > > > > But with 5.19.0-rc1 the screen is blank throughtout the hibernation,
> > > > > and briefly when restoring (no complaint about that), but when
> > > > > hibernating it no longer powers off and I have to hold the on/off
> > > > > switch to power off.
> > > > > 
> > > > > Is this a known problem ?
> > > > 
[...]
> Indeed, on the second attempt I've got a much more likely commit to
> blame:
> 
> 98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71 is the first bad commit
> commit 98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71
> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> Date:   Tue May 10 02:32:30 2022 +0300
> 
>     ACPI: power: Switch to sys-off handler API
>     
>     Switch to sys-off API that replaces legacy pm_power_off callbacks,
>     allowing us to remove global pm_* variables and support chaining of
>     all restart and power-off modes consistently.
>     
>     Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>     Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> Unsurprisingly, with this reverted 5.19-rc2 fails to build.
> 
It occurs to me that maybe I'm missing something in my .config.
Since that is 117K, here is the gzipped config from the version that
git blamed (apart from not powering off, it appears to work ok).

ĸen
-- 
      Remembering The People's Republic of Treacle Mine Road.
        Truth!  Justice!  Freedom!  Reasonably priced Love!
                 And a Hard-boiled Egg!

[-- Attachment #2: config.gz --]
[-- Type: application/x-gunzip, Size: 27090 bytes --]

Re: regression, 5.19.0-rc1 not powering off when hibernated

[Dmitry Osipenko]

Hi,

On 6/15/22 22:52, Ken Moffat wrote:
> On Wed, Jun 15, 2022 at 05:40:46PM +0100, Ken Moffat wrote:
>> On Mon, Jun 13, 2022 at 08:46:22PM +0100, Ken Moffat wrote:
>>
>>>>>> But with 5.19.0-rc1 the screen is blank throughtout the hibernation,
>>>>>> and briefly when restoring (no complaint about that), but when
>>>>>> hibernating it no longer powers off and I have to hold the on/off
>>>>>> switch to power off.
>>>>>>
>>>>>> Is this a known problem ?
>>>>>
> [...]
>> Indeed, on the second attempt I've got a much more likely commit to
>> blame:
>>
>> 98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71 is the first bad commit
>> commit 98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71
>> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>> Date:   Tue May 10 02:32:30 2022 +0300
>>
>>     ACPI: power: Switch to sys-off handler API
>>     
>>     Switch to sys-off API that replaces legacy pm_power_off callbacks,
>>     allowing us to remove global pm_* variables and support chaining of
>>     all restart and power-off modes consistently.
>>     
>>     Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>     Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>
>> Unsurprisingly, with this reverted 5.19-rc2 fails to build.
>>
> It occurs to me that maybe I'm missing something in my .config.
> Since that is 117K, here is the gzipped config from the version that
> git blamed (apart from not powering off, it appears to work ok).

The patch below likely should fix the problem, please give it a try on
top of the 5.19-rc2.

diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index 20a66bf9f465..89c71fce225d 100644
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -665,7 +665,7 @@ static void power_down(void)
 		hibernation_platform_enter();
 		fallthrough;
 	case HIBERNATION_SHUTDOWN:
-		if (pm_power_off)
+		if (kernel_can_power_off())
 			kernel_power_off();
 		break;
 	}

Re: regression, 5.19.0-rc1 not powering off when hibernated

[Ken Moffat]

On Thu, Jun 16, 2022 at 05:59:10PM +0300, Dmitry Osipenko wrote:
> Hi,
> 
> On 6/15/22 22:52, Ken Moffat wrote:
> > On Wed, Jun 15, 2022 at 05:40:46PM +0100, Ken Moffat wrote:
> >> On Mon, Jun 13, 2022 at 08:46:22PM +0100, Ken Moffat wrote:
> >>
> >>>>>> But with 5.19.0-rc1 the screen is blank throughtout the hibernation,
> >>>>>> and briefly when restoring (no complaint about that), but when
> >>>>>> hibernating it no longer powers off and I have to hold the on/off
> >>>>>> switch to power off.
> >>>>>>
> >>>>>> Is this a known problem ?
> >>>>>
> > [...]
> >> Indeed, on the second attempt I've got a much more likely commit to
> >> blame:
> >>
> >> 98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71 is the first bad commit
> >> commit 98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71
> >> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >> Date:   Tue May 10 02:32:30 2022 +0300
> >>
> >>     ACPI: power: Switch to sys-off handler API
> >>     
> >>     Switch to sys-off API that replaces legacy pm_power_off callbacks,
> >>     allowing us to remove global pm_* variables and support chaining of
> >>     all restart and power-off modes consistently.
> >>     
> >>     Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
> >>     Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> >>
> >> Unsurprisingly, with this reverted 5.19-rc2 fails to build.
> >>
> > It occurs to me that maybe I'm missing something in my .config.
> > Since that is 117K, here is the gzipped config from the version that
> > git blamed (apart from not powering off, it appears to work ok).
> 
> The patch below likely should fix the problem, please give it a try on
> top of the 5.19-rc2.

Thanks, works like a charm.

Feel free to add

Reported-by: Ken Moffat <zarniwhhop@ntlworld.com>
Tested-by: Ken Moffat <zarniwhoop@ntlworld.com>

if you wish.

Cheers,

ĸen
> 
> diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
> index 20a66bf9f465..89c71fce225d 100644
> --- a/kernel/power/hibernate.c
> +++ b/kernel/power/hibernate.c
> @@ -665,7 +665,7 @@ static void power_down(void)
>  		hibernation_platform_enter();
>  		fallthrough;
>  	case HIBERNATION_SHUTDOWN:
> -		if (pm_power_off)
> +		if (kernel_can_power_off())
>  			kernel_power_off();
>  		break;
>  	}

-- 
     "Happiness isn't happiness without a violin-playing goat."
                             -- Notting Hill

Re: regression, 5.19.0-rc1 not powering off when hibernated

[Dmitry Osipenko]

On 6/16/22 20:06, Ken Moffat wrote:
> On Thu, Jun 16, 2022 at 05:59:10PM +0300, Dmitry Osipenko wrote:
>> Hi,
>>
>> On 6/15/22 22:52, Ken Moffat wrote:
>>> On Wed, Jun 15, 2022 at 05:40:46PM +0100, Ken Moffat wrote:
>>>> On Mon, Jun 13, 2022 at 08:46:22PM +0100, Ken Moffat wrote:
>>>>
>>>>>>>> But with 5.19.0-rc1 the screen is blank throughtout the hibernation,
>>>>>>>> and briefly when restoring (no complaint about that), but when
>>>>>>>> hibernating it no longer powers off and I have to hold the on/off
>>>>>>>> switch to power off.
>>>>>>>>
>>>>>>>> Is this a known problem ?
>>>>>>>
>>> [...]
>>>> Indeed, on the second attempt I've got a much more likely commit to
>>>> blame:
>>>>
>>>> 98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71 is the first bad commit
>>>> commit 98f30d0ecf79da8cf17a171fa4cf6eda7ba4dd71
>>>> Author: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>>> Date:   Tue May 10 02:32:30 2022 +0300
>>>>
>>>>     ACPI: power: Switch to sys-off handler API
>>>>     
>>>>     Switch to sys-off API that replaces legacy pm_power_off callbacks,
>>>>     allowing us to remove global pm_* variables and support chaining of
>>>>     all restart and power-off modes consistently.
>>>>     
>>>>     Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
>>>>     Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>>>>
>>>> Unsurprisingly, with this reverted 5.19-rc2 fails to build.
>>>>
>>> It occurs to me that maybe I'm missing something in my .config.
>>> Since that is 117K, here is the gzipped config from the version that
>>> git blamed (apart from not powering off, it appears to work ok).
>>
>> The patch below likely should fix the problem, please give it a try on
>> top of the 5.19-rc2.
> 
> Thanks, works like a charm.
> 
> Feel free to add
> 
> Reported-by: Ken Moffat <zarniwhhop@ntlworld.com>
> Tested-by: Ken Moffat <zarniwhoop@ntlworld.com>
> 
> if you wish.

Nice, thank you!

-- 
Best regards,
Dmitry