* Re: linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR) [not found] <20191115190525.77efdf6c@canb.auug.org.au> @ 2019-11-15 23:44 ` Randy Dunlap 2019-12-04 16:25 ` Randy Dunlap 0 siblings, 1 reply; 6+ messages in thread From: Randy Dunlap @ 2019-11-15 23:44 UTC (permalink / raw) To: Stephen Rothwell, Linux Next Mailing List Cc: Linux Kernel Mailing List, Linux PM list On 11/15/19 12:05 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20191114: > on i386: WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n] Selected by [y]: - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice> THERMAL_GOV_POWER_ALLOCATOR is selected by THERMAL_DEFAULT_GOV_POWER_ALLOCATOR even though ENERGY_MODEL is not set/enabled. -- ~Randy Reported-by: Randy Dunlap <rdunlap@infradead.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR) 2019-11-15 23:44 ` linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR) Randy Dunlap @ 2019-12-04 16:25 ` Randy Dunlap 2019-12-05 4:27 ` Zhang Rui 0 siblings, 1 reply; 6+ messages in thread From: Randy Dunlap @ 2019-12-04 16:25 UTC (permalink / raw) To: Stephen Rothwell, Linux Next Mailing List Cc: Linux Kernel Mailing List, Linux PM list, Zhang Rui, Eduardo Valentin, Daniel Lezcano, Amit Kucheria On 11/15/19 3:44 PM, Randy Dunlap wrote: > On 11/15/19 12:05 AM, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20191114: >> > > on i386: > > WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR > Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n] > Selected by [y]: > - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice> > > > THERMAL_GOV_POWER_ALLOCATOR is selected by THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > even though ENERGY_MODEL is not set/enabled. > > This Kconfig warning is still happening in linux-next of 20191204. -- ~Randy Reported-by: Randy Dunlap <rdunlap@infradead.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR) 2019-12-04 16:25 ` Randy Dunlap @ 2019-12-05 4:27 ` Zhang Rui 2019-12-05 4:36 ` Quentin Perret 2019-12-05 5:47 ` Randy Dunlap 0 siblings, 2 replies; 6+ messages in thread From: Zhang Rui @ 2019-12-05 4:27 UTC (permalink / raw) To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List Cc: Linux Kernel Mailing List, Linux PM list, Eduardo Valentin, Daniel Lezcano, Amit Kucheria, qperret On Wed, 2019-12-04 at 08:25 -0800, Randy Dunlap wrote: > On 11/15/19 3:44 PM, Randy Dunlap wrote: > > On 11/15/19 12:05 AM, Stephen Rothwell wrote: > > > Hi all, > > > > > > Changes since 20191114: > > > > > > > on i386: > > > > WARNING: unmet direct dependencies detected for > > THERMAL_GOV_POWER_ALLOCATOR > > Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n] > > Selected by [y]: > > - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice> > > > > > > THERMAL_GOV_POWER_ALLOCATOR is selected by > > THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > > even though ENERGY_MODEL is not set/enabled. > > > > > > This Kconfig warning is still happening in linux-next of 20191204. > I overlooked the original report probably because I was not CCed. This is introduced by commit a4e893e802e6("thermal: cpu_cooling: Migrate to using the EM framework") which adds the dependency of ENERGY_MODEL for THERMAL_GOV_POWER_ALLOCATOR. To fix this, it's better to make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR depends on THERMAL_GOV_POWER_ALLOCATOR instead. Please confirm the problem is fixed by below patch. thanks, rui From c9429f6e28ea2219686a4294d39f015ba373774b Mon Sep 17 00:00:00 2001 From: Zhang Rui <rui.zhang@intel.com> Date: Thu, 5 Dec 2019 12:17:07 +0800 Subject: [PATCH] thermal: fix a Kconfig warning Currently, THERMAL_GOV_POWER_ALLOCATOR is selected by THERMAL_DEFAULT_GOV_POWER_ALLOCATOR even if it has some unmet dependencies. This causes the Kconfig warning WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n] Selected by [y]: - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice> Fix the problem by making THERMAL_DEFAULT_GOV_POWER_ALLOCATOR depends on THERMAL_GOV_POWER_ALLOCATOR instead. Fixes: a4e893e802e6("thermal: cpu_cooling: Migrate to using the EM framework") Signed-off-by: Zhang Rui <rui.zhang@intel.com> --- drivers/thermal/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig index 59b79fc48266..79b27865c6f4 100644 --- a/drivers/thermal/Kconfig +++ b/drivers/thermal/Kconfig @@ -108,7 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR bool "power_allocator" - select THERMAL_GOV_POWER_ALLOCATOR + depends on THERMAL_GOV_POWER_ALLOCATOR help Select this if you want to control temperature based on system and device power allocation. This governor can only -- 2.17.1 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR) 2019-12-05 4:27 ` Zhang Rui @ 2019-12-05 4:36 ` Quentin Perret 2019-12-05 5:50 ` Zhang Rui 2019-12-05 5:47 ` Randy Dunlap 1 sibling, 1 reply; 6+ messages in thread From: Quentin Perret @ 2019-12-05 4:36 UTC (permalink / raw) To: Zhang Rui Cc: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List, Linux PM list, Eduardo Valentin, Daniel Lezcano, Amit Kucheria Hi all, On Thursday 05 Dec 2019 at 12:27:47 (+0800), Zhang Rui wrote: > I overlooked the original report probably because I was not CCed. > > This is introduced by commit a4e893e802e6("thermal: cpu_cooling: > Migrate to using the EM framework") which adds the dependency of > ENERGY_MODEL for THERMAL_GOV_POWER_ALLOCATOR. > > To fix this, it's better to make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > depends on THERMAL_GOV_POWER_ALLOCATOR instead. > > Please confirm the problem is fixed by below patch. > > thanks, > rui > > From c9429f6e28ea2219686a4294d39f015ba373774b Mon Sep 17 00:00:00 2001 > From: Zhang Rui <rui.zhang@intel.com> > Date: Thu, 5 Dec 2019 12:17:07 +0800 > Subject: [PATCH] thermal: fix a Kconfig warning > > Currently, THERMAL_GOV_POWER_ALLOCATOR is selected by > THERMAL_DEFAULT_GOV_POWER_ALLOCATOR even if it has some unmet > dependencies. > > This causes the Kconfig warning > WARNING: unmet direct dependencies detected for > THERMAL_GOV_POWER_ALLOCATOR > Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n] > Selected by [y]: > - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice> > > Fix the problem by making THERMAL_DEFAULT_GOV_POWER_ALLOCATOR depends on > THERMAL_GOV_POWER_ALLOCATOR instead. > > Fixes: a4e893e802e6("thermal: cpu_cooling: Migrate to using the EM framework") > Signed-off-by: Zhang Rui <rui.zhang@intel.com> > --- > drivers/thermal/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 59b79fc48266..79b27865c6f4 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -108,7 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE > > config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > bool "power_allocator" > - select THERMAL_GOV_POWER_ALLOCATOR > + depends on THERMAL_GOV_POWER_ALLOCATOR > help > Select this if you want to control temperature based on > system and device power allocation. This governor can only > -- > 2.17.1 FWIW, a similar fix has been suggested a couple weeks back: https://lore.kernel.org/lkml/20191113105313.41616-1-yuehaibing@huawei.com/ Thanks, Quentin ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR) 2019-12-05 4:36 ` Quentin Perret @ 2019-12-05 5:50 ` Zhang Rui 0 siblings, 0 replies; 6+ messages in thread From: Zhang Rui @ 2019-12-05 5:50 UTC (permalink / raw) To: Quentin Perret Cc: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List, Linux PM list, Eduardo Valentin, Daniel Lezcano, Amit Kucheria On Thu, 2019-12-05 at 04:36 +0000, Quentin Perret wrote: > Hi all, > > On Thursday 05 Dec 2019 at 12:27:47 (+0800), Zhang Rui wrote: > > I overlooked the original report probably because I was not CCed. > > > > This is introduced by commit a4e893e802e6("thermal: cpu_cooling: > > Migrate to using the EM framework") which adds the dependency of > > ENERGY_MODEL for THERMAL_GOV_POWER_ALLOCATOR. > > > > To fix this, it's better to make > > THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > > depends on THERMAL_GOV_POWER_ALLOCATOR instead. > > > > Please confirm the problem is fixed by below patch. > > > > thanks, > > rui > > > > From c9429f6e28ea2219686a4294d39f015ba373774b Mon Sep 17 00:00:00 > > 2001 > > From: Zhang Rui <rui.zhang@intel.com> > > Date: Thu, 5 Dec 2019 12:17:07 +0800 > > Subject: [PATCH] thermal: fix a Kconfig warning > > > > Currently, THERMAL_GOV_POWER_ALLOCATOR is selected by > > THERMAL_DEFAULT_GOV_POWER_ALLOCATOR even if it has some unmet > > dependencies. > > > > This causes the Kconfig warning > > WARNING: unmet direct dependencies detected for > > THERMAL_GOV_POWER_ALLOCATOR > > Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n] > > Selected by [y]: > > - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice> > > > > Fix the problem by making THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > > depends on > > THERMAL_GOV_POWER_ALLOCATOR instead. > > > > Fixes: a4e893e802e6("thermal: cpu_cooling: Migrate to using the EM > > framework") > > Signed-off-by: Zhang Rui <rui.zhang@intel.com> > > --- > > drivers/thermal/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > > index 59b79fc48266..79b27865c6f4 100644 > > --- a/drivers/thermal/Kconfig > > +++ b/drivers/thermal/Kconfig > > @@ -108,7 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE > > > > config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > > bool "power_allocator" > > - select THERMAL_GOV_POWER_ALLOCATOR > > + depends on THERMAL_GOV_POWER_ALLOCATOR > > help > > Select this if you want to control temperature based on > > system and device power allocation. This governor can only > > -- > > 2.17.1 > > FWIW, a similar fix has been suggested a couple weeks back: > > > https://lore.kernel.org/lkml/20191113105313.41616-1-yuehaibing@huawei.com/ Right, this patch was just merged by Daniel. It seems that we need a second PR in this merge window. thanks, rui > > Thanks, > Quentin ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR) 2019-12-05 4:27 ` Zhang Rui 2019-12-05 4:36 ` Quentin Perret @ 2019-12-05 5:47 ` Randy Dunlap 1 sibling, 0 replies; 6+ messages in thread From: Randy Dunlap @ 2019-12-05 5:47 UTC (permalink / raw) To: Zhang Rui, Stephen Rothwell, Linux Next Mailing List Cc: Linux Kernel Mailing List, Linux PM list, Eduardo Valentin, Daniel Lezcano, Amit Kucheria, qperret On 12/4/19 8:27 PM, Zhang Rui wrote: > On Wed, 2019-12-04 at 08:25 -0800, Randy Dunlap wrote: >> On 11/15/19 3:44 PM, Randy Dunlap wrote: >>> On 11/15/19 12:05 AM, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> Changes since 20191114: >>>> >>> >>> on i386: >>> >>> WARNING: unmet direct dependencies detected for >>> THERMAL_GOV_POWER_ALLOCATOR >>> Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n] >>> Selected by [y]: >>> - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice> >>> >>> >>> THERMAL_GOV_POWER_ALLOCATOR is selected by >>> THERMAL_DEFAULT_GOV_POWER_ALLOCATOR >>> even though ENERGY_MODEL is not set/enabled. >>> >>> >> >> This Kconfig warning is still happening in linux-next of 20191204. >> > I overlooked the original report probably because I was not CCed. > > This is introduced by commit a4e893e802e6("thermal: cpu_cooling: > Migrate to using the EM framework") which adds the dependency of > ENERGY_MODEL for THERMAL_GOV_POWER_ALLOCATOR. > > To fix this, it's better to make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > depends on THERMAL_GOV_POWER_ALLOCATOR instead. > > Please confirm the problem is fixed by below patch. > > thanks, > rui > > From c9429f6e28ea2219686a4294d39f015ba373774b Mon Sep 17 00:00:00 2001 > From: Zhang Rui <rui.zhang@intel.com> > Date: Thu, 5 Dec 2019 12:17:07 +0800 > Subject: [PATCH] thermal: fix a Kconfig warning > > Currently, THERMAL_GOV_POWER_ALLOCATOR is selected by > THERMAL_DEFAULT_GOV_POWER_ALLOCATOR even if it has some unmet > dependencies. > > This causes the Kconfig warning > WARNING: unmet direct dependencies detected for > THERMAL_GOV_POWER_ALLOCATOR > Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n] > Selected by [y]: > - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice> > > Fix the problem by making THERMAL_DEFAULT_GOV_POWER_ALLOCATOR depends on > THERMAL_GOV_POWER_ALLOCATOR instead. > > Fixes: a4e893e802e6("thermal: cpu_cooling: Migrate to using the EM framework") > Signed-off-by: Zhang Rui <rui.zhang@intel.com> Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Thanks. > --- > drivers/thermal/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig > index 59b79fc48266..79b27865c6f4 100644 > --- a/drivers/thermal/Kconfig > +++ b/drivers/thermal/Kconfig > @@ -108,7 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE > > config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR > bool "power_allocator" > - select THERMAL_GOV_POWER_ALLOCATOR > + depends on THERMAL_GOV_POWER_ALLOCATOR > help > Select this if you want to control temperature based on > system and device power allocation. This governor can only > -- ~Randy ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-12-05 5:50 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20191115190525.77efdf6c@canb.auug.org.au>
2019-11-15 23:44 ` linux-next: Tree for Nov 15 (thermal: THERMAL_GOV_POWER_ALLOCATOR) Randy Dunlap
2019-12-04 16:25 ` Randy Dunlap
2019-12-05 4:27 ` Zhang Rui
2019-12-05 4:36 ` Quentin Perret
2019-12-05 5:50 ` Zhang Rui
2019-12-05 5:47 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox