public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Amit Kucheria <amitk@kernel.org>,
	rafael@kernel.org, Zhang Rui <rui.zhang@intel.com>,
	"open list:THERMAL/POWER_ALLOCATOR" <linux-pm@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] thermal/core: Reorder the headers inclusion
Date: Fri, 13 Oct 2023 09:05:27 +0100	[thread overview]
Message-ID: <763f1d6d-28f0-43a7-b537-1a3229987ea3@arm.com> (raw)
In-Reply-To: <20231012102700.2858952-2-daniel.lezcano@linaro.org>



On 10/12/23 11:26, Daniel Lezcano wrote:
> The next changes will move the thermal device structure inside the
> thermal core code. Consequently, the traces must be included after
> thermal_core.h as this one contains the thermal zone device structure
> definition the traces need.
> 
> Reorder the inclusions.
> 
> No functional changes intended.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>   drivers/thermal/gov_power_allocator.c | 6 +++---
>   drivers/thermal/thermal_core.c        | 6 +++---
>   2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/thermal/gov_power_allocator.c b/drivers/thermal/gov_power_allocator.c
> index d1c6ad92e5b4..6056ed15460b 100644
> --- a/drivers/thermal/gov_power_allocator.c
> +++ b/drivers/thermal/gov_power_allocator.c
> @@ -11,12 +11,12 @@
>   #include <linux/slab.h>
>   #include <linux/thermal.h>
>   
> -#define CREATE_TRACE_POINTS
> -#include "thermal_trace_ipa.h"
> -
>   #define THERMAL_CORE_SUBSYS
>   #include "thermal_core.h"
>   
> +#define CREATE_TRACE_POINTS
> +#include "thermal_trace_ipa.h"


There is a small issue here to fix:

Applying: thermal/core: Reorder the headers inclusion
.git/rebase-apply/patch:21: trailing whitespace.
#include "thermal_trace_ipa.h"
warning: 1 line adds whitespace errors.

Other than that LGTM

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>

  reply	other threads:[~2023-10-13  8:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-12 10:26 [PATCH 1/2] thermal/core: Hardening the self-encapsulation Daniel Lezcano
2023-10-12 10:26 ` [PATCH 2/2] thermal/core: Reorder the headers inclusion Daniel Lezcano
2023-10-13  8:05   ` Lukasz Luba [this message]
2023-10-12 12:01 ` [PATCH 1/2] thermal/core: Hardening the self-encapsulation Lukasz Luba
2023-10-12 13:14   ` Daniel Lezcano
2023-10-12 14:30     ` Thierry Reding
2023-10-12 17:44     ` Rafael J. Wysocki
2023-10-12 21:13       ` Daniel Lezcano
2023-10-13  9:43         ` Rafael J. Wysocki
2023-10-13  8:03     ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=763f1d6d-28f0-43a7-b537-1a3229987ea3@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=amitk@kernel.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rafael@kernel.org \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox