From: Christian Loehle <christian.loehle@arm.com>
To: John Madieu <john.madieu.xa@bp.renesas.com>,
geert+renesas@glider.be, niklas.soderlund+renesas@ragnatech.se,
conor+dt@kernel.org, krzk+dt@kernel.org, robh@kernel.org,
rafael@kernel.org, daniel.lezcano@linaro.org
Cc: magnus.damm@gmail.com, claudiu.beznea.uj@bp.renesas.com,
devicetree@vger.kernel.org, john.madieu@gmail.com,
rui.zhang@intel.com, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org, biju.das.jz@bp.renesas.com,
linux-pm@vger.kernel.org
Subject: Re: [RFC PATCH 3/3] arm64: dts: renesas: r9a09g047: Add thermal hotplug trip point
Date: Tue, 11 Mar 2025 10:53:02 +0000 [thread overview]
Message-ID: <9b44d0ff-b28f-4d79-ad7b-b452db1db87a@arm.com> (raw)
In-Reply-To: <20250309121324.29633-4-john.madieu.xa@bp.renesas.com>
On 3/9/25 12:13, John Madieu wrote:
> Add CPU hotplug trip point to shutdown CPU1 and CPU2 when exceeding 110°C.
>
> Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com>
> ---
> arch/arm64/boot/dts/renesas/r9a09g047.dtsi | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> index 93b57d7ad7b9..06bd394582e2 100644
> --- a/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a09g047.dtsi
> @@ -533,6 +533,13 @@ map0 {
> <&cpu2 0 3>, <&cpu3 0 3>;
> contribution = <1024>;
> };
> +
> + map1 {
> + trip = <&trip_emergency>;
> + cooling-device = <&cpu1 0 1>, <&cpu2 0 1>;
> + contribution = <1024>;
> + };
> +
> };
>
> trips {
> @@ -542,6 +549,12 @@ target: trip-point {
> type = "passive";
> };
>
> + trip_emergency: emergency {
> + temperature = <110000>;
> + hysteresis = <1000>;
> + type = "plug";
> + };
> +
> sensor_crit: sensor-crit {
> temperature = <120000>;
> hysteresis = <1000>;
Are there no other cooling methods?
How does it compare to idle inject?
Furthermore, couldn't the offlining of some CPUs lead to the rest being
operated at much higher OPPs therefore the overall power increase, too?
(Without having looked at if this is a possibility for this particular
SoC.)
Some numbers would be helpful IMO.
next prev parent reply other threads:[~2025-03-11 10:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-09 12:13 [RFC PATCH 0/3] thermal: Add CPU hotplug cooling driver John Madieu
2025-03-09 12:13 ` [RFC PATCH 1/3] thermal/cpuplog_cooling: " John Madieu
2025-03-11 7:30 ` Krzysztof Kozlowski
2025-03-11 11:38 ` John Madieu
2025-03-11 8:28 ` Geert Uytterhoeven
2025-03-11 11:41 ` John Madieu
2025-03-09 12:13 ` [RFC PATCH 2/3] tmon: Add support for THERMAL_TRIP_PLUG type John Madieu
2025-03-09 12:13 ` [RFC PATCH 3/3] arm64: dts: renesas: r9a09g047: Add thermal hotplug trip point John Madieu
2025-03-11 10:53 ` Christian Loehle [this message]
2025-03-11 11:57 ` John Madieu
2025-03-11 15:29 ` Christian Loehle
2025-03-10 10:17 ` [RFC PATCH 0/3] thermal: Add CPU hotplug cooling driver Biju Das
2025-03-11 11:33 ` John Madieu
2025-03-15 14:40 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b44d0ff-b28f-4d79-ad7b-b452db1db87a@arm.com \
--to=christian.loehle@arm.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=claudiu.beznea.uj@bp.renesas.com \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=john.madieu.xa@bp.renesas.com \
--cc=john.madieu@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox