public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: Artem Bityutskiy <dedekind1@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>,
	David Arcari <darcari@redhat.com>
Cc: linux-pm@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>,
	Len Brown <lenb@kernel.org>, Prarit Bhargava <prarit@redhat.com>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] intel_idle: introduce 'no_native' module parameter
Date: Thu, 20 Feb 2025 14:50:44 +0200	[thread overview]
Message-ID: <9b67088de0b6a24a67cfe0a1860011d290307c08.camel@gmail.com> (raw)
In-Reply-To: <CAJZ5v0g27Sutp_Ww7zGe0xB95kxFh-pzjd5-PpjR==h7-s8MLA@mail.gmail.com>

On Tue, 2025-02-18 at 20:57 +0100, Rafael J. Wysocki wrote:
> On Thu, Feb 13, 2025 at 5:07 PM David Arcari <darcari@redhat.com> wrote:
> > 
> > Since commit 18734958e9bf ("intel_idle: Use ACPI _CST for processor models
> > without C-state tables") the intel_idle driver has had the ability to use
> > the ACPI _CST to populate C-states when the processor model is not
> > recognized. However, even when the processor model is recognized (native
> > mode) there are cases where it is useful to make the driver ignore the per
> > cpu idle states in lieu of ACPI C-states (such as specific application
> > performance). Add the 'no_native' module parameter to provide this
> > functionality.
> > 
> > Cc: Jonathan Corbet <corbet@lwn.net>
> > Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
> > Cc: Len Brown <lenb@kernel.org>
> > Cc: David Arcari <darcari@redhat.com>
> > Cc: Artem Bityutskiy <dedekind1@gmail.com>
> > Cc: Prarit Bhargava <prarit@redhat.com>
> > Cc: linux-doc@vger.kernel.org
> > Cc: linux-kernel@vger.kernel.org
> > Signed-off-by: David Arcari <darcari@redhat.com>
> > ---
> > v4: fix !CONFIG_ACPI_PROCESSOR_CSTATE compilation issue
> 
> Artem, have all of your comments been addressed in this version?

Hi, I was away for few days. Yes, this patch looks good to me. Works, and
useful. Granted your comment is also addressed:

Reviewed-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>

  reply	other threads:[~2025-02-20 12:50 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-28 14:11 [PATCH] intel_idle: introduce 'use_acpi_cst' module parameter David Arcari
2025-02-04 12:23 ` Artem Bityutskiy
2025-02-04 12:52   ` David Arcari
2025-02-04 13:04     ` Prarit Bhargava
2025-02-04 15:21     ` Rafael J. Wysocki
2025-02-04 16:30       ` Artem Bityutskiy
2025-02-04 17:33         ` Rafael J. Wysocki
2025-02-05 12:09           ` David Arcari
2025-02-04 16:26     ` Artem Bityutskiy
2025-02-06 16:40 ` [PATCH v2] intel_idle: introduce 'no_native' " David Arcari
2025-02-07 15:55   ` Artem Bityutskiy
2025-02-07 17:13     ` David Arcari
2025-02-08 10:37       ` Artem Bityutskiy
2025-02-08 19:56         ` David Arcari
2025-02-09  9:08           ` Artem Bityutskiy
2025-02-11 13:27 ` [PATCH v3] " David Arcari
2025-02-12  7:04   ` Artem Bityutskiy
2025-02-12 10:09   ` kernel test robot
2025-02-12 11:32     ` Artem Bityutskiy
2025-02-12 12:41       ` David Arcari
2025-02-12 12:46         ` Artem Bityutskiy
2025-02-12 12:53           ` David Arcari
2025-02-12 12:49         ` Artem Bityutskiy
2025-02-13 11:49   ` kernel test robot
2025-02-13 16:07 ` [PATCH v4] " David Arcari
2025-02-18 19:57   ` Rafael J. Wysocki
2025-02-20 12:50     ` Artem Bityutskiy [this message]
2025-02-19 21:27   ` Rafael J. Wysocki
2025-02-20 12:21     ` David Arcari
2025-02-20 12:23       ` Rafael J. Wysocki
2025-02-20 15:11 ` [PATCH v5] " David Arcari
2025-02-20 20:02   ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9b67088de0b6a24a67cfe0a1860011d290307c08.camel@gmail.com \
    --to=dedekind1@gmail.com \
    --cc=corbet@lwn.net \
    --cc=darcari@redhat.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=lenb@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=prarit@redhat.com \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox