From: Artem Bityutskiy <dedekind1@gmail.com>
To: David Arcari <darcari@redhat.com>, linux-pm@vger.kernel.org
Cc: Jonathan Corbet <corbet@lwn.net>,
Jacob Pan <jacob.jun.pan@linux.intel.com>,
Len Brown <lenb@kernel.org>, Prarit Bhargava <prarit@redhat.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] intel_idle: introduce 'no_native' module parameter
Date: Sat, 08 Feb 2025 12:37:06 +0200 [thread overview]
Message-ID: <c25d3b9abced9263da463b3ef4f31fff73878189.camel@gmail.com> (raw)
In-Reply-To: <9241eff1-0c2d-4c82-a77d-cb8b67cab6f9@redhat.com>
On Fri, 2025-02-07 at 12:13 -0500, David Arcari wrote:
> > And if kernel was not configured with ACPI support, are these not
> > recognized? Or
> > they are just no-op basically?
>
> They are a no-op - the flags are all set to false so ACPI C-state tables
> are ignored.
It would be nice to mention this too. Otherwise it sounds a bit incomplete. Like
this:
If A then B. (nothing about "else").
Better way:
If A then B, else C.
:-)
> >
> Sure - so is this better:
>
> ``use_acpi`` - No-op in ACPI mode, the driver will consult ACPI tabees
> for C-states on/off status in native mode.
Yes, thanks!
next prev parent reply other threads:[~2025-02-08 10:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 14:11 [PATCH] intel_idle: introduce 'use_acpi_cst' module parameter David Arcari
2025-02-04 12:23 ` Artem Bityutskiy
2025-02-04 12:52 ` David Arcari
2025-02-04 13:04 ` Prarit Bhargava
2025-02-04 15:21 ` Rafael J. Wysocki
2025-02-04 16:30 ` Artem Bityutskiy
2025-02-04 17:33 ` Rafael J. Wysocki
2025-02-05 12:09 ` David Arcari
2025-02-04 16:26 ` Artem Bityutskiy
2025-02-06 16:40 ` [PATCH v2] intel_idle: introduce 'no_native' " David Arcari
2025-02-07 15:55 ` Artem Bityutskiy
2025-02-07 17:13 ` David Arcari
2025-02-08 10:37 ` Artem Bityutskiy [this message]
2025-02-08 19:56 ` David Arcari
2025-02-09 9:08 ` Artem Bityutskiy
2025-02-11 13:27 ` [PATCH v3] " David Arcari
2025-02-12 7:04 ` Artem Bityutskiy
2025-02-12 10:09 ` kernel test robot
2025-02-12 11:32 ` Artem Bityutskiy
2025-02-12 12:41 ` David Arcari
2025-02-12 12:46 ` Artem Bityutskiy
2025-02-12 12:53 ` David Arcari
2025-02-12 12:49 ` Artem Bityutskiy
2025-02-13 11:49 ` kernel test robot
2025-02-13 16:07 ` [PATCH v4] " David Arcari
2025-02-18 19:57 ` Rafael J. Wysocki
2025-02-20 12:50 ` Artem Bityutskiy
2025-02-19 21:27 ` Rafael J. Wysocki
2025-02-20 12:21 ` David Arcari
2025-02-20 12:23 ` Rafael J. Wysocki
2025-02-20 15:11 ` [PATCH v5] " David Arcari
2025-02-20 20:02 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c25d3b9abced9263da463b3ef4f31fff73878189.camel@gmail.com \
--to=dedekind1@gmail.com \
--cc=corbet@lwn.net \
--cc=darcari@redhat.com \
--cc=jacob.jun.pan@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox