From: "Danilo Krummrich" <dakr@kernel.org>
To: "Daniel Sedlak" <daniel@sedlak.dev>
Cc: "Daniel Almeida" <daniel.almeida@collabora.com>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <lossin@kernel.org>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] rust: clk: use the type-state pattern
Date: Wed, 30 Jul 2025 10:29:24 +0200 [thread overview]
Message-ID: <DBP8YI8BA4PL.RG9D2ZL8SBR5@kernel.org> (raw)
In-Reply-To: <fc26c393-5c4b-48a8-a7ac-12558f79b140@sedlak.dev>
On Wed Jul 30, 2025 at 9:29 AM CEST, Daniel Sedlak wrote:
> On 7/29/25 11:38 PM, Daniel Almeida wrote:
>> + /// An error that can occur when trying to convert a [`Clk`] between states.
>> + pub struct Error<State: ClkState> {
>
> Nit: IMO we mostly use the `where` variant instead of the colon.
>
> pub struct Error<State>
> where State: ClkState
For such simple struct definitions with just a single trait bound it's not very
common to use a where clause. I think the definition is fine as it is.
next prev parent reply other threads:[~2025-07-30 8:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 21:38 [PATCH] rust: clk: use the type-state pattern Daniel Almeida
2025-07-30 6:23 ` Viresh Kumar
2025-07-30 12:27 ` Daniel Almeida
2025-07-30 14:48 ` Viresh Kumar
2025-07-30 7:29 ` Daniel Sedlak
2025-07-30 8:20 ` Benno Lossin
2025-07-30 12:59 ` Daniel Almeida
2025-07-30 13:27 ` Daniel Sedlak
2025-07-30 13:30 ` Daniel Almeida
2025-07-30 13:39 ` Alice Ryhl
2025-07-30 13:45 ` Daniel Almeida
2025-07-30 8:29 ` Danilo Krummrich [this message]
2025-07-30 12:25 ` Daniel Almeida
2025-07-30 8:03 ` Danilo Krummrich
2025-07-30 12:13 ` Daniel Almeida
2025-07-30 12:24 ` Danilo Krummrich
2025-07-30 13:52 ` Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBP8YI8BA4PL.RG9D2ZL8SBR5@kernel.org \
--to=dakr@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=daniel.almeida@collabora.com \
--cc=daniel@sedlak.dev \
--cc=gary@garyguo.net \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mturquette@baylibre.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox