From: Daniel Almeida <daniel.almeida@collabora.com>
To: Alice Ryhl <aliceryhl@google.com>
Cc: "Daniel Sedlak" <daniel@sedlak.dev>,
"Benno Lossin" <lossin@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
"Trevor Gross" <tmgross@umich.edu>,
"Danilo Krummrich" <dakr@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Alexandre Courbot" <acourbot@nvidia.com>,
linux-clk@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] rust: clk: use the type-state pattern
Date: Wed, 30 Jul 2025 10:45:39 -0300 [thread overview]
Message-ID: <41B46C07-5408-41ED-91F9-CB3979944DCB@collabora.com> (raw)
In-Reply-To: <CAH5fLgjBQF+AGWQ-rKowViiL1kK47FZ80QfEa58Cx9bk11cjAw@mail.gmail.com>
Hi Alice,
> It seems a bit much to have macros for everything.
I understand your point of view, but at this point the “mod private”
boilerplate is growing by the day.
It would at least make reviews slightly easier, because reviewers don't have to
ask themselves whether the submitter implemented the pattern correctly.
IMHO, of course.
— Daniel
next prev parent reply other threads:[~2025-07-30 13:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 21:38 [PATCH] rust: clk: use the type-state pattern Daniel Almeida
2025-07-30 6:23 ` Viresh Kumar
2025-07-30 12:27 ` Daniel Almeida
2025-07-30 14:48 ` Viresh Kumar
2025-07-30 7:29 ` Daniel Sedlak
2025-07-30 8:20 ` Benno Lossin
2025-07-30 12:59 ` Daniel Almeida
2025-07-30 13:27 ` Daniel Sedlak
2025-07-30 13:30 ` Daniel Almeida
2025-07-30 13:39 ` Alice Ryhl
2025-07-30 13:45 ` Daniel Almeida [this message]
2025-07-30 8:29 ` Danilo Krummrich
2025-07-30 12:25 ` Daniel Almeida
2025-07-30 8:03 ` Danilo Krummrich
2025-07-30 12:13 ` Daniel Almeida
2025-07-30 12:24 ` Danilo Krummrich
2025-07-30 13:52 ` Daniel Almeida
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41B46C07-5408-41ED-91F9-CB3979944DCB@collabora.com \
--to=daniel.almeida@collabora.com \
--cc=a.hindborg@kernel.org \
--cc=acourbot@nvidia.com \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel@sedlak.dev \
--cc=gary@garyguo.net \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lossin@kernel.org \
--cc=mturquette@baylibre.com \
--cc=ojeda@kernel.org \
--cc=rafael@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tmgross@umich.edu \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox