From: Mark Brown <broonie@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>, linux-pm@vger.kernel.org
Subject: Re: [PATCH] power: supply: Use an rbtree rather than flat register cache
Date: Thu, 24 Feb 2022 12:08:13 +0000 [thread overview]
Message-ID: <Yhd1LV9OPD/slCV8@sirena.org.uk> (raw)
In-Reply-To: <666e7ad7-1eb2-f8bb-8ef8-d92d5e18d01b@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 507 bytes --]
On Thu, Feb 24, 2022 at 02:35:42PM +0300, Dmitry Osipenko wrote:
> To make it more clear.. there was no problem with "suppressing a write",
> the problem was that regmap reads are done from the cache, and if cache
> isn't per-initialized, then you read zeros from the cache until write is
> made.
With update_bits() that can result in an attempt to set a bit to zero
not actually taking effect if it believes that the bit was already set
to zero and there has been no change in the value of the register.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-24 12:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 21:43 [PATCH] power: supply: Use an rbtree rather than flat register cache Mark Brown
2022-02-24 10:54 ` Sebastian Reichel
2022-02-24 11:07 ` Dmitry Osipenko
2022-02-24 11:35 ` Dmitry Osipenko
2022-02-24 12:08 ` Mark Brown [this message]
2022-02-24 14:10 ` Dmitry Osipenko
2022-02-24 11:45 ` Mark Brown
2022-02-24 14:58 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yhd1LV9OPD/slCV8@sirena.org.uk \
--to=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox