From: Mark Brown <broonie@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>, linux-pm@vger.kernel.org
Subject: Re: [PATCH] power: supply: Use an rbtree rather than flat register cache
Date: Thu, 24 Feb 2022 11:45:05 +0000 [thread overview]
Message-ID: <YhdvwYt+7ElEGrmZ@sirena.org.uk> (raw)
In-Reply-To: <951baa84-1613-7567-4426-ffc6412994da@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 587 bytes --]
On Thu, Feb 24, 2022 at 02:07:58PM +0300, Dmitry Osipenko wrote:
> 23.02.2022 00:43, Mark Brown пишет:
> > - .num_reg_defaults_raw = SMB347_MAX_REGISTER,
> > + .cache_type = REGCACHE_RBTREE,
> Why you removed the num_reg_defaults_raw? It was needed in order to
> populate the default values on the regcache init, is it somehow
> different for the REGCACHE_RBTREE? Otherwise this patch is incorrect.
rbtree caches will dynamically grow at runtime to accomodate any new
registers they find, it's not like flat caches where they are intended
for use in atomic context.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-02-24 11:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 21:43 [PATCH] power: supply: Use an rbtree rather than flat register cache Mark Brown
2022-02-24 10:54 ` Sebastian Reichel
2022-02-24 11:07 ` Dmitry Osipenko
2022-02-24 11:35 ` Dmitry Osipenko
2022-02-24 12:08 ` Mark Brown
2022-02-24 14:10 ` Dmitry Osipenko
2022-02-24 11:45 ` Mark Brown [this message]
2022-02-24 14:58 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YhdvwYt+7ElEGrmZ@sirena.org.uk \
--to=broonie@kernel.org \
--cc=digetx@gmail.com \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox