Linux Power Management development
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: K Prateek Nayak <kprateek.nayak@amd.com>,
	Huang Rui <ray.huang@amd.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Kalpana Shetty <kalpana.shetty@amd.com>
Cc: Mario Limonciello <superm1@kernel.org>,
	Perry Yuan <perry.yuan@amd.com>,
	linux-pm@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/9] cpufreq/amd-pstate: BIOS min perf fixes and Dynamic EPP rework
Date: Fri, 24 Jul 2026 14:07:35 -0500	[thread overview]
Message-ID: <a841ceef-8d94-4134-9c04-a96cc4f4cdd2@amd.com> (raw)
In-Reply-To: <20260723201228.22584-1-kprateek.nayak@amd.com>



On 7/23/26 15:12, K Prateek Nayak wrote:
> This is essentially a combined v2 of the following series:
> 
>    https://lore.kernel.org/lkml/20260715074822.16324-1-kprateek.nayak@amd.com/
>    https://lore.kernel.org/lkml/20260630185904.5602-1-kprateek.nayak@amd.com/
> 
> The first two patches fix BIOS min perf setting and its persistence
> across kexec. The next set of patches rework the Dynamic EPP feature
> into an energy_performance_preference mode.
> 
> Unit tests are extended to cover the new dynamic_epp mode and also the
> floor perf (CPPC Performance Priority) feature for completeness.
> 
> Patches are based on:
> 
>    git.kernel.org/pub/scm/linux/kernel/git/superm1/linux.git bleeding-edge
> 
> at commit 39c0cf62fc78 ("cpufreq/amd-pstate: handle missing policy in
> dynamic EPP callbacks")
> 
> Everyone has been Cc'd on the cover letter. Respective maintainers have
> been Cc'd on the relevant patches to reduce noise. Lists get the full
> series.
> 
> ---
> Changelog rfc v1..v2:
> 
> o Simplified bios_min_perf handover during kexec by removing the
>    defensive check (Mario).
> 
> o Removed the amd_dynamic_epp kernel cmdline and the dynamic_epp sysfs
>    file as they are now redundant.
> 
> o Updated the documentation.
> 
> o Updated unit test to account for dynamic_epp removal.
> 
> o Added unit test for floor frequency. (Kalpana)
> 
> Individual patches have breief changelogs attached. Reviews and testing
> is highly appreciated.

Can you take a look at the Sashiko feedback?  Especially on patch 1, I 
think another safe guard makes sense.

https://sashiko.dev/#/patchset/20260723201228.22584-1-kprateek.nayak%40amd.com

      parent reply	other threads:[~2026-07-24 19:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-23 20:12 [PATCH v2 0/9] cpufreq/amd-pstate: BIOS min perf fixes and Dynamic EPP rework K Prateek Nayak
2026-07-23 20:12 ` [PATCH v2 1/9] cpufreq/amd-pstate: Set min_limit_freq based on bios_min_perf K Prateek Nayak
2026-07-23 20:12 ` [PATCH v2 2/9] cpufreq/amd-pstate: Remove the defensive check for bios_min_perf K Prateek Nayak
2026-07-23 21:17   ` Mario Limonciello
2026-07-23 20:12 ` [PATCH v2 3/9] cpufreq/amd-pstate: Extract platform profile to EPP conversion into a helper K Prateek Nayak
2026-07-23 20:12 ` [PATCH v2 4/9] cpufreq/amd-pstate: Add dynamic EPP as an "energy_performance_preference" mode K Prateek Nayak
2026-07-24 18:55   ` Mario Limonciello
2026-07-23 20:12 ` [PATCH v2 5/9] cpufreq/amd-pstate: Remove "amd_dynamic_epp" cmdline and "dynamic_epp" sysfs K Prateek Nayak
2026-07-24 18:55   ` Mario Limonciello
2026-07-23 20:12 ` [PATCH v2 6/9] Documentation/amd-pstate: Update dynamic_epp documentation with new behavior K Prateek Nayak
2026-07-24 18:57   ` Mario Limonciello
2026-07-23 20:12 ` [PATCH v2 7/9] cpufreq/amd-pstate: Reduce the scope of exported symbols K Prateek Nayak
2026-07-23 20:12 ` [PATCH v2 8/9] cpufreq/amd-pstate-ut: Add unit test for "dynamic" EPP mode K Prateek Nayak
2026-07-24 19:04   ` Mario Limonciello
2026-07-23 20:12 ` [PATCH v2 9/9] cpufreq/amd-pstate-ut: Add unit test for CPPC Performance Priority K Prateek Nayak
2026-07-24 19:04   ` Mario Limonciello
2026-07-24 19:07 ` Mario Limonciello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a841ceef-8d94-4134-9c04-a96cc4f4cdd2@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=corbet@lwn.net \
    --cc=kalpana.shetty@amd.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=perry.yuan@amd.com \
    --cc=rafael@kernel.org \
    --cc=ray.huang@amd.com \
    --cc=skhan@linuxfoundation.org \
    --cc=superm1@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox