public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "John B. Wyatt IV" <jwyatt@redhat.com>
To: "Francesco Poli (wintermute)" <invernomuto@paranoici.org>
Cc: linux-pm list <linux-pm@vger.kernel.org>,
	Thomas Renninger <trenn@suse.com>, Shuah Khan <shuah@kernel.org>,
	John Kacur <jkacur@redhat.com>
Subject: Re: [PATCH v2] cpupower: add a systemd service to run cpupower
Date: Tue, 29 Apr 2025 16:59:03 -0400	[thread overview]
Message-ID: <aBE9ly7vP0eryfMO@thinkpad2024> (raw)
In-Reply-To: <20250425151024.121630-1-invernomuto@paranoici.org>

On Fri, Apr 25, 2025 at 05:07:31PM +0200, Francesco Poli (wintermute) wrote:
> One of the most typical use cases of the 'cpupower' utility works as
> follows: run 'cpupower' at boot with the desired command-line options
> and then forget about it.
> 
> Add a systemd service (disabled by default) that automates this use
> case (for environments where the initialization system is 'systemd'),
> by running 'cpupower' at boot with the settings read from a default
> configuration file.
> 
> The systemd service, the associated support script and the
> corresponding default configuration file are derived from what is
> provided by the Arch Linux package (under "GPL-2.0-or-later" terms),
> modernized and enhanced in various ways (the script has also been
> checked with 'shellcheck').
> 
> Link: https://gitlab.archlinux.org/archlinux/packaging/packages/linux-tools/-/tree/dd2e2a311e05413d0d87a0346ffce8c7e98d6d2b
> 
> Signed-off-by: Francesco Poli (wintermute) <invernomuto@paranoici.org>

Tested by installing the new systemd files, amending the
cpupower.default file and trying out the governor and frequency options.
I did encounter the systemd service exiting on boot after setting
performance options. The service set my options mostly correctly; my
machine has a limited number of cpu governors. This may have been my error and
I will need to test more when I have time.

Adding my tags.

Reviewed-by: John B. Wyatt IV <jwyatt@redhat.com>
Reviewed-by: John B. Wyatt IV <sageofredondo@gmail.com>
Tested-by: John B. Wyatt IV <jwyatt@redhat.com>
Tested-by: John B. Wyatt IV <sageofredondo@gmail.com>

-- 
Sincerely,
John Wyatt
Software Engineer, Core Kernel
Red Hat


  reply	other threads:[~2025-04-29 20:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-25 15:07 [PATCH v2] cpupower: add a systemd service to run cpupower Francesco Poli (wintermute)
2025-04-29 20:59 ` John B. Wyatt IV [this message]
2025-05-02 15:53   ` Francesco Poli
2025-05-02 16:41     ` Shuah Khan
2025-05-02 19:55       ` Shuah Khan
2025-05-03 10:59         ` Francesco Poli
2025-05-05 16:06 ` Thorsten Leemhuis
2025-05-05 20:55   ` Francesco Poli
2025-05-06  4:40     ` Thorsten Leemhuis
2025-05-07  8:07 ` Thorsten Leemhuis
2025-05-07 22:18   ` Francesco Poli
2025-05-08  8:02     ` Thorsten Leemhuis
2025-05-08 16:22     ` John B. Wyatt IV
2025-05-08 22:22       ` Francesco Poli
2025-05-14 12:41 ` Thorsten Leemhuis
2025-05-14 17:53   ` John B. Wyatt IV
2025-05-14 20:39     ` Francesco Poli
2025-05-14 20:23   ` Francesco Poli
2025-05-15  6:12     ` Thorsten Leemhuis
2025-05-21 21:23       ` Francesco Poli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aBE9ly7vP0eryfMO@thinkpad2024 \
    --to=jwyatt@redhat.com \
    --cc=invernomuto@paranoici.org \
    --cc=jkacur@redhat.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=trenn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox