Re: [PATCH v2] cpupower: add a systemd service to run cpupower

["John B. Wyatt IV" <jwyatt@redhat.com>]

On Wed, May 14, 2025 at 02:41:35PM +0200, Thorsten Leemhuis wrote:
> Hi Francesco! Many thx for addressing the issues I brought up earlier
> which now landed in -next, much appreciated.
> 
> Sadly with those fixes in I noticed another issue I missed earlier. One
> from the "small differences between different Linux distributions that
> make all our lives hard". :-/media/
> 
> On 25.04.25 17:07, Francesco Poli (wintermute) wrote:
> > One of the most typical use cases of the 'cpupower' utility works as
> > follows: run 'cpupower' at boot with the desired command-line options
> > and then forget about it.
> 
> > diff --git a/tools/power/cpupower/Makefile b/tools/power/cpupower/Makefile
> > index 835123add0ed..9c2b5f71fee1 100644
> > [...]
> > @@ -302,6 +305,14 @@ install-tools: $(OUTPUT)cpupower
> >  	$(INSTALL_PROGRAM) $(OUTPUT)cpupower $(DESTDIR)${bindir}
> >  	$(INSTALL) -d $(DESTDIR)${bash_completion_dir}
> >  	$(INSTALL_SCRIPT) cpupower-completion.sh '$(DESTDIR)${bash_completion_dir}/cpupower'
> > +	$(INSTALL) -d $(DESTDIR)${confdir}default
> > +	$(INSTALL_DATA) cpupower.default '$(DESTDIR)${confdir}default/cpupower'
> > +	$(INSTALL) -d $(DESTDIR)${libexecdir}
> > +	$(INSTALL_PROGRAM) cpupower.sh '$(DESTDIR)${libexecdir}/cpupower'
> > +	$(INSTALL) -d $(DESTDIR)${libdir}/systemd/system
> 
> That last line to the best of my knowledge is wrong on distributions
> like Fedora, where ${libdir} expands to /usr/lib64/ -- which is the
> right path for libraries, but the wrong one for systemd units, as they
> are always stored in /usr/lib/systemd/system (at least on Fedora). Not
> sure what the right fix it, it might be something like defining
> 
> unitdir ?= /usr/lib/systemd/system
> 
> earlier in the Makefile and then using it in the last quoted line above.
> 
> Ciao, Thorsten
> 

Checked the Arch pkgs and my Ubuntu 22.04 install.

Both of them copy service files to that folder as well. The Debian package
is difficult to read at a glance.

The problem is that Fedora installs libraries to lib64; Arch and Ubuntu
(22.04 & likely Debian) do not from what I can tell. This likely is the
reason for that issue I had-I thought I misconfigured something or it
was a bug in cpupower logic.

That unitdir looks like it would be a good suggestion as a quick fix,
but Shuah, how are you feeling about these patches?

I am on mobile data right now due to an internet issue so my ability to
test is limited right now.

-- 
Sincerely,
John Wyatt
Software Engineer, Core Kernel
Red Hat