* [PATCH next] OPP: core: Fix loop in dev_pm_opp_sync_regulators()
@ 2025-04-30 8:07 Dan Carpenter
2025-04-30 8:46 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2025-04-30 8:07 UTC (permalink / raw)
To: Viresh Kumar
Cc: Viresh Kumar, Nishanth Menon, Stephen Boyd, linux-pm,
linux-kernel, kernel-janitors
We accidentally deleted the if statement in this loop during a cleanup.
Add it back.
Fixes: 5330d0dab736 ("OPP: Define and use scope-based cleanup helpers")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/opp/core.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/opp/core.c b/drivers/opp/core.c
index fc9874946453..f56ddae35ef2 100644
--- a/drivers/opp/core.c
+++ b/drivers/opp/core.c
@@ -2889,7 +2889,7 @@ int dev_pm_opp_sync_regulators(struct device *dev)
{
struct opp_table *opp_table __free(put_opp_table);
struct regulator *reg;
- int i;
+ int i, ret;
/* Device may not have OPP table */
opp_table = _find_opp_table(dev);
@@ -2906,7 +2906,9 @@ int dev_pm_opp_sync_regulators(struct device *dev)
for (i = 0; i < opp_table->regulator_count; i++) {
reg = opp_table->regulators[i];
- return regulator_sync_voltage(reg);
+ ret = regulator_sync_voltage(reg);
+ if (ret)
+ return ret;
}
return 0;
--
2.47.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] OPP: core: Fix loop in dev_pm_opp_sync_regulators()
2025-04-30 8:07 [PATCH next] OPP: core: Fix loop in dev_pm_opp_sync_regulators() Dan Carpenter
@ 2025-04-30 8:46 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2025-04-30 8:46 UTC (permalink / raw)
To: Dan Carpenter
Cc: Viresh Kumar, Nishanth Menon, Stephen Boyd, linux-pm,
linux-kernel, kernel-janitors
On 30-04-25, 11:07, Dan Carpenter wrote:
> We accidentally deleted the if statement in this loop during a cleanup.
> Add it back.
>
> Fixes: 5330d0dab736 ("OPP: Define and use scope-based cleanup helpers")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/opp/core.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/opp/core.c b/drivers/opp/core.c
> index fc9874946453..f56ddae35ef2 100644
> --- a/drivers/opp/core.c
> +++ b/drivers/opp/core.c
> @@ -2889,7 +2889,7 @@ int dev_pm_opp_sync_regulators(struct device *dev)
> {
> struct opp_table *opp_table __free(put_opp_table);
> struct regulator *reg;
> - int i;
> + int i, ret;
>
> /* Device may not have OPP table */
> opp_table = _find_opp_table(dev);
> @@ -2906,7 +2906,9 @@ int dev_pm_opp_sync_regulators(struct device *dev)
>
> for (i = 0; i < opp_table->regulator_count; i++) {
> reg = opp_table->regulators[i];
> - return regulator_sync_voltage(reg);
> + ret = regulator_sync_voltage(reg);
> + if (ret)
> + return ret;
> }
>
> return 0;
Ahh, thanks for the fix Dan. I have folded this in the original patch
itself.
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-04-30 8:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-04-30 8:07 [PATCH next] OPP: core: Fix loop in dev_pm_opp_sync_regulators() Dan Carpenter
2025-04-30 8:46 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox