From: Julia Lawall <julia.lawall@lip6.fr>
To: Liam Breck <liam@networkimprov.net>
Cc: "Joe Perches" <joe@perches.com>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Sebastian Reichel" <sebastian.reichel@collabora.co.uk>,
"Pali Rohár" <pali.rohar@gmail.com>,
"Linux PM mailing list" <linux-pm@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
"Gilles Muller" <Gilles.Muller@lip6.fr>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
"Michal Marek" <mmarek@suse.com>,
cocci@systeme.lip6.fr,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"kbuild test robot" <fengguang.wu@intel.com>
Subject: Re: [PATCH] coccinelle: api: detect duplicate chip data arrays
Date: Thu, 5 Oct 2017 21:28:00 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.20.1710052127320.2626@hadrien> (raw)
In-Reply-To: <CAKvHMgRx9U+GQ82GrSZYTAA6s1RH+HpEtkYZYf+O3VzqLDoD_g@mail.gmail.com>
On Thu, 5 Oct 2017, Liam Breck wrote:
> Hi Joe,
>
> On Thu, Oct 5, 2017 at 12:15 PM, Joe Perches <joe@perches.com> wrote:
> > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote:
> >>
> >> On Fri, 6 Oct 2017, Masahiro Yamada wrote:
> >>
> >> > 2017-10-01 21:42 GMT+09:00 Julia Lawall <Julia.Lawall@lip6.fr>:
> >> > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA
> >> > > within a single structure. It is currently specific to the file
> >> > > drivers/power/supply/bq27xxx_battery.c.
> >> > >
> >> > > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >> > >
> >> > > ---
> >> >
> >> > Applied to linux-kbuild/misc.
> >>
> >> Thanks for picking it up.
> >
> > If it is specific to one file, why not just run it
> > and post the resultant patch? Why have it in tree?
>
> The driver which this script analyzes supports more than a dozen
> different chips, which require different parameters. This script
> checks for duplicate parameter arrays.
I think the question is more how will the code change over time.
julia
next prev parent reply other threads:[~2017-10-05 19:28 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-01 12:42 [PATCH] coccinelle: api: detect duplicate chip data arrays Julia Lawall
2017-10-05 18:02 ` Masahiro Yamada
2017-10-05 19:13 ` Julia Lawall
2017-10-05 19:15 ` Joe Perches
2017-10-05 19:19 ` Julia Lawall
2017-10-05 19:30 ` Joe Perches
2017-10-05 19:40 ` Julia Lawall
2017-10-05 19:54 ` Joe Perches
2017-10-05 19:57 ` Julia Lawall
2017-10-05 19:46 ` Liam Breck
2017-10-05 19:54 ` Joe Perches
2017-10-05 19:58 ` Julia Lawall
2017-10-05 19:25 ` Liam Breck
2017-10-05 19:28 ` Julia Lawall [this message]
2017-10-05 19:20 ` Liam Breck
2017-10-05 19:25 ` Julia Lawall
2017-10-05 19:39 ` Liam Breck
2017-10-05 19:40 ` Julia Lawall
2017-10-09 2:50 ` Fengguang Wu
2017-10-09 6:39 ` Julia Lawall
2017-10-05 19:41 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.20.1710052127320.2626@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=fengguang.wu@intel.com \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=liam@networkimprov.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=nicolas.palix@imag.fr \
--cc=pali.rohar@gmail.com \
--cc=sebastian.reichel@collabora.co.uk \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox