Linux Power Management development
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	linux-pm@lists.linux-foundation.org,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS
Date: Wed, 13 Jul 2011 16:44:26 -0400 (EDT)	[thread overview]
Message-ID: <alpine.LFD.2.02.1107131640280.9546@x980> (raw)
In-Reply-To: <20110415101712.GB28007@elte.hu>


> So how about informing users, how about making it non-silent? An informative 
> printk that also mentions the power configuration tool, etc. This solves the 
> concerns i mentioned.

Something like this?

                rdmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
                if ((epb & 0xF) == 0) {
                        printk_once(KERN_WARN, "x86: updated energy_perf_bias"
                                " to 'normal' from 'performance'\n"
                                "You can view and update epb via utility,"
                                " such as x86_energy_perf_policy(8)\n");
                        epb = (epb & ~0xF) | ENERGY_PERF_BIAS_NORMAL;
                        wrmsrl(MSR_IA32_ENERGY_PERF_BIAS, epb);
                }

  parent reply	other threads:[~2011-07-13 20:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <alpine.LFD.2.02.1103301819250.31342@x980>
2011-04-14  9:08 ` [PATCH] x86 intel power: Initialize MSR_IA32_ENERGY_PERF_BIAS Ingo Molnar
     [not found] ` <20110414090854.GB9248@elte.hu>
2011-04-15  6:25   ` Len Brown
     [not found]   ` <alpine.LFD.2.02.1104150202310.29365@x980>
2011-04-15 10:17     ` Ingo Molnar
2011-04-20 13:14     ` Pavel Machek
     [not found]     ` <20110415101712.GB28007@elte.hu>
2011-07-13 20:44       ` Len Brown [this message]
2011-07-13 20:49         ` Linus Torvalds
2011-07-13 21:38           ` H. Peter Anvin
     [not found]           ` <4E1E106E.4060408@zytor.com>
2011-07-14  4:53             ` [PATCH v2] " Len Brown
     [not found]             ` <alpine.LFD.2.02.1107140051020.18606@x980>
2011-07-14 19:35               ` Rafael J. Wysocki
2011-07-15 21:37               ` [PATCH v3] " Len Brown
     [not found]     ` <20110420131442.GA29418@atrey.karlin.mff.cuni.cz>
2011-07-13 20:51       ` [PATCH] " Len Brown
2011-03-30 22:21 Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1107131640280.9546@x980 \
    --to=lenb@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=arjan@infradead.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox