From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Ulf Hansson <ulfh@kernel.org>, Heiko Stuebner <heiko@sntech.de>,
linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 4/4] pmdomain: rockchip: drop duplicated errno from supply failure message
Date: Fri, 18 Sep 2026 19:54:14 +0200 [thread overview]
Message-ID: <aq16py92V1vR7kcX@venus> (raw)
In-Reply-To: <1789733258-10133-5-git-send-email-shawn.lin@rock-chips.com>
[-- Attachment #1: Type: text/plain, Size: 976 bytes --]
Hi,
On Fri, Sep 18, 2026 at 08:07:38PM +0800, Shawn Lin wrote:
> dev_err_probe() already appends the error code.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
-- Sebastian
>
> drivers/pmdomain/rockchip/pm-domains.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/rockchip/pm-domains.c b/drivers/pmdomain/rockchip/pm-domains.c
> index e193f97..dd5e2987 100644
> --- a/drivers/pmdomain/rockchip/pm-domains.c
> +++ b/drivers/pmdomain/rockchip/pm-domains.c
> @@ -721,7 +721,7 @@ static int rockchip_pd_power_on(struct generic_pm_domain *domain)
> ret = rockchip_pd_regulator_enable(pd);
> if (ret)
> return dev_err_probe(pd->pmu->dev, ret,
> - "Failed to enable supply: %d\n", ret);
> + "Failed to enable supply\n");
>
> ret = rockchip_pd_power(pd, true);
> if (ret)
> --
> 2.7.4
>
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2026-09-18 17:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1789733258-10133-1-git-send-email-shawn.lin@rock-chips.com>
2026-09-18 12:07 ` [PATCH 1/4] pmdomain: rockchip: propagate subdomain add errors Shawn Lin
2026-09-18 17:18 ` Sebastian Reichel
2026-09-18 12:07 ` [PATCH 2/4] pmdomain: rockchip: fix clock leak on domain probe failure Shawn Lin
2026-09-18 17:21 ` Sebastian Reichel
2026-09-19 0:13 ` Shawn Lin
2026-09-20 1:15 ` Shawn Lin
2026-09-22 14:46 ` Sebastian Reichel
2026-09-18 12:07 ` [PATCH 3/4] pmdomain: rockchip: don't ignore clock lookup errors on attach Shawn Lin
2026-09-18 17:59 ` Sebastian Reichel
2026-09-18 12:07 ` [PATCH 4/4] pmdomain: rockchip: drop duplicated errno from supply failure message Shawn Lin
2026-09-18 17:54 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aq16py92V1vR7kcX@venus \
--to=sebastian.reichel@collabora.com \
--cc=heiko@sntech.de \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox