* [PATCH] OPP: Fix the return value in dev_pm_opp_get_of_node() kernel-doc
@ 2026-09-11 22:14 Karl Mehltretter
2026-10-01 6:11 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-09-11 22:14 UTC (permalink / raw)
To: Viresh Kumar, Nishanth Menon, Stephen Boyd
Cc: Karl Mehltretter, Ulf Hansson, Rajendra Nayak, Jordan Crouse,
linux-pm, linux-kernel
dev_pm_opp_get_of_node() returns NULL when the OPP is invalid, but its
kernel-doc says "else 0 on success", which was never true. Say NULL.
Fixes: e2f4b5f8dc59 ("PM / OPP: Implement dev_pm_opp_get_of_node()")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
drivers/opp/of.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/opp/of.c b/drivers/opp/of.c
index 2f3bbde9a9e1742a2d6b40be91a65d8fa7365bf3..ea93800795783f0595483742c0c10de42b25518a 100644
--- a/drivers/opp/of.c
+++ b/drivers/opp/of.c
@@ -1409,7 +1409,7 @@ bool dev_pm_opp_of_has_required_opp(struct device *dev)
* dev_pm_opp_get_of_node() - Gets the DT node corresponding to an opp
* @opp: opp for which DT node has to be returned for
*
- * Return: DT node corresponding to the opp, else 0 on success.
+ * Return: DT node corresponding to the opp, else NULL.
*
* The caller needs to put the node with of_node_put() after using it.
*/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] OPP: Fix the return value in dev_pm_opp_get_of_node() kernel-doc
2026-09-11 22:14 [PATCH] OPP: Fix the return value in dev_pm_opp_get_of_node() kernel-doc Karl Mehltretter
@ 2026-10-01 6:11 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2026-10-01 6:11 UTC (permalink / raw)
To: Karl Mehltretter
Cc: Viresh Kumar, Nishanth Menon, Stephen Boyd, Ulf Hansson,
Rajendra Nayak, Jordan Crouse, linux-pm, linux-kernel
On 12-09-26, 00:14, Karl Mehltretter wrote:
> dev_pm_opp_get_of_node() returns NULL when the OPP is invalid, but its
> kernel-doc says "else 0 on success", which was never true. Say NULL.
>
> Fixes: e2f4b5f8dc59 ("PM / OPP: Implement dev_pm_opp_get_of_node()")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
> drivers/opp/of.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/opp/of.c b/drivers/opp/of.c
> index 2f3bbde9a9e1742a2d6b40be91a65d8fa7365bf3..ea93800795783f0595483742c0c10de42b25518a 100644
> --- a/drivers/opp/of.c
> +++ b/drivers/opp/of.c
> @@ -1409,7 +1409,7 @@ bool dev_pm_opp_of_has_required_opp(struct device *dev)
> * dev_pm_opp_get_of_node() - Gets the DT node corresponding to an opp
> * @opp: opp for which DT node has to be returned for
> *
> - * Return: DT node corresponding to the opp, else 0 on success.
> + * Return: DT node corresponding to the opp, else NULL.
> *
> * The caller needs to put the node with of_node_put() after using it.
> */
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-01 6:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-11 22:14 [PATCH] OPP: Fix the return value in dev_pm_opp_get_of_node() kernel-doc Karl Mehltretter
2026-10-01 6:11 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox