From: Nandor Han <nandor.han@vaisala.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] power: reset: nvmem-reboot-mode: use NVMEM as reboot mode write interface
Date: Thu, 18 Apr 2019 09:29:08 +0300 [thread overview]
Message-ID: <b046dc29-002c-39a9-5a54-562c49adb691@vaisala.com> (raw)
In-Reply-To: <20190417215649.ejrvd6zekfmvjtn5@earth.universe>
On 4/18/19 12:56 AM, Sebastian Reichel wrote:
> On Thu, Apr 11, 2019 at 05:54:09AM +0000, Han Nandor wrote:
>> Add a new reboot mode write interface that is using an NVMEM cell
>> to store the reboot mode magic.
>>
>> Signed-off-by: Nandor Han <nandor.han@vaisala.com>
>> ---
<snip>
>> +module_platform_driver(nvmem_reboot_mode_driver);
>> +
>> +MODULE_AUTHOR("Nandor Han <nandor.han@vaisala.com>");
>> +MODULE_DESCRIPTION("NVMEM reboot mode driver");
>> +MODULE_LICENSE("GPL v2");
>
> I suppose as of bf7fbeeae6db "GPL v2" is deprecated, before it was
> often read as GPL v2 only. In both cases it makes sense to just
> use "GPL". Otherwise the driver looks fine to me, but I'm waiting
> for Rob's review of the DT bindings before merging this.
>
> -- Sebastian
>
Thanks Sebastian.
Do you want me to send a new revision with license changed to "GPL"?..or
will you change it when it's merged?
Nandor
next prev parent reply other threads:[~2019-04-18 6:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 5:54 [PATCH v2 0/2] Use NVMEM as reboot-mode write interface Han Nandor
2019-04-11 5:54 ` Han Nandor
2019-04-11 5:54 ` [PATCH v2 1/2] power: reset: nvmem-reboot-mode: use NVMEM as reboot mode " Han Nandor
2019-04-11 5:54 ` Han Nandor
2019-04-17 21:56 ` Sebastian Reichel
2019-04-17 21:56 ` Sebastian Reichel
2019-04-18 6:29 ` Nandor Han [this message]
2019-04-18 6:29 ` Nandor Han
2019-04-18 9:46 ` Sebastian Reichel
2019-04-18 9:46 ` Sebastian Reichel
2019-04-11 5:54 ` [PATCH v2 2/2] dt-bindings: power: reset: add document for NVMEM based reboot-mode Han Nandor
2019-04-11 5:54 ` Han Nandor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b046dc29-002c-39a9-5a54-562c49adb691@vaisala.com \
--to=nandor.han@vaisala.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox