From: Zhongqiu Han <zhongqiu.han@oss.qualcomm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Pierre Gondois <pierre.gondois@arm.com>,
linux-kernel@vger.kernel.org,
Lifeng Zheng <zhenglifeng1@huawei.com>,
Huang Rui <ray.huang@amd.com>,
"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Perry Yuan <perry.yuan@amd.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org, zhongqiu.han@oss.qualcomm.com
Subject: Re: [PATCH v7 2/2] cpufreq: Add boost_freq_req QoS request
Date: Thu, 26 Mar 2026 17:12:52 +0800 [thread overview]
Message-ID: <b6f2c170-f9ce-4050-bfbd-50597ea8b90d@oss.qualcomm.com> (raw)
In-Reply-To: <odpfr3sz5ualy2wnwpnpfbkjjjcmcydwm744aew2vnpbsnajdh@xd7pbkwnkwmu>
On 3/26/2026 4:50 PM, Viresh Kumar wrote:
> On 26-03-26, 16:18, Zhongqiu Han wrote:
>> Would it be reasonable to add a NULL check for policy->boost_freq_req in
>> policy_set_boost() before calling freq_qos_update_request(), even though
>> callers already check policy->boost_supported? Thanks
>
> Not required. policy_set_boost() should only be called if boost is supported.
>
Got it, thanks — no NULL check needed since boost_supported is the
precondition.
--
Thx and BRs,
Zhongqiu Han
next prev parent reply other threads:[~2026-03-26 9:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 16:52 [PATCH v7 0/2] cpufreq: Introduce boost frequency QoS Pierre Gondois
2026-03-25 16:52 ` [PATCH v7 1/2] cpufreq: Remove per-CPU QoS constraint Pierre Gondois
2026-03-26 4:37 ` Viresh Kumar
2026-03-26 8:10 ` Pierre Gondois
2026-03-25 16:52 ` [PATCH v7 2/2] cpufreq: Add boost_freq_req QoS request Pierre Gondois
2026-03-26 5:03 ` Viresh Kumar
2026-03-26 8:10 ` Pierre Gondois
2026-03-26 8:40 ` Viresh Kumar
2026-03-26 8:18 ` Zhongqiu Han
2026-03-26 8:50 ` Viresh Kumar
2026-03-26 9:12 ` Zhongqiu Han [this message]
2026-03-26 8:48 ` Viresh Kumar
2026-03-26 8:54 ` Pierre Gondois
2026-03-26 13:09 ` zhenglifeng (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6f2c170-f9ce-4050-bfbd-50597ea8b90d@oss.qualcomm.com \
--to=zhongqiu.han@oss.qualcomm.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perry.yuan@amd.com \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
--cc=zhenglifeng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox