From: Pierre Gondois <pierre.gondois@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-kernel@vger.kernel.org,
Lifeng Zheng <zhenglifeng1@huawei.com>,
Huang Rui <ray.huang@amd.com>,
"Gautham R. Shenoy" <gautham.shenoy@amd.com>,
Mario Limonciello <mario.limonciello@amd.com>,
Perry Yuan <perry.yuan@amd.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v7 2/2] cpufreq: Add boost_freq_req QoS request
Date: Thu, 26 Mar 2026 09:54:26 +0100 [thread overview]
Message-ID: <f9c94614-313d-4d2f-8374-cebb329a6c6f@arm.com> (raw)
In-Reply-To: <hajhezqrujiky7eo4eidogvjomixmhtdxpzfjibrd2xbhxawbd@ptljcesqpyqx>
On 3/26/26 09:48, Viresh Kumar wrote:
> On 25-03-26, 17:52, Pierre Gondois wrote:
>> @@ -1377,6 +1386,8 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy)
>> }
>>
>> freq_qos_remove_request(policy->min_freq_req);
> Since this doesn't check min_freq_req (and depend on the routine to return
> early), shouldn't we do the same for below one ?
Yes it is possible,
there were different views but without the check is ok aswell.
>
>> + if (policy->boost_freq_req)
>> + freq_qos_remove_request(policy->boost_freq_req);
>> kfree(policy->min_freq_req);
>>
>> cpufreq_policy_put_kobj(policy);
next prev parent reply other threads:[~2026-03-26 8:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-25 16:52 [PATCH v7 0/2] cpufreq: Introduce boost frequency QoS Pierre Gondois
2026-03-25 16:52 ` [PATCH v7 1/2] cpufreq: Remove per-CPU QoS constraint Pierre Gondois
2026-03-26 4:37 ` Viresh Kumar
2026-03-26 8:10 ` Pierre Gondois
2026-03-25 16:52 ` [PATCH v7 2/2] cpufreq: Add boost_freq_req QoS request Pierre Gondois
2026-03-26 5:03 ` Viresh Kumar
2026-03-26 8:10 ` Pierre Gondois
2026-03-26 8:40 ` Viresh Kumar
2026-03-26 8:18 ` Zhongqiu Han
2026-03-26 8:50 ` Viresh Kumar
2026-03-26 9:12 ` Zhongqiu Han
2026-03-26 8:48 ` Viresh Kumar
2026-03-26 8:54 ` Pierre Gondois [this message]
2026-03-26 13:09 ` zhenglifeng (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9c94614-313d-4d2f-8374-cebb329a6c6f@arm.com \
--to=pierre.gondois@arm.com \
--cc=gautham.shenoy@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=perry.yuan@amd.com \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
--cc=zhenglifeng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox