From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Luo Jie <quic_luoj@quicinc.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Varadarajan Narayanan <quic_varada@quicinc.com>,
Georgi Djakov <djakov@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Anusha Rao <quic_anusha@quicinc.com>,
Manikanta Mylavarapu <quic_mmanikan@quicinc.com>,
Devi Priya <quic_devipriy@quicinc.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Richard Cochran <richardcochran@gmail.com>,
Konrad Dybcio <konradybcio@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, quic_kkumarcs@quicinc.com,
quic_linchen@quicinc.com, quic_leiwei@quicinc.com,
quic_pavir@quicinc.com, quic_suruchia@quicinc.com
Subject: Re: [PATCH v5 02/10] dt-bindings: clock: Add required "interconnect-cells" property
Date: Fri, 12 Sep 2025 11:13:18 +0200 [thread overview]
Message-ID: <b7487ab1-1abd-40ca-8392-fdf63fddaafc@oss.qualcomm.com> (raw)
In-Reply-To: <20250912-nocturnal-horse-of-acumen-5b2cbd@kuoka>
On 9/12/25 9:04 AM, Krzysztof Kozlowski wrote:
> On Tue, Sep 09, 2025 at 09:39:11PM +0800, Luo Jie wrote:
>> The Networking Subsystem (NSS) clock controller acts as both a clock
>> provider and an interconnect provider. The #interconnect-cells property
>> is mandatory in the Device Tree Source (DTS) to ensure that client
>> drivers, such as the PPE driver, can correctly acquire ICC clocks from
>> the NSS ICC provider.
>>
>> Although this property is already present in the NSS CC node of the DTS
>> for CMN PLL for IPQ9574 SoC which is currently supported, it was previously
>> omitted from the list of required properties in the bindings documentation.
>> Adding this as a required property is not expected to break the ABI for
>> currently supported SoC.
>>
>> Marking #interconnect-cells as required to comply with Device Tree (DT)
>> binding requirements for interconnect providers.
>
> DT bindings do not require interconnect-cells, so that's not a correct
> reason. Drop them from required properties.
"Mark #interconnect-cells as required to allow consuming the provided
interconnect endpoints"?
Konrad
next prev parent reply other threads:[~2025-09-12 9:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 13:39 [PATCH v5 00/10] Add Network Subsystem (NSS) clock controller support for IPQ5424 SoC Luo Jie
2025-09-09 13:39 ` [PATCH v5 01/10] clk: qcom: gcc-ipq5424: Correct the icc_first_node_id Luo Jie
2025-09-09 13:39 ` [PATCH v5 02/10] dt-bindings: clock: Add required "interconnect-cells" property Luo Jie
2025-09-12 7:04 ` Krzysztof Kozlowski
2025-09-12 9:13 ` Konrad Dybcio [this message]
2025-09-12 9:13 ` Konrad Dybcio
2025-09-12 9:17 ` Krzysztof Kozlowski
2025-09-12 9:21 ` Konrad Dybcio
2025-09-12 9:27 ` Krzysztof Kozlowski
2025-09-12 9:41 ` Konrad Dybcio
2025-09-12 9:16 ` Krzysztof Kozlowski
2025-09-16 14:03 ` Luo Jie
2025-09-17 0:35 ` Krzysztof Kozlowski
2025-09-17 15:47 ` Luo Jie
2025-09-09 13:39 ` [PATCH v5 03/10] dt-bindings: interconnect: Add Qualcomm IPQ5424 NSSNOC IDs Luo Jie
2025-09-09 13:39 ` [PATCH v5 04/10] clk: qcom: gcc-ipq5424: Enable NSS NoC clocks to use icc-clk Luo Jie
2025-09-09 13:39 ` [PATCH v5 05/10] dt-bindings: clock: gcc-ipq5424: Add definition for GPLL0_OUT_AUX Luo Jie
2025-09-09 13:39 ` [PATCH v5 06/10] clk: qcom: gcc-ipq5424: Add gpll0_out_aux clock Luo Jie
2025-09-09 13:39 ` [PATCH v5 07/10] dt-bindings: clock: qcom: Add NSS clock controller for IPQ5424 SoC Luo Jie
2025-09-12 7:08 ` Krzysztof Kozlowski
2025-09-09 13:39 ` [PATCH v5 08/10] clk: qcom: Add NSS clock controller driver for IPQ5424 Luo Jie
2025-09-09 13:39 ` [PATCH v5 09/10] arm64: dts: qcom: ipq5424: Add NSS clock controller node Luo Jie
2025-09-09 13:39 ` [PATCH v5 10/10] arm64: defconfig: Build NSS clock controller driver for IPQ5424 Luo Jie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7487ab1-1abd-40ca-8392-fdf63fddaafc@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=djakov@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=quic_anusha@quicinc.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_kkumarcs@quicinc.com \
--cc=quic_leiwei@quicinc.com \
--cc=quic_linchen@quicinc.com \
--cc=quic_luoj@quicinc.com \
--cc=quic_mmanikan@quicinc.com \
--cc=quic_pavir@quicinc.com \
--cc=quic_suruchia@quicinc.com \
--cc=quic_varada@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox