From: Shuah Khan <skhan@linuxfoundation.org>
To: cryolitia@uniontech.com, Thomas Renninger <trenn@suse.com>,
Shuah Khan <shuah@kernel.org>,
"John B. Wyatt IV" <jwyatt@redhat.com>,
John Kacur <jkacur@redhat.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Wangyuli@uniontech.com, Guanwentao@uniontech.com,
Zhanjun@uniontech.com, Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] cpupower: repair mangled powercap comment
Date: Wed, 6 Aug 2025 17:37:35 -0600 [thread overview]
Message-ID: <b89a0377-2a1c-418f-a897-966cf1cd4789@linuxfoundation.org> (raw)
In-Reply-To: <20250806-mangled_cpupower-v1-1-1a559130326b@uniontech.com>
On 8/6/25 01:08, Cryolitia PukNgae via B4 Relay wrote:
> From: Cryolitia PukNgae <cryolitia@uniontech.com>
>
> The current comment exhibits clear patch application artifacts:
> 1. A stray '-' prefix indicating failed line removal
> 2. Broken sentence structure from improper context patching
>
> What appears to be version control residue has persisted since its
> initial introduction and through the 2022 kernel submission[1]. While
> my archaeological efforts only trace back to the 2017 openSUSE patch[2],
> the corrupted syntax suggests even older origins that remain elusive -
> perhaps maintainers with longer institutional memory could shed light
> on its provenance.
>
> Restore grammatical sanity by:
> - Removing the redundant second line with its leading '-'
> - Preserving only the primary statement about RAPL hardcoding
> - Eliminating the fragmented "should show up" clause
>
> The result reflects reality without speculative future-proofing.
>
> 1. https://lore.kernel.org/all/20221123111810.16017-2-trenn@suse.de/
> 2. https://build.opensuse.org/request/show/535512
Lots of information for a simple comment spacing change.
What are we fixing here? What happens if we don't fix it?
thanks,
-- Shuah
next prev parent reply other threads:[~2025-08-06 23:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 7:08 [PATCH] cpupower: repair mangled powercap comment Cryolitia PukNgae via B4 Relay
2025-08-06 23:37 ` Shuah Khan [this message]
2025-08-07 3:47 ` Cryolitia PukNgae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b89a0377-2a1c-418f-a897-966cf1cd4789@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=Guanwentao@uniontech.com \
--cc=Wangyuli@uniontech.com \
--cc=Zhanjun@uniontech.com \
--cc=cryolitia@uniontech.com \
--cc=jkacur@redhat.com \
--cc=jwyatt@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox